Page 1 of 1

Resource leak in VCardDisplayArea?

PostPosted: 19 Apr 2020, 18:32
by thomek
Hi,

VCardDisplayArea has the inner class CardAreaPanel.
Its static member allCardPanels is filled by the 'get' method.

If running an endless loop of AI battle matches, it looks like allCardPanels keeps growing.

CardAreaPanel includes the cleanup method resetForNewGame.
But there is no reference to that method (master/2020-04-12).

Thanks,
thomek

Re: Resource leak in VCardDisplayArea?

PostPosted: 20 Apr 2020, 00:31
by friarsol
Hey Thomek,

It would probably be more useful to create issues on our git for these leaks you are noticing, and maybe provide the full path. Since there might be some overlap between Mobile and Desktop files.
https://git.cardforge.org/core-developers/forge/issues

Re: Resource leak in VCardDisplayArea?

PostPosted: 20 Apr 2020, 01:33
by kevlahnota
I think thomek was referring to mobile port version, I just found it that the resetfornewgame() is not called.

Re: Resource leak in VCardDisplayArea?

PostPosted: 20 Apr 2020, 09:37
by thomek
friarsol wrote:It would probably be more useful to create issues on our git for these leaks you are noticing, and maybe provide the full path.
Sure, here you go: #1367
(No link, too spamy for a new user).