Resource leak in AI matches by ViewWinLose?

by **thomek** » 19 Apr 2020, 18:53

Hi,

MatchController.finishGame() eventually calls ViewWinLose.setVisible(true) after running an AI match.
This causes the ViewWinLose object to be stored in FOverlay.overlays.

It looks like setVisible(false) is never called on such ViewWinLose objects (master/2020-04-12).
Therefore they seem to remain forever in FOverlay.overlays.

Thanks,
thomek

by **friarsol** » 20 Apr 2020, 00:46

view.hide(); looks to be called in all of the three options during the WinLose Dialog. So I think that should appropriately set the window to false.

by **thomek** » 20 Apr 2020, 10:54

friarsol wrote:view.hide(); looks to be called in all of the three options during the WinLose Dialog. So I think that should appropriately set the window to false.

Thank you for your feedback, friarsol. I provided steps to reproduce with issue #1368.