Collectible Card Game Headquarters

friarisol wrote:Alright. So the last few days my local codebase has been an utter mess as I tried to untie some of the mess that was the Manapool. I think it's all straight now, but I want some good playing conditions to test out.

I ran the Mana_PartTest unit test with all successes. I even added in a test that would do Reaper King's Casting Cost and handles it by paying mana in non-sequential order. I think I'm going to try that in during a game environment and see if it still works.

I was testing the Snow Lands can give you infinite mana bug, and I believe that is fixed right now. The issue had to do with Mana being passed in as a String. Now it passes in as a Mana object, which holds a specific isSnow() boolean.

So gimme some ideas for funky things that I should test with the revamped ManaPool. A fair amount of destruction went on with it, so I definitely want to have a broad range of this tested up before submitting any code.

Oh and a related question. Can the Computer use any abilities that cost Snow mana? It seems like they may not be right now from the code I looked through, but maybe it was in a different area that is able to do it?

The new Mana work should also allow for cards that have payment restrictions to more easily be coded up (like Imperiosaur).

friarisol wrote:Alright I submitted the changes for this. If anyone notices anything funky lemme know and I'll try to fix it quickly.

When you notice something wrong give me specifics about what cards were used and how the situation arose so I can isolate the issue and try to resolve it quickly, since ManaPool can affect a lot of other things.

Code: Select all

An error has occured. You can copy/paste this message or save it to a file.
Please report this, plus what you tried to do, to:
   http://www.slightlymagic.net/forum/viewforum.php?f=26
If you don't want to register an account, you can mail it directly to
   mtgerror@yahoo.com


For input string: "RW"


Version:
Forge -- official beta: $Date: 2010-05-01 03:21:42 -0400 (Sat, 01 May 2010) $, SVN revision: $Revision: 916 $

OS: Mac OS X Version: 10.6.4 Architecture: x86_64

Java Version: 1.6.0_20 Vendor: Apple Inc.

Detailed error trace:
java.lang.NumberFormatException: For input string: "RW"
   at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
   at java.lang.Integer.parseInt(Integer.java:449)
   at java.lang.Integer.parseInt(Integer.java:499)
   at forge.ManaPool.addManaToFloating(ManaPool.java:129)
   at forge.ManaPool.addMana(ManaPool.java:105)
   at forge.Ability_Mana.resolve(Ability_Mana.java:266)
   at forge.MagicStack.add(MagicStack.java:113)
   at forge.GameAction.playSpellAbility(GameAction.java:3334)
   at forge.GameAction.playCard(GameAction.java:2897)
   at forge.InputUtil.playAnyCard(InputUtil.java:46)
   at forge.Input_Main.selectCard(Input_Main.java:49)
   at forge.GuiInput.selectCard(GuiInput.java:48)
   at forge.GuiDisplay3$7.mousePressed(GuiDisplay3.java:371)
   at java.awt.Component.processMouseEvent(Component.java:6345)
   at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
   at java.awt.Component.processEvent(Component.java:6113)
   at java.awt.Container.processEvent(Container.java:2085)
   at java.awt.Component.dispatchEventImpl(Component.java:4714)
   at java.awt.Container.dispatchEventImpl(Container.java:2143)
   at java.awt.Component.dispatchEvent(Component.java:4544)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4618)
   at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4279)
   at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4212)
   at java.awt.Container.dispatchEventImpl(Container.java:2129)
   at java.awt.Window.dispatchEventImpl(Window.java:2478)
   at java.awt.Component.dispatchEvent(Component.java:4544)
   at java.awt.EventQueue.dispatchEvent(EventQueue.java:635)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
   at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188)
   at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)


Chris H. wrote:I played several games without a problem in quest mode. After a couple of games I tapped a Boros Garrison to add R W to my mana pool and got this error:

Code: Select all

An error has occured. You can copy/paste this message or save it to a file.
Please report this, plus what you tried to do, to:
   http://www.slightlymagic.net/forum/viewforum.php?f=26
If you don't want to register an account, you can mail it directly to
   mtgerror@yahoo.com


There is an error in the card code for Boomerang:



Version:
Forge -- official beta: $Date: 2010-05-01 02:21:42 -0500 (Sat, 01 May 2010) $, SVN revision: $Revision: 916 $

OS: Windows Vista Version: 6.0 Architecture: x86

Java Version: 1.7.0-ea Vendor: Sun Microsystems Inc.

Detailed error trace:
java.lang.RuntimeException: Mana_Part : checkMana() error, argument mana is invalid mana, mana - C
   at forge.Mana_Part.checkSingleMana(Mana_Part.java:32)
   at forge.Mana_PartColor.<init>(Mana_PartColor.java:15)
   at forge.ManaCost.split(ManaCost.java:158)
   at forge.ManaCost.<init>(ManaCost.java:24)
   at forge.CardUtil.getConvertedManaCost(CardUtil.java:208)
   at forge.CardFactoryUtil.AI_getMostExpensivePermanent(CardFactoryUtil.java:44)
   at forge.CardFactory$19.canPlayAI(CardFactory.java:2625)
   at forge.ComputerAI_General.getPlayable(ComputerAI_General.java:230)
   at forge.ComputerAI_General.getMain1(ComputerAI_General.java:190)
   at forge.ComputerAI_General.playCards(ComputerAI_General.java:35)
   at forge.ComputerAI_General.main1(ComputerAI_General.java:26)
   at forge.ComputerAI_Input.think(ComputerAI_Input.java:41)
   at forge.ComputerAI_Input.showMessage(ComputerAI_Input.java:29)
   at forge.GuiInput.setInput(GuiInput.java:27)
   at forge.GuiInput.update(GuiInput.java:21)
   at java.util.Observable.notifyObservers(Observable.java:159)
   at java.util.Observable.notifyObservers(Observable.java:115)
   at forge.MyObservable.updateObservers(MyObservable.java:10)
   at forge.Phase.nextPhase(Phase.java:280)
   at forge.Phase.nextPhase(Phase.java:284)
   at forge.Phase.nextPhase(Phase.java:284)
   at forge.Phase.nextPhase(Phase.java:284)
   at forge.Phase.nextPhase(Phase.java:284)
   at forge.Phase.nextPhase(Phase.java:284)
   at forge.GuiDisplay4$25.actionPerformed(GuiDisplay4.java:781)
   at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2015)
   at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2338)
   at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
   at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
   at javax.swing.plaf.basic.BasicButtonListener$Actions.actionPerformed(BasicButtonListener.java:304)
   at javax.swing.SwingUtilities.notifyAction(SwingUtilities.java:1650)
   at javax.swing.JComponent.processKeyBinding(JComponent.java:2879)
   at javax.swing.JComponent.processKeyBindings(JComponent.java:2926)
   at javax.swing.JComponent.processKeyEvent(JComponent.java:2842)
   at java.awt.Component.processEvent(Component.java:6207)
   at java.awt.Container.processEvent(Container.java:2203)
   at java.awt.Component.dispatchEventImpl(Component.java:4790)
   at java.awt.Container.dispatchEventImpl(Container.java:2261)
   at java.awt.Component.dispatchEvent(Component.java:4616)
   at java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1905)
   at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:752)
   at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:1017)
   at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:889)
   at java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:717)
   at java.awt.Component.dispatchEventImpl(Component.java:4660)
   at java.awt.Container.dispatchEventImpl(Container.java:2261)
   at java.awt.Window.dispatchEventImpl(Window.java:2671)
   at java.awt.Component.dispatchEvent(Component.java:4616)
   at java.awt.EventQueue.dispatchEvent(EventQueue.java:651)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:255)
   at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:170)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:160)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:155)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:147)
   at java.awt.EventDispatchThread.run(EventDispatchThread.java:136)

friarisol wrote:Yea keep an eye out if it shows up again. My best guess is some token was created and the mana cost was set improperly.

Boomerang
U U
Instant
Return target permanent to its owner's hand.
spBounceTgt:Permanent:Hand

Code: Select all

} else if(Tgts[i].startsWith("Permanent")) {
    if(CardFactoryUtil.AI_getMostExpensivePermanent(choices, card, true) != null) results.add(CardFactoryUtil.AI_getMostExpensivePermanent(choices, card, true));
}