Removing some erroneous cards

[Sloth]

There are some cards with the whenever keyword that have some serious bugs that got reported more than once in the forum. Since the whenever keyword was coded by Beached As in a very independent way and me beeing incapable of seeing through this massive batch of code (which is scattered over a lot of files), I would suggest to remove the following cards until someone fixes these bugs of the whenever keyword:

Admonition Angel
Petravark
Ajani's Pridemate
Ageless Entity

I suggest to not completely remove them (not to break saved decks), but to remove them from random AI decks (with SVar:RemAIDeck:True) and giving them the Rarity "None", so they will no longer appear in quest mode.

I feel a little responsible since I added Petravark.

Are there more cards with serious bugs that should also get this treadment (maybe Ancestral Vision?)

Any other suggestions to fix this problem are welcome.

[Chris H.]

We have 22 cards which currently have a note as part of their spellText. Some of these notes refer to problems that are serious and these cards tend to get reported on the bug list.

The Spectral Searchlight NOTE refers to a fairly minor problem. Resuscitate is non-functional and this creates a bigger problem. Other cards with notes fall somewhere in between.

We can also add a note to the spellText to the 4 cards that you list. The notes help to warn users while creating constructed decks.

Giving cards a rarity of "SVar:Rarity:None" did not cause any problems in the brief test that I ran. But there may be unforeseen consequences.

[Rob Cashwalker]

I purposely wrote the Rarity parser to allow for Rarity:None or essentially Rarity:{Anything other than Mythic, Rare, Uncommon, Common}. This will remove it from sealed, random deck and quest cardpools.

[Sloth]

We can also add a note to the spellText to the 4 cards that you list. The notes help to warn users while creating constructed decks.

Giving cards a rarity of "SVar:Rarity:None" did not cause any problems in the brief test that I ran. But there may be unforeseen consequences.

Adding a note is a good idea!

Unless someone has any concerns, I will give this treatment to the following cards:

Admonition Angel
Petravark
Ajani's Pridemate
Ageless Entity
Ancestral Vision
Resuscitate

[Chris H.]

I purposely wrote the Rarity parser to allow for Rarity:None or essentially Rarity:{Anything other than Mythic, Rare, Uncommon, Common}. This will remove it from sealed, random deck and quest cardpools.

`
Thank you Rob. I see that you were looking ahead.

[Chris H.]

Adding a note is a good idea!

Unless someone has any concerns, I will give this treatment to the following cards:

Admonition Angel
Petravark
Ajani's Pridemate
Ageless Entity
Ancestral Vision
Resuscitate

`
I think that I added a NOTE to Ancestral Vision and Resuscitate at some point in the past. I also recently modified Card.getText() and a "\r\n" will now get inserted into the StringBuilder string sb just before the NOTE. This helps to separate the NOTE from the rest of the spellText description and makes it stand out.

[Chris H.]

I added a NOTE, "SVar:RemAIDeck:True" and a "SVar:Rarity:None" to Admonition Angel; Ageless Entity; Ajani's Pridemate and Petravark.

[AnonAT]

Wouldn't it be easier to just parse "NOTE" as "don't use anywhere without user's explicit request"?