Page 1 of 1

Scars of Mirrodin - easy cards

PostPosted: 17 Sep 2010, 17:09
by mtgrares
There are a few cards like Darksteel Myr which are easy to add to cards.txt. mtgsalvation has a good spoiler here. Of course the picture link would have to be updated later.

Code: Select all
Darksteel Myr
3
Artifact Creature Myr
no text
0/1
Indestructible
SVar:Rarity:Uncommon
SVar:Picture:http://forums.mtgsalvation.com/attachment.php?attachmentid=110682&d=1284590139

Re: Scars of Mirrodin - easy cards

PostPosted: 17 Sep 2010, 17:57
by mtgrares
I did notice around 10 Scars of Mirrodin cards in the 9/12 release, thanks.

Re: Scars of Mirrodin - easy cards

PostPosted: 17 Sep 2010, 20:08
by PhoenixAvenger
While we're on this topic, a couple more easy ones from the rumor mill:

Code: Select all
Name:Putrefax
ManaCost:3 G G
Types:Creature Horror
Text:no text
PT:5/3
K:Haste
K:Trample
K:Infect
K:At the beginning of the end step, sacrifice CARDNAME.
K:SVar:Rarity:Rare
K:SVar:Picture:http://forums.mtgsalvation.com/attachment.php?attachmentid=110762&d=1284707243
End
Code: Select all
Name:Darkslick Drake
ManaCost:2 U U
Types:Creature Drake
Text:no text
PT:2/4
K:Flying
K:WheneverKeyword:PermanentIntoGraveyard:Self:Graveyard:DrawCards/1:ControllingPlayer_Self:ASAP:No_Condition:No Special Condition:When Darkslick Drake is put into a graveyard from the battlefield, draw a card.
K:SVar:Rarity:Uncommon
K:SVar:Picture:http://forums.mtgsalvation.com/attachment.php?attachmentid=110664&d=1284537694
End
Copied almost directly from Groundbreaker and Kingfisher respectively.

Kemba's Skyguard (flying Venerable Monk for 1WW) should also be simple, but since that code seems to be confined to CardFactory, I can't do that one on my own (no etbAddPlayerLife keyword? Boo :wink:).

EDIT - Actually, Darkslick Drake does read "a graveyard" and not "your graveyard." That's what I get for reading the spoiler and not the actual card... #-o

Re: Scars of Mirrodin - easy cards

PostPosted: 17 Sep 2010, 20:14
by Sloth
PhoenixAvenger wrote:While we're on this topic, a couple more easy ones from the rumor mill:

Code: Select all
Name:Putrefax
ManaCost:3 G G
Types:Creature Horror
Text:no text
PT:5/3
K:Haste
K:Trample
K:Infect
K:At the beginning of the end step, sacrifice CARDNAME.
K:SVar:Rarity:Rare
K:SVar:Picture:http://forums.mtgsalvation.com/attachment.php?attachmentid=110762&d=1284707243
End
Code: Select all
Name:Darkslick Drake
ManaCost:2 U U
Types:Creature Drake
Text:no text
PT:2/4
K:Flying
K:WheneverKeyword:PermanentIntoGraveyard:Self:Graveyard:DrawCards/1:ControllingPlayer_Self:ASAP:No_Condition:No Special Condition:When Darkslick Drake is put into your graveyard from the battlefield, draw a card.
K:SVar:Rarity:Uncommon
K:SVar:Picture:http://forums.mtgsalvation.com/attachment.php?attachmentid=110664&d=1284537694
End
Copied almost directly from Groundbreaker and Kingfisher respectively. (The Drake would be more accurate if it specified the owner's graveyard, but I can't find the term right now.)

Kemba's Skyguard (flying Venerable Monk for 1WW) should also be simple, but since that code seems to be confined to CardFactory, I can't do that one on my own (no etbAddPlayerLife keyword? Boo :wink:).
Thank you for the cards PhoenixAvenger. I will add these cards to the SVN. And don't give up on Kemba's Skyguard, search for some other similar cards. It is keywordable.

Re: Scars of Mirrodin - easy cards

PostPosted: 17 Sep 2010, 20:51
by PhoenixAvenger
Sloth wrote:And don't give up on Kemba's Skyguard, search for some other similar cards. It is keywordable.
Aha! Found it on Devout Monk.

Code: Select all
Name:Kemba's Skyguard
ManaCost:1 W W
Types:Creature Cat Knight
Text:no text
PT:2/2
K:Flying
K:WheneverKeyword:EntersBattleField:Self:Play:ModifyLife/2:ControllingPlayer_Self:ASAP:No_Condition:No Special Condition:When Kemba's Skyguard enters the battlefield, you gain 2 life.
K:SVar:Rarity:Common
K:SVar:Picture:http://gatherer.wizards.com/Handlers/Image.ashx?multiverseid=227150&type=card
End
Makes me wonder why Venerable Monk and the Zendikar duals ( Akoum Refuge, etc.) aren't similarly handled. Though I gotta say, using Whenever here just looks rather clunky... Maybe I should just learn Java after all, how hard could it be? :twisted:

Re: Scars of Mirrodin - easy cards

PostPosted: 17 Sep 2010, 22:41
by zerker2000
The code does look a lot worse than the keyword:
Code: Select all
 //*************** START *********** START **************************
        else if(cardName.equals("Venerable Monk") || cardName.equals("Kitchen Finks")
                || cardName.equals("Shu Grain Caravan") || cardName.equals("Kemba's Skyguard")) {
            final SpellAbility ability = new Ability(card, "0") {
                @Override
                public void resolve() {
                    Card c = card;
                    PlayerLife life = AllZone.GameAction.getPlayerLife(c.getController());
                    life.addLife(2);
                }
            };
            Command intoPlay = new Command() {
                private static final long serialVersionUID = 1832932499373431651L;
               
                public void execute() {
                    ability.setStackDescription(card.getController() + " gains 2 life");
                    AllZone.Stack.add(ability);
                }
            };
            card.addComesIntoPlayCommand(intoPlay);
        }//*************** END ************ END **************************
Ooh, and it seems Kemba's Skyguard IS in the latest SVN.
Code Explanation(if needed) | Open
:
Code: Select all
//*************** START *********** START **************************
        else if(cardName.equals("Venerable Monk") || cardName.equals("Kitchen Finks")
                || cardName.equals("Shu Grain Caravan") || cardName.equals("Kemba's Skyguard")) {
For each of those four cards, let's
Code: Select all
final SpellAbility ability = new Ability(card, "0") {
contruct an ability
Code: Select all
@Override
public void resolve() {
that
Code: Select all
Card c = card;
takes the card's
Code: Select all
PlayerLife life = AllZone.GameAction.getPlayerLife(c.getController());
controller's life
Code: Select all
life.addLife(2);
and adds two to it.
Code: Select all
                }
            };
Then,
Code: Select all
Command intoPlay = new Command() {
    private static final long serialVersionUID = 1832932499373431651L;
we make an action,
Code: Select all
public void execute() {
which
Code: Select all
ability.setStackDescription(
calls the ability
Code: Select all
card.getController() + " gains 2 life"
"gain 2 life",
Code: Select all
);
and
Code: Select all
AllZone.Stack.add(ability);
puts it on stack.
Code: Select all
                }
            };
Finally,
Code: Select all
card.
we tell the card
Code: Select all
addComesIntoPlayCommand(intoPlay);
to do this every time it enters the attlefield.
Code: Select all
}//*************** END ************ END **************************
Hooray, we're done!

Re: Scars of Mirrodin - easy cards

PostPosted: 18 Sep 2010, 01:46
by PhoenixAvenger
zerker2000 wrote:Ooh, and it seems Kemba's Skyguard IS in the latest SVN.
Well, it looks like someone was going to add it, but, as I can't see any entry in cards.txt or cardsfolder for it, they either a) got distracted or b) added it in a revision later than 2112 (my rev when I posted) and forgot to mention it in the notes.

Either way, good to see that the keyword was redundant anyway. (Which revision was that code snippet from, out of curiosity?)

EDIT: Staying on topic, another couple of easy-to-do recent reveals:
Code: Select all
Name:Sylvok Replica
ManaCost:3
Types:Artifact Creature Shaman
Text:no text
PT:1/3
K:abDestroyTgtV G Sac<1/CARDNAME>:Artifact,Enchantment:Destroy target artifact or enchantment.
K:SVar:Rarity:Common
K:SVar:Picture:http://forums.mtgsalvation.com/attachment.php?attachmentid=110273&d=1283832127
End
Code: Select all
Name:Barrage Ogre
ManaCost:3 R R
Types:Creature Ogre Warrior
Text:no text
PT:3/3
K:abDamageTgtCP T Sac<1/Artifact>:2
K:SVar:Rarity:Uncommon
End
No picture available for the Ogre yet, sadly.

Re: Scars of Mirrodin - easy cards

PostPosted: 18 Sep 2010, 15:10
by zerker2000
I wouldn't call it "redundant", since as things stand, you'd gain 4 life for playing it.
The code was taken from http://cardforge.googlecode.com/svn/src ... tures.java (as viewed from firefox), so something around r2124.

Re: Scars of Mirrodin - easy cards

PostPosted: 19 Sep 2010, 13:33
by Chris H.
PhoenixAvenger wrote:Well, it looks like someone was going to add it, but, as I can't see any entry in cards.txt or cardsfolder for it, they either a) got distracted or b) added it in a revision later than 2112 (my rev when I posted) and forgot to mention it in the notes.
`
We would notice at times a case c). The original cards.txt file was the target of frequent edits by the devs. This would create conflicts that were hard to resolve since it was a text file. This would cause work to the cards.txt file to be overwritten and lost.

Our new system of using a cardsfolder should drastically reduce the chance that this would happen again. :D


Oh, and thank you for your contributions.

Re: Scars of Mirrodin - easy cards

PostPosted: 24 Sep 2010, 04:30
by slapshot5
Just a note to everyone about Scars of Mirrodin:

These cards are now in the Gatherer database, and pic URLs are available here:

http://www.wizards.com/global/images/magic/general/

-slapshot5

Re: Scars of Mirrodin - easy cards

PostPosted: 24 Sep 2010, 09:21
by Chris H.
slapshot5 wrote:Just a note to everyone about Scars of Mirrodin:

These cards are now in the Gatherer database, and pic URLs are available here:

http://www.wizards.com/global/images/magic/general/
`
Thank you. I have been busy recently with a real life crisis and have not had too much free time for the forge project. :(

I did find some time last night to search the existing card files and I have added the wotc pic url for all of the recent SoM cards that have been added. I will merge this material into the SVN later today.

Re: Scars of Mirrodin - easy cards

PostPosted: 24 Sep 2010, 09:33
by Sloth
Chris H. wrote:I did find some time last night to search the existing card files and I have added the wotc pic url for all of the recent SoM cards that have been added. I will merge this material into the SVN later today.
I did not check if it's all of them, but revision 2240 did update a lot of SoM pics.

Just another Info regarding this topic: The syntax of stPump is now final and Metalcraft is supported as a condition. So if someone wants to add some SoM cards consider these too (I will be busy implementing other conditions for stPump).

Re: Scars of Mirrodin - easy cards

PostPosted: 24 Sep 2010, 10:45
by Chris H.
Sloth wrote:I did not check if it's all of them, but revision 2240 did update a lot of SoM pics.
`
Yeah, I just noticed the updates. I have not had a chance to check it yet. It looks like we got the missing urls now. We also had about 6 pic urls from sites that provide a pic substantially larger than 200 x 285 pixels. It would also be nice to get those replaced.