Kinship cards

[Chris H.]

I have spent a little time recently looking at the existing Kinship cards. I added a new one and did a little work on another.

It strikes me now that these cards are just an approximation of the real card. I am now trying to modify one of these to be more rules compliant but am not sure if the additional mouse clicks will be welcome to the user base.

I got it working well for the computer but the human was generating the new version of the computer is thinking bug. It still worked but it was not fun to see the message.

I have some more work to do before I have some code to show. I am starting to think that I may need some help to figure this out.

[friarsol]

Well once your ready just create a patch of your work and post it up on the forums for some fresh eyes. I know a lot of times you work on something for a few days and it all gets blurred together.

[Chris H.]

Thank you Sol.

At this moment I think that we do not have to ask the human if they want to look at the top card of the Library at the beginning of the upkeep. In real life we would always look at the top card until we had gained the advantage and at that time we are ready to win the game and start the next match.

I guess that with forge things are different. We can assume that the answer is always yes. Can anyone think of a reason why we should give the human a choice at this point?

If top card of the Library matches the criteria, then give a choice to reveal the card and resolve the effect. The current kinship card implementation reveals the card if the criteria matches or not. Some cards give you the choice to resolve the effect.

[friarsol]

Thank you Sol.

At this moment I think that we do not have to ask the human if they want to look at the top card of the Library at the beginning of the upkeep. In real life we would always look at the top card until we had gained the advantage and at that time we are ready to win the game and start the next match.

I guess that with forge things are different. We can assume that the answer is always yes. Can anyone think of a reason why we should give the human a choice at this point?

If top card of the Library matches the criteria, then give a choice to reveal the card and resolve the effect. The current kinship card implementation reveals the card if the criteria matches or not. Some cards give you the choice to resolve the effect.

I can't see many times not wanting to actually look at the top card. Sometimes I wouldn't want to reveal based on what the advantage the card gives.
Maybe the first time it occurs we could have a third option "always yes" or something, which will set a variable in the spell ability so you won't ask them after that. This would be useful for a lot of abilities (like the Ally triggers).

[Chris H.]

For those who are curious, this is the original code block for Wolf-Skull Shaman. It works well and is fairly brief.

It does not give us a choice to reveal the top card of the library if the criteria matches. The name of the card appears on the stack whether the card matches the criteria or not.

Code: Select all

    private static void upkeep_Wolf_Skull_Shaman() {
        final String player = AllZone.Phase.getActivePlayer();
        PlayerZone playZone = AllZone.getZone(Constant.Zone.Play, player);
        PlayerZone library = AllZone.getZone(Constant.Zone.Library, player);

        CardList list = new CardList(playZone.getCards());
        list = list.getName("Wolf-Skull Shaman");

        Ability ability;
        for(int i = 0; i < list.size(); i++) {
            if(library.size() <= 0) {
                return;
            }
            // System.out.println("top of deck: " + library.get(i).getName());
            String creatureType = library.get(0).getType().toString();
            String cardName = library.get(0).getName();

            final Card crd = list.get(i);
            ability = new Ability(list.get(i), "0") {
                @Override
                public void resolve() {
                    PlayerZone library = AllZone.getZone(Constant.Zone.Library, player);

                    String creatureType = library.get(0).getType().toString();

                    if(creatureType.contains("Elf") || creatureType.contains("Shaman")
                            || library.get(0).getKeyword().contains("Changeling")) {
                        CardFactoryUtil.makeToken("Wolf", "G 2 2 Wolf", crd, "G",
                                new String[] {"Creature", "Wolf"}, 2, 2, new String[] {""});
                    }

                }// resolve()
            };// Ability
            if(creatureType.contains("Elf") || creatureType.contains("Shaman")) ability.setStackDescription("Wolf-Skull Shaman - "
                    + player + " reveals: " + cardName + ", and puts 2/2 Wolf into play.");
            else ability.setStackDescription("Wolf-Skull Shaman - " + player + " reveals top card: " + cardName
                    + ".");

            AllZone.Stack.add(ability);
        }// for
    }// upkeep_Wolf_Skull_Shaman()

[Chris H.]

This is an edited version and has a couple of minor improvements.

The setStackDescription() now uses StringBuilder and includes a test for changeling. We give the human a choice to put a token into play via a nice looking JOptionPane.showConfirmDialog() using yes/no buttons.

This version still displays the name of the card and it appears on the stack whether the card matches the criteria or not.

Code: Select all

    private static void upkeep_Wolf_Skull_Shaman() {
        final String player = AllZone.Phase.getActivePlayer();
        PlayerZone playZone = AllZone.getZone(Constant.Zone.Play, player);
        PlayerZone library = AllZone.getZone(Constant.Zone.Library, player);

        CardList list = new CardList(playZone.getCards());
        list = list.getName("Wolf-Skull Shaman");

        Ability ability;
        for (int i = 0; i < list.size(); i++) {
            if (library.size() <= 0) return;
           
            String creatureType = library.get(0).getType().toString();
            String cardName = library.get(0).getName();
            final Card crd = list.get(i);
           
            ability = new Ability(list.get(i), "0") {
                @Override
                public void resolve() {
                   
                    PlayerZone library = AllZone.getZone(Constant.Zone.Library, player);
                    String creatureType = library.get(0).getType().toString();

                    if (creatureType.contains("Elf")
                            || creatureType.contains("Shaman")
                            || library.get(0).getKeyword().contains("Changeling")) {
                       
                        if (player.equals(Constant.Player.Human)) {
                           
                            String title = "Wolf-Skull Shaman - Ability";
                            Object message = "Put a 2/2 green Wolf creature token into play?";
                           
                            int choice = JOptionPane.showConfirmDialog(null, message, title, JOptionPane.YES_NO_OPTION);
                           
                            if (choice == JOptionPane.YES_OPTION) {
                                CardFactoryUtil.makeToken("Wolf", "G 2 2 Wolf", crd, "G",
                                        new String[] {"Creature", "Wolf"}, 2, 2, new String[] {""});
                            }
                        } else {
                           
                            CardFactoryUtil.makeToken("Wolf", "G 2 2 Wolf", crd, "G",
                                    new String[] {"Creature", "Wolf"}, 2, 2, new String[] {""});
                        }
                    }
                }// resolve()
            };// Ability
           
            StringBuilder sb = new StringBuilder();
            sb.append("Wolf-Skull Shaman - ").append(player);
           
            if (creatureType.contains("Elf")
                    || creatureType.contains("Shaman")
                    || library.get(0).getKeyword().contains("Changeling")) {
               
                sb.append(" reveals: ").append(cardName).append(", and puts 2/2 Wolf into play.");
               
            } else {
               
                sb.append(" reveals top card: ").append(cardName).append(".");
            }
            ability.setStackDescription(sb.toString());
            AllZone.Stack.add(ability);
        }// for
    }// upkeep_Wolf_Skull_Shaman()

[Chris H.]

The next version that I am working on attempts to move most of the code out of the

Code: Select all

ability = new Ability(list.get(i), "0")

`
method.

I think that I can place the test for types + changeling and the option dialog outside of the ability. If we choose yes, then the ability would resolve. The ability would make a token, place the ability on the stack and this would reveal the info to the opponent.

I hope to have this code ready later today or tomorrow.

[Rob Cashwalker]

I think I can create an activated ability keyword like "abSetOption" or simply "abSetSVar"... so you can click on the card to turn on/off the "may" default.

[Chris H.]

This is the next version. The AI will always choose to reveal the top card if the criteria matches and the effect will always go onto the stack.

The Human gets a JOptionPane.showConfirmDialog() only if the criteria matches. The pic below shows both the JOptionPane.showConfirmDialog() and the possible error condition in the message window. The game can be continued and no error exception is generated.

Code: Select all

    private static void upkeep_Wolf_Skull_Shaman() {
        final String player = AllZone.Phase.getActivePlayer();
        PlayerZone playZone = AllZone.getZone(Constant.Zone.Play, player);
        PlayerZone playerLibrary = AllZone.getZone(Constant.Zone.Library, player);
       
        CardList list = new CardList(playZone.getCards());
        list = list.getName("Wolf-Skull Shaman");
       
        for (int i = 0; i < list.size(); i++) {
            if (playerLibrary.size() <= 0) return;
           
            PlayerZone library = AllZone.getZone(Constant.Zone.Library, player);
            String creatureType = library.get(0).getType().toString();
            String cardName = library.get(0).getName();
            final Card crd = list.get(i);
            final int choice[] = {JOptionPane.NO_OPTION};
           
            if (creatureType.contains("Elf")
                    || creatureType.contains("Shaman")
                    || library.get(0).getKeyword().contains("Changeling")) {
               
                if (player.equals(Constant.Player.Human)) {
                   
                    String title = "Wolf-Skull Shaman - Ability";
                    Object message = "Put a 2/2 green Wolf creature token into play?";
                    choice[0] = JOptionPane.showConfirmDialog(null, message, title, JOptionPane.YES_NO_OPTION);
                }
               
                if (choice[0] == JOptionPane.YES_OPTION
                        || player.equals(Constant.Player.Computer)) {
                   
                    Ability ability = new Ability(crd, "0") {
                        @Override
                        public void resolve() {
                           
                            CardFactoryUtil.makeToken("Wolf", "G 2 2 Wolf", crd, "G",
                                    new String[] {"Creature", "Wolf"}, 2, 2, new String[] {""});
                           
                        }// resolve()
                    };// ability
                   
                    StringBuilder sb = new StringBuilder();
                    sb.append("Wolf-Skull Shaman - ").append(player);
                    sb.append(" reveals: ").append(cardName).append(", and puts a 2/2 Wolf into play.");
                    ability.setStackDescription(sb.toString());
                    AllZone.Stack.add(ability);
                }
            }
        }// for
    }// upkeep_Wolf_Skull_Shaman()

`

[Chris H.]

I spent far too much time trying to track down the possible error that is displayed in the message window today. The "Phase: Until End of Turn" has sidelined me.

The Kinship card code blocks are located in the upkeep section of the GameActionUtil.java file and I just can not figure out how my last mods would trigger such an error message. Two different phases and all of that.

I thought that adding a

Code: Select all

AllZone.Display.showMessage("Top card in Library: " + cardName);

`
might overwrite the error message, but I was wrong. I am a little stuck at this time. I will wait on this and see if anyone has any ideas. Worst case, we can keep the kinship cards the way they are and I can add the yes/no option to them.

[Chris H.]

I spent some time trying a few things to fix the error message that appears in the message panel (see jpg picture above.) As far as I can tell, this code section is causing the problem, but I can not figure out how to fix it:

Code: Select all

String title = "Wolf-Skull Shaman - Ability";
Object message = "Put a 2/2 green Wolf creature token into play?";
choice[0] = JOptionPane.showConfirmDialog(null, message, title, JOptionPane.YES_NO_OPTION);

`
The error message does not hang the game and we can select the yes or no button and proceed. The error message does not appear in the message panel if I place this and the rest of the code inside of the spell ability. The error message only appears when this code is outside of the spell ability.

[Chris H.]

With the recent work done by Sol on the phases I decided to try my updated Wolf Skull Shaman code. I think that the code is a better representation of the real card. I also included a test deck for testing this code block. The original code and the new code can be found at CardFactoryUtil.upkeep_Wolf_Skull_Shaman() and was merged into the SVN at r3346.

The original code is commented out and my new code is the active code block. It is ready to go for testing.

For some reason, the code outside of the Ability appears to be taking place at end of turn while the ability takes place during upkeep. I realize that Sol is very busy but I thought he might want to take a quick look at this while his phase work is still fresh in his mind.

.

[friarsol]

Technically all the choices need to be inside of the Triggered Ability. It's weird about the stuff outside happening at end of the turn.

I moved everything into the Ability and it seems to be working properly for me. I added a small section where the AI will properly reveal to the player as well.

[Chris H.]

Thank you Sol. I see that I was mistaken about at which point the ability triggers. The ability triggers when we peek at the top card and not when we decide to create the token.

We have to assume that the human will always peek and the ability then triggers. We can't ask the player if they want to peek since that question will appear during the prior end of turn phase. I agree that this is weird.

I have a question that should be fairly easy for the people that know the rules far better than myself. Should the computer reveal cards that do not match the creature types of the Wolf Skull Shaman?

Currently, the original code and this newest version causes the computer to reveal the Wall of Vines, the Mox Emerald and the Mox Jet that are in my test deck.

I have this feeling, right or wrong, that we only reveal cards that match the creature types of the Wolf Skull Shaman.

[Hellfish]

As far as I understand, your feeling is correct.
Oracle:
...If it shares a creature type with Wolf-Skull Shaman, you may reveal it....