It is currently 29 Oct 2025, 15:56
   
Text Size

Hidden Keywords

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Agetian, friarsol, Blacksmith, KrazyTheFox, CCGHQ Admins

Hidden Keywords

Postby Sloth » 10 Oct 2010, 10:25

In order to support some cards that give some traits to permanents, but which do not give abilities to them ruleswise like Bubble Matrix, Dense Canopy or Cloak of Mists, I want to add another type of keyword to cards (besides Intrinsic, Extrinsic and OtherExtrinsic):

HiddenKeywords

What's special about them?:

- They won't be displayed.
- They won't get recognized by cards like Muraganda Petroglyphs.
- They won't be removed by cards like Humility or Snakeform.

My plan to implement them is not set in stone, but I think about doing it like with OtherExtrinsicKeywords:

- Not to change anything in enPump, eqPump, stPump, spPump , abPump etc. , I will just add "hidden" in front of the keyword in the cardfile.
- In addExtrinsicKeyword, if the keyword starts with hidden, the keyword will not be stored but redirected to addHiddenKeyword.
- getHiddenKeyword() gets called in getKeyword() and will deliver the strings without "hidden".
- getUnHiddenKeyword() will just be the old getKeyword(). To be used by getText() and Muraganda Petroglyphs etc.

Any complains or thoughts?
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Hidden Keywords

Postby Rob Cashwalker » 10 Oct 2010, 13:28

If I understand the issue correctly, it's really a matter of dealing with the layering of effects.

Starting with a vanilla 1/1 creature, Muraganda Petroglyphs would give it +2/+2. Enchant that creature with Cloak of Mists, and you should still end up with a 3/3 unblockable creature, right?

Bubble Matrix should be handled purely by the damage handling code, it shouldn't be granting damage prevention to the creatures.
The Force will be with you, Always.
User avatar
Rob Cashwalker
Programmer
 
Posts: 2167
Joined: 09 Sep 2008, 15:09
Location: New York
Has thanked: 5 times
Been thanked: 40 times

Re: Hidden Keywords

Postby Sloth » 10 Oct 2010, 14:59

Rob Cashwalker wrote:If I understand the issue correctly, it's really a matter of dealing with the layering of effects.

Starting with a vanilla 1/1 creature, Muraganda Petroglyphs would give it +2/+2. Enchant that creature with Cloak of Mists, and you should still end up with a 3/3 unblockable creature, right?

Bubble Matrix should be handled purely by the damage handling code, it shouldn't be granting damage prevention to the creatures.
It doesn't really have to do with layering. All these cards work like Bubble Matrix. They don't grant abilities to the creatures, but characteristics. Magic Compr. Rules 112.11.

It's just easier for us to treat these as abilities (and at the moment we do with all the mentioned cards). It would need alot of new keywords to implement the cards we already have (imagine cards like Infiltrate).
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Hidden Keywords

Postby Sloth » 12 Oct 2010, 14:13

I've submitted my first draft of hidden keywords. Just add "HIDDEN " in front of a keyword and it won't be displayed.

example:
Code: Select all
Name:Bubble Matrix
ManaCost:4
Types:Artifact
Text:no text
K:stPumpAll:Creature:0/0/HIDDEN Prevent all damage that would be dealt to CARDNAME.:No Condition:Prevent all damage that would be dealt to creatures.
SVar:RemAIDeck:True
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/bubble_matrix.jpg
End
Code: Select all
Name:Gaseous Form
ManaCost:2 U
Types:Enchantment Aura
Text:Prevent all combat damage that would be dealt to and dealt by enchanted creature.
K:Enchant creature
K:enPumpCurse:HIDDEN Prevent all combat damage that would be dealt to and dealt by CARDNAME.
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/gaseous_form.jpg
End
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Hidden Keywords

Postby Sloth » 12 Nov 2010, 11:58

Hidden keywords are now displayed separately as non-ability characteristics.

Card text will be displayed for example like this:

Code: Select all
Flying

Non ability characteristics:
Indestructible, Unblockable
I guess it's more user friendly to show what's going on (Especially with instants like Withstand Death)
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Hidden Keywords

Postby friarsol » 12 Nov 2010, 15:13

Definitely, that Treefolk game took way too long and I couldn't figure out why I couldn't kill anything. I somehow managed to win, but it was brutal.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Hidden Keywords

Postby Chris H. » 12 Nov 2010, 15:17

Sloth wrote:Hidden keywords are now displayed separately as non-ability characteristics.
`
This may help the user base with their bug reporting.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: Hidden Keywords

Postby silly freak » 12 Nov 2010, 21:53

Sloth wrote:Hidden keywords are now displayed separately as non-ability characteristics.

Card text will be displayed for example like this:

Code: Select all
Flying

Non ability characteristics:
Indestructible, Unblockable
I guess it's more user friendly to show what's going on (Especially with instants like Withstand Death)
these are not characteristics, though. i'd suggest the word "features". i know it's picky, but why settle for less ;)
___

where's the "trust me, that will work!" switch for the compiler?
Laterna Magica - blog, forum, project, 2010/09/06 release!
silly freak
DEVELOPER
 
Posts: 598
Joined: 26 Mar 2009, 07:18
Location: Vienna, Austria
Has thanked: 93 times
Been thanked: 25 times

Re: Hidden Keywords

Postby Sloth » 13 Nov 2010, 08:23

silly freak wrote:these are not characteristics, though. i'd suggest the word "features". i know it's picky, but why settle for less ;)
I'm ok with "features". Any other opinions or suggestions?
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Hidden Keywords

Postby Chris H. » 13 Nov 2010, 13:20

I'm OK with either "characteristics" or "features". Having the "Non ability " in front will help to emphasize the point is not a normal ability.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: Hidden Keywords

Postby friarsol » 13 Nov 2010, 15:10

Well according to the rules http://wiki.mtgsalvation.com/article/Indestructible they refer to it as a "quality" that's probably as good as any generic adjective.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Hidden Keywords

Postby Sloth » 17 Nov 2010, 08:06

I settled to call it features, because quality won't refer to all of the possible hidden keywords (I guessed).
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times


Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 9 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 9 users online :: 0 registered, 0 hidden and 9 guests (based on users active over the past 10 minutes)
Most users ever online was 9298 on 10 Oct 2025, 12:54

Users browsing this forum: No registered users and 9 guests

Login Form