It is currently 29 Oct 2025, 12:50
   
Text Size

discard in AbilityFactory

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Agetian, friarsol, Blacksmith, KrazyTheFox, CCGHQ Admins

discard in AbilityFactory

Postby slapshot5 » 19 Nov 2010, 07:51

Has anyone started with adding Discard abilities to AbilityFactory? I assume they'd go in AF_ZoneAffecting.

If no one has, I'll start looking at this tomorrow.

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: discard in AbilityFactory

Postby friarsol » 19 Nov 2010, 14:29

Go for it. I was planning on doing it a week ago, but you know how that works. It's a pretty straightforward AF so shouldn't take too long.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: discard in AbilityFactory

Postby slapshot5 » 20 Nov 2010, 07:16

Yikes, I've got some computer problems on this end. I'm not going to be able to get at this for a while.

If anyone else wants, feel free.

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: discard in AbilityFactory

Postby slapshot5 » 24 Nov 2010, 05:14

Ok, I'm back in business with a new machine. Hopefully I'll have something to check in for this in the next day or two.

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: discard in AbilityFactory

Postby slapshot5 » 24 Nov 2010, 07:39

The bulk of this work is done (r3802). There are a few work items left:

A few things are not implemented yet:
1) The RevealYouChoose discard mode
2) selecting "valid" cards to discard (like Creature.Blue, etc..)
3) a Discard Drawback ability

And then, convert all cards over.

I will be working on all this over the next couple of days.

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: discard in AbilityFactory

Postby slapshot5 » 25 Nov 2010, 03:51

This is completely done, with all cards converted over from using spDiscard to AF.

I have not check to see what all cards that are hardcoded could be converted to AF. But the old keyword is now commented out in SVN.

The only thing I have not done is add a specific createDrawbackDiscard() method. Is this needed? Is our goal to convert all DrawBacks to AF?

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: discard in AbilityFactory

Postby Chris H. » 25 Nov 2010, 13:12

Thank you. Good job. Converting over cards will take some time.

I think that Sol has started work on the AF subAbilities.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times


Return to Developer's Corner

Who is online

Users browsing this forum: Timothysow and 22 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 23 users online :: 1 registered, 0 hidden and 22 guests (based on users active over the past 10 minutes)
Most users ever online was 9298 on 10 Oct 2025, 12:54

Users browsing this forum: Timothysow and 22 guests

Login Form