It is currently 20 Oct 2020, 17:41
   
Text Size

Card Contributions

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, friarsol, Blacksmith, KrazyTheFox, Agetian, CCGHQ Admins

Re: Card Contributions

Postby Hellfish » 01 Feb 2011, 23:45

Committed. Thanks!

Regarding the Giant Shark, the triggers look fine to me, the only issue would be to pretty the card text up a bit by using the "Secondary$ True" parameter for one of the triggers and giving them both proper oracle descriptions.

EDIT: Tests check out fine, too. I'll go ahead and make the adjustments and commit it. Thanks!
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
User avatar
Hellfish
Programmer
 
Posts: 1297
Joined: 07 Jun 2009, 10:41
Location: South of the Pumphouse
Has thanked: 110 times
Been thanked: 169 times

Re: Card Contributions

Postby jeffwadsworth » 02 Feb 2011, 01:15

@Zilbert: Sorry about that; I am wrong. Thanks for the card.
jeffwadsworth
Super Tester Elite
 
Posts: 1168
Joined: 20 Oct 2010, 04:47
Location: USA
Has thanked: 286 times
Been thanked: 68 times

Re: Card Contributions

Postby Zirbert » 02 Feb 2011, 01:55

jeffwadsworth wrote:@Zilbert: Sorry about that; I am wrong. Thanks for the card.
@Jeff - No, upon further tire-kicking, I found some issues too. They're arguably obscure, but keep it from 100% functionality. I'd say it's at 95%, unless Hellfish's tweaks, which I'm looking forward to checking out, brought it up a notch. Whether that's good enough is up to the commit-status folks, and either decision is fine by me.

I posted about the problems a minute ago in Card Development Questions. I'm trying to do my stupid-question-asking and help-begging over there, and only post completed cards here, for the most part, this post being yet another exception.

No need for apologies - I appreciate how patient and helpful you and the other veterans are being with me as I try to figure this stuff out. Believe me, I intend to keep trying, probably with more lousy old cards that nobody would ever want to play with in the first place!

-Zirbert
Zirbert
 
Posts: 505
Joined: 13 Oct 2010, 16:04
Has thanked: 100 times
Been thanked: 19 times

Re: Card Contributions

Postby Zirbert » 02 Feb 2011, 02:24

Just to make up for Giant Shark, here's a card I'll actually play with:

Code: Select all
Name:Awakening
ManaCost:2 G G
Types:Enchantment
Text:no text
T:Mode$ Phase | Phase$ Upkeep | TriggerZones$ Battlefield | Execute$ TrigUntapAll | TriggerDescription$ At the beginning of each upkeep, untap all creatures and lands.
SVar:TrigUntapAll:AB$UntapAll | Cost$ 0 | ValidCards$ Creature,Land | SpellDescription$ untap all creatures and lands.
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/awakening.jpg
SetInfo:STH|Rare|http://magiccards.info/scans/en/sh/51.jpg
End
Zirbert
 
Posts: 505
Joined: 13 Oct 2010, 16:04
Has thanked: 100 times
Been thanked: 19 times

Re: Card Contributions

Postby lazylockie » 02 Feb 2011, 13:04

Name:Chandra's Spitfire
ManaCost:2 R
Types:Creature Elemental
Text:no text
PT:1/3
K:Flying
T:Mode$ DamageDone | ValidSource$ Card.YouCtrl | CombatDamage$ False | ValidTarget$ Opponent | TriggerZones$ Battlefield | Execute$ TrigPump | TriggerDescription$ Whenever an opponent is dealt noncombat damage, CARDNAME gets +3/+0 until end of turn.
SVar:TrigPump:AB$Pump | Cost$ 0 | NumAtt$ +3 | NumDef$ +0 | Defined$ Self
SVar:Rarity:Uncommon
SVar:Picture:http://www.wizards.com/global/images/magic/general/chandras_spitfire.jpg
SetInfo:M11|Uncommon|http://magiccards.info/scans/en/m11/129.jpg
End
lazylockie
 
Posts: 508
Joined: 13 Jul 2010, 22:44
Has thanked: 74 times
Been thanked: 15 times

Re: Card Contributions

Postby Zirbert » 03 Feb 2011, 02:46

Code: Select all
Name:Soulquake
ManaCost:3 U U B B
Types:Sorcery
Text:no text
A:SP$ChangeZoneAll | Cost$ 3 U U B B | ChangeType$ Creature | Origin$ Battlefield | Destination$ Hand | SubAbility$ SVar=GrabGraveyard
SVar:GrabGraveyard:DB$ChangeZoneAll | Cost$ 0 | ChangeType$ Creature | Origin$ Graveyard | Destination$ Hand | SpellDescription$ Return all creatures on the battlefield and all creature cards in graveyards to their owners' hands.
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/soulquake.jpg
SetInfo:ARB|Common|http://magiccards.info/scans/en/arb/30.jpg
End
I thought I'd be able to do this one in a single ability line, by putting both Graveyard and Battlefield in the Origin$ argument ("Origins$ Battlefield,Graveyard" or somesuch), but nothing that I tried worked. This way feels like a kludge, but it works.

-Zirbert
Last edited by Zirbert on 03 Feb 2011, 03:57, edited 1 time in total.
Zirbert
 
Posts: 505
Joined: 13 Oct 2010, 16:04
Has thanked: 100 times
Been thanked: 19 times

Re: Card Contributions

Postby friarsol » 03 Feb 2011, 03:52

Zirbert wrote:I thought I'd be able to this one in a single ability line, by putting both Graveyard and Battlefield in the Origin$ argument ("Origins$ Battlefield,Graveyard" or somesuch), but nothing that I tried worked. This way feels like a kludge, but it works.
ChangeZone doesn't support multiple Zones as Origins. I don't know why it should feel like a kludge though. It's doing exactly what you want.
friarsol
Global Moderator
 
Posts: 7552
Joined: 15 May 2010, 04:20
Has thanked: 242 times
Been thanked: 952 times

Re: Card Contributions

Postby Zirbert » 03 Feb 2011, 04:01

friarsol wrote:
Zirbert wrote:I thought I'd be able to this one in a single ability line, by putting both Graveyard and Battlefield in the Origin$ argument ("Origins$ Battlefield,Graveyard" or somesuch), but nothing that I tried worked. This way feels like a kludge, but it works.
ChangeZone doesn't support multiple Zones as Origins. I don't know why it should feel like a kludge though. It's doing exactly what you want.
I just thought it would be kind of neat (to use the technical term) to be able to do such a big effect in a single line. This is one of those cases where I saw the card in my binder, and thought, "Hey, that looks easy!" Turned out to be not quite as simple as I thought, although I was happy that I got the SubAbility working with only a few misfired attempts along the way!

-Zirbert
Zirbert
 
Posts: 505
Joined: 13 Oct 2010, 16:04
Has thanked: 100 times
Been thanked: 19 times

Re: Card Contributions

Postby Zirbert » 03 Feb 2011, 04:23

Last one for tonight:

Code: Select all
Name:Burgeoning
ManaCost:G
Types:Enchantment
Text:no text
T:Mode$ PlayedLand | ValidCard$ Land.YouDontCtrl | TriggerZones$ Battlefield | Optional$ True | Execute$ TrigDropLand | TriggerDescription$ Whenever an opponent plays a land, you may put a land card from your hand onto the battlefield.
SVar:TrigDropLand:AB$ChangeZone | Costs$ 0 | Origin$ Hand | Destination$ Battlefield | ChangeType$ Land | ChangeNum$ 1
SVar:Picture:http://www.wizards.com/global/images/magic/general/burgeoning.jpg
SetInfo:STH|Rare|http://magiccards.info/scans/en/sh/52.jpg
End
Warning - I haven't tested this one. Since I'm not using the latest SVN version, the PlayedLand trigger isn't available for me yet. I wanted to code a card that used it, though, because Hellfish was nice enough to create a PlayedLand trigger immediately when I requested it. Especially since it turns out I can't do the cards I really intended to (Recycle and Null Profusion) - "skip your draw step" appears to require hardcoding at this time. I'd hate to let the new trigger go to waste, though.

This card seems pretty straightforward, so I think it'll work (famous last words). It's mostly based on Citanul Druid (When opponent plays...) and Elvish Piper (...put X onto the battlefield from your hand) with the relevant parameters changed.
Zirbert
 
Posts: 505
Joined: 13 Oct 2010, 16:04
Has thanked: 100 times
Been thanked: 19 times

Re: Card Contributions

Postby friarsol » 03 Feb 2011, 04:28

Zirbert wrote:
Code: Select all
Name:Soulquake
A:SP$ChangeZoneAll | Cost$ 3 U U B B | ChangeType$ Creature | Origin$ Battlefield | Destination$ Hand | SubAbility$ SVar=GrabGraveyard
SVar:GrabGraveyard:DB$ChangeZoneAll | Cost$ 0 | ChangeType$ Creature | Origin$ Graveyard | Destination$ Hand | SpellDescription$ Return all creatures on the battlefield and all creature cards in graveyards to their owners' hands.
Just so you know. Drawbacks do NOT require Costs like AB and SP do. By being a drawback, it knows the parent ability is already handling the cost.
friarsol
Global Moderator
 
Posts: 7552
Joined: 15 May 2010, 04:20
Has thanked: 242 times
Been thanked: 952 times

Re: Card Contributions

Postby friarsol » 03 Feb 2011, 04:38

Zirbert wrote:Especially since it turns out I can't do the cards I really intended to (Recycle and Null Profusion) - "skip your draw step" appears to require hardcoding at this time. I'd hate to let the new trigger go to waste, though.
I added some hardcoded draw step skippers for you and added the new issue for a skip step/phase keyword as 114 http://code.google.com/p/cardforge/issues/detail?id=114
friarsol
Global Moderator
 
Posts: 7552
Joined: 15 May 2010, 04:20
Has thanked: 242 times
Been thanked: 952 times

Re: Card Contributions

Postby Zirbert » 03 Feb 2011, 05:36

friarsol wrote:
Zirbert wrote:Especially since it turns out I can't do the cards I really intended to (Recycle and Null Profusion) - "skip your draw step" appears to require hardcoding at this time. I'd hate to let the new trigger go to waste, though.
I added some hardcoded draw step skippers for you and added the new issue for a skip step/phase keyword as 114 http://code.google.com/p/cardforge/issues/detail?id=114
Sol, have I mentioned lately that you rock, and mightily at that? It bears repeating.

-Zirbert
Zirbert
 
Posts: 505
Joined: 13 Oct 2010, 16:04
Has thanked: 100 times
Been thanked: 19 times

Re: Card Contributions

Postby Sloth » 03 Feb 2011, 06:28

Zirbert wrote:Last one for tonight:

Code: Select all
Name:Burgeoning
ManaCost:G
Types:Enchantment
Text:no text
T:Mode$ PlayedLand | ValidCard$ Land.YouDontCtrl | TriggerZones$ Battlefield | Optional$ True | Execute$ TrigDropLand | TriggerDescription$ Whenever an opponent plays a land, you may put a land card from your hand onto the battlefield.
SVar:TrigDropLand:AB$ChangeZone | Costs$ 0 | Origin$ Hand | Destination$ Battlefield | ChangeType$ Land | ChangeNum$ 1
SVar:Picture:http://www.wizards.com/global/images/magic/general/burgeoning.jpg
SetInfo:STH|Rare|http://magiccards.info/scans/en/sh/52.jpg
End
Warning - I haven't tested this one. Since I'm not using the latest SVN version, the PlayedLand trigger isn't available for me yet. I wanted to code a card that used it, though, because Hellfish was nice enough to create a PlayedLand trigger immediately when I requested it. Especially since it turns out I can't do the cards I really intended to (Recycle and Null Profusion) - "skip your draw step" appears to require hardcoding at this time. I'd hate to let the new trigger go to waste, though.

This card seems pretty straightforward, so I think it'll work (famous last words). It's mostly based on Citanul Druid (When opponent plays...) and Elvish Piper (...put X onto the battlefield from your hand) with the relevant parameters changed.
I've added Burgeoning, but Soulquake was already added a few days ago.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Card Contributions

Postby jhhh » 03 Feb 2011, 15:17

Name:Manabond
ManaCost:G
Types:Enchantment
Text:no text
T:Mode$ Phase | Phase$ End of Turn | ValidPlayer$ You |TriggerZones$ Battlefield | Optional$ True | Execute$ TrigChangeAll | TriggerDescription$ At the beginning of your end step, you may reveal your hand and put all land cards from it onto the battlefield. If you do, discard your hand.
SVar:TrigChangeAll:AB$ChangeZoneAll | Cost$ 0 | ChangeType$ Land.YouCtrl | Origin$ Hand | Destination$ Battlefield | SubAbility$ SVar=DBDiscard
SVar:DBDiscard:DB$Discard | Mode$ Hand
SVar:Rarity:Rare
SVar:Picture:http://magiccards.info/scans/en/ex/113.jpg
End
jhhh
 
Posts: 58
Joined: 15 Oct 2010, 23:40
Has thanked: 0 time
Been thanked: 0 time

Re: Card Contributions

Postby jeffwadsworth » 03 Feb 2011, 17:19

@jhhh, added but put someone else's nick on it. Sorry about that. Thanks for the great card.
jeffwadsworth
Super Tester Elite
 
Posts: 1168
Joined: 20 Oct 2010, 04:47
Location: USA
Has thanked: 286 times
Been thanked: 68 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 29 guests


Who is online

In total there are 29 users online :: 0 registered, 0 hidden and 29 guests (based on users active over the past 10 minutes)
Most users ever online was 1371 on 09 Feb 2020, 16:22

Users browsing this forum: No registered users and 29 guests

Login Form