Page 12 of 85

Re: Card Contributions

PostPosted: 05 Feb 2011, 22:19
by Sloth
I've added these cards from lazylockie

As well as the ten taplands, Forbid and Spore Flower from jhhh and Zirbert.

Thanks for the massive contributions today folks. This will be all from me today. I hope some else keeps the SVN up to date with the forum posts.

Re: Card Contributions

PostPosted: 06 Feb 2011, 03:02
by Chris H.
lazylockie wrote:more random cards:

Grixis Charm
Jund Charm
`
You may want to take a look at the existing charms in the deck editor and then look at the card files. :D

Re: Card Contributions

PostPosted: 06 Feb 2011, 03:45
by lazylockie
Chris H. wrote:
lazylockie wrote:more random cards:

Grixis Charm
Jund Charm
`
You may want to take a look at the existing charms in the deck editor and then look at the card files. :D
They were done already? I was at revision 6135 when I made those

Re: Card Contributions

PostPosted: 06 Feb 2011, 03:52
by Chris H.
lazylockie wrote:They were done already? I was at revision 6135 when I made those
`
The existing charms are using a specific style for the SpellDescription$. For example, this is the card file for Esper Charm:

Name:Esper Charm
ManaCost:W U B
Types:Instant
Text:no text
A:SP$Destroy | Cost$ W U B | ValidTgts$ Enchantment | TgtPrompt$ Select target Enchantment. | SpellDescription$ Choose one - Destroy target Enchantment;
A:SP$Draw | Cost$ W U B | NumCards$ 2 | SpellDescription$ or draw two cards;
A:SP$Discard | Cost$ W U B | ValidTgts$ Player | NumCards$ 2 | Mode$ TgtChoose | SpellDescription$ or target player discards two cards.
SVar:RemAIDeck:True
SVar:Rarity:Uncommon
SVar:Picture:http://www.wizards.com/global/images/magic/general/esper_charm.jpg
SetInfo:ALA|Uncommon|http://magiccards.info/scans/en/ala/167.jpg
End
`
Take a look at this charm in the deck editor, check out how nicely the text looks when it is written this way. 8)

Re: Card Contributions

PostPosted: 06 Feb 2011, 04:03
by lazylockie
Chris H. wrote:
lazylockie wrote:They were done already? I was at revision 6135 when I made those
`
The existing charms are using a specific style for the SpellDescription$. For example, this is the card file for Esper Charm:

Name:Esper Charm
ManaCost:W U B
Types:Instant
Text:no text
A:SP$Destroy | Cost$ W U B | ValidTgts$ Enchantment | TgtPrompt$ Select target Enchantment. | SpellDescription$ Choose one - Destroy target Enchantment;
A:SP$Draw | Cost$ W U B | NumCards$ 2 | SpellDescription$ or draw two cards;
A:SP$Discard | Cost$ W U B | ValidTgts$ Player | NumCards$ 2 | Mode$ TgtChoose | SpellDescription$ or target player discards two cards.
SVar:RemAIDeck:True
SVar:Rarity:Uncommon
SVar:Picture:http://www.wizards.com/global/images/magic/general/esper_charm.jpg
SetInfo:ALA|Uncommon|http://magiccards.info/scans/en/ala/167.jpg
End
`
Take a look at this charm in the deck editor, check out how nicely the text looks when it is written this way. 8)
Oh now I see what you mean. Usually SpellDescription is the last thing I check when doing a card, but I'll take your advise and look for known patterns of writing. I just find annoying to open/close forge just to check if the card text is fine heh

Re: Card Contributions

PostPosted: 06 Feb 2011, 09:55
by Sloth
I've added these cards from lazylockie:
lazylockie wrote:Kaervek the Merciless
Leonin Armorguard
Manaplasm
Mangara of Corondor - works exactly as intended, combos with Karakas as expected (!!!)
Rimescale Dragon - remodeled Gwafa Hazid, Profiteer
Serrated Biskelion
I did not add these:
Citadel of Pain - The AI will die a horrible death, not knowing how to react to this card.
Enclave Cryptologist and Joraga Treespeaker - Were submited by PhoenixAvenger already
Grixis Charm and Jund Charm - see Chris' posts
Tormod's Crypt - still need to change the hardcoded stuff and test. Looks ok.

I've also added Sporoloth Ancient by Zirbert. Chris has added Flurry of Wings. Thanks to both of you Zirbert and lazylockie.

Re: Card Contributions

PostPosted: 06 Feb 2011, 13:37
by Chris H.
lazylockie wrote:Oh now I see what you mean. Usually SpellDescription is the last thing I check when doing a card, but I'll take your advise and look for known patterns of writing. I just find annoying to open/close forge just to check if the card text is fine heh
`
Yeah, most of the cards use a fairly standard SpellDescription. Charms, Evoke and a few others are somewhat different. :D

Can you edit your two charms to match the existing ones and then attach a zip? I will gladly merge these two cards in later today. 8)

Re: Card Contributions

PostPosted: 06 Feb 2011, 15:24
by friarsol
Sloth wrote:I've added....
Thanks Sloth. I was out most of the day and and don't want you guys that are posting cards for people to feel overwhelmed.

On the other hand, those of you posting lots of cards need to test the cards, doublecheck their descriptions in game, and check their names. It's one thing for us to look them over, but if it's taking as much (or more) time editing as it did for you to write the card, that needs to be improved. I'm sure Sloth would rather be spending an hour improving the Combat AI then fixing details of incorrect cards. We definitely appreciate the new cards, but it's not a race. Play nice, split the cards evenly so there are no repeats and take your time.

Thanks

Re: Card Contributions

PostPosted: 06 Feb 2011, 22:22
by lazylockie
This time I've double-checked the whole script for each card, then I've tested all of them. Following cards attached on zip:

Bloodhall Ooze
Briar Patch
Dispersing Orb
Electrolyze <- uses the same coding of Pyrokinesis
Exploding Borders <- it's targeting (a player) before searching the land, although the damage is done after the land is put into battlefield
Extractor Demon
Fleshformer
Freewind Equenaut
Goblin Razerunners
Grixis Charm <- description rewritten
Ignite Disorder <- also use Pyrokinesis coding
Jund Charm <- description rewritten
Kiku's Shadow
Kiku, Night's Flower <- the solution is so simple, yet took me 3 days to write it haha
Lifetap <- with triggers
Norwood Warrior
Oona's Grace
Parasitic Strix <- issue: triggers only when the condition is met
Rhox Meditant <- same
Scryb Ranger
Sedraxis Alchemist <- same issue
Sludge Strider
Tectonic Break
Thoughtleech
Vigilant Martyr
Wilderness Hypnotist

Re: Card Contributions

PostPosted: 06 Feb 2011, 23:06
by Zirbert
friarsol wrote:
Sloth wrote:I've added....
Thanks Sloth. I was out most of the day and and don't want you guys that are posting cards for people to feel overwhelmed.

On the other hand, those of you posting lots of cards need to test the cards, doublecheck their descriptions in game, and check their names. It's one thing for us to look them over, but if it's taking as much (or more) time editing as it did for you to write the card, that needs to be improved. I'm sure Sloth would rather be spending an hour improving the Combat AI then fixing details of incorrect cards. We definitely appreciate the new cards, but it's not a race. Play nice, split the cards evenly so there are no repeats and take your time.

Thanks
For my part, Sol, I'm going to stop coding cards that I can't test, unless and until I start using the svn locally. I've caused problems twice now by posting cards that I couldn't test first (Sporoloth Ancient and Selective Memory), and I think knocking it off ASAP is in order. Sorry about that!

-Zirbert

Re: Card Contributions

PostPosted: 07 Feb 2011, 13:28
by Hellfish

Re: Card Contributions

PostPosted: 07 Feb 2011, 13:45
by lazylockie

Re: Card Contributions

PostPosted: 07 Feb 2011, 15:45
by Hellfish

Re: Card Contributions

PostPosted: 07 Feb 2011, 16:59
by Replika
Now that you're doing Ravnica, is Bathe in Light a candidate or are the Radiance cards still not doable?

Re: Card Contributions

PostPosted: 07 Feb 2011, 17:00
by Hellfish
Dissension:
Code: Select all
Azorius AEthermage
Bond of Agony
Freewind Equenaut
Gobhobbler Rats
Hellhole Rats ?
Nettling Curse
Nihilistic Glee
Protean Hulk ?
Psychotic Fury
Ragamuffyn
Stomp and Howl
Tidespout Tyrant
Wakestone Gargoyle
War's Toll ?
EDIT: Radiance is unfortunately not catered to yet. AI is ,as always :P , the hurdle IMHO.