Collectible Card Game Headquarters

I think we could simplify several things in our code if we made a static ability pump for basic land types. That way, we could just look at types and assign abilities "on the fly" so to speak.

Example:
Things like Tidal Warrior could just use AF_Animate to change type to Island, then the static pump would handle the mana ability. Also useful for Blood Moon, Urborg, Tomb of Yawgmoth, etc.

Thoughts? Potential hangups?

-slapshot5

slapshot5 wrote:I think we could simplify several things in our code if we made a static ability pump for basic land types. That way, we could just look at types and assign abilities "on the fly" so to speak.

Example:
Things like Tidal Warrior could just use AF_Animate to change type to Island, then the static pump would handle the mana ability. Also useful for Blood Moon, Urborg, Tomb of Yawgmoth, etc.

Thoughts? Potential hangups?

-slapshot5

Agreed. When I was converting AFs for Mana I was thinking it would be so much easier for the 5 basic land types to be granted mana abilities, instead of having it written out.

Can Animate handle hiding existing abilities that the card already has?

friarsol wrote:Can Animate handle hiding existing abilities that the card already has?

Not currently. It can overwrite types and colors only.

-slapshot5

So, I suppose I can just put a call to:

GameActionUtil.stLandManaAbilities.execute() in GameAction.checkStateEffects()?

Or is there a better way to handle it?

I've checked something in for this. If you see any problems with basic lands or dual lands with the basic land types, or the auras that change land types, please let me know.

-slapshot5

Also, are there any other cards in Forge that will need to be updated for this? It's not easy to search the source code for things that would need to be changed.

-slapshot5

slapshot5 wrote:Also, are there any other cards in Forge that will need to be updated for this? It's not easy to search the source code for things that would need to be changed.

-slapshot5

Maybe Spreading Seas and friends?

I got the auras. They should work.

-slapshot5