Heap space issues
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
14 posts
• Page 1 of 1
Heap space issues
by timmermac » 03 Jul 2011, 05:12
I've downloaded Eclipse and Subclipse and am running Forge from inside of that. Even with changing eclipse.ini to have -Xms1000m -Xmx1000, running GUI_NewGame results in Forge only getting a heap of 266338304 bytes. I did a text search within the project, and I discovered a few instances of -Xmx1024m, however, I'm not sure that that is ever being reached. I'm thinking that perhaps there needs to be -Xms1000m parameters entered into the code at the appropriate places as well.
"I just woke up, haven't had coffee, let alone a pee in 7 days, and I find out you stole my ass and made a ...mini-me! Carter, I should be irked currently, yes?" - Jack O'Neill
Re: Heap space issues
by Chris H. » 03 Jul 2011, 12:35
The params in the eclipse.ini probably only effect the Eclipse app itself and most likely have no effect on the java code (ex: Forge) that is run from within Eclipse.
Try this instead. Go to:
Run -> Run Configurations... -> Java Application -> your run configuration
Click on the second tab which should be named (x)= Arguments. Start off by adding the VM argument to the correct box and then click on the Apply button. Run Forge for a few games and see how it behaves.
You can then add in your program arguments to the other box and run the same tests.
Note that the arguments that you want to apply to forge while running forge from within the Eclipse dev system need to be added to this Run Configurations window, and make sure to click on the Apply button. The pic below only displays the VM argument, I forgot to add in the program argument but this should be enough to get you started. Good luck.
`
Try this instead. Go to:
Run -> Run Configurations... -> Java Application -> your run configuration
Click on the second tab which should be named (x)= Arguments. Start off by adding the VM argument to the correct box and then click on the Apply button. Run Forge for a few games and see how it behaves.
You can then add in your program arguments to the other box and run the same tests.
Note that the arguments that you want to apply to forge while running forge from within the Eclipse dev system need to be added to this Run Configurations window, and make sure to click on the Apply button. The pic below only displays the VM argument, I forgot to add in the program argument but this should be enough to get you started. Good luck.
`
- Attachments
-
Last edited by Chris H. on 03 Jul 2011, 23:14, edited 1 time in total.
Reason: spelling
Reason: spelling
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: Heap space issues
by timmermac » 04 Jul 2011, 00:27
I was running Forge concurrently with VisualVM with the -Xms1000m -Xmx1000m arguments added into the run configuration, and I'm still having some issues. For whatever reason, the heap continued to increase through the various matches until during the 4th consecutive match, the heap got up to over 950 million bytes and Forge locked up in the middle of me trying to play a spell. In looking through the console that Eclipse provides, it's really looking like the Image Cache is causing the heap to grow. I don't know enough about programming to be able to tell for sure what's going on, but my gut feeling is that the Image Cache isn't being cleared. I keep seeing exceptions being thrown in the console. Here's what the console says.
Unfortunately, I've got no clue what this means, so I can't tell exactly what's wrong, but I do know what the symptoms of the malfunction are. As a user continues to use Forge, it uses more and more memory until it eventually is using more memory than is allocated for the program to run, and it locks everything up.
- Console Error Message | Open
Unfortunately, I've got no clue what this means, so I can't tell exactly what's wrong, but I do know what the symptoms of the malfunction are. As a user continues to use Forge, it uses more and more memory until it eventually is using more memory than is allocated for the program to run, and it locks everything up.
"I just woke up, haven't had coffee, let alone a pee in 7 days, and I find out you stole my ass and made a ...mini-me! Carter, I should be irked currently, yes?" - Jack O'Neill
Re: Heap space issues
by Chris H. » 04 Jul 2011, 01:12
`timmermac wrote:I was running Forge concurrently with VisualVM with the -Xms1000m -Xmx1000m arguments added into the run configuration, and I'm still having some issues. For whatever reason, the heap continued to increase through the various matches until during the 4th consecutive match, the heap got up to over 950 million bytes and Forge locked up in the middle of me trying to play a spell. In looking through the console that Eclipse provides, it's really looking like the Image Cache is causing the heap to grow. I don't know enough about programming to be able to tell for sure what's going on, but my gut feeling is that the Image Cache isn't being cleared. I keep seeing exceptions being thrown in the console. Here's what the console says.
- Console Error Message | Open
Unfortunately, I've got no clue what this means, so I can't tell exactly what's wrong, but I do know what the symptoms of the malfunction are. As a user continues to use Forge, it uses more and more memory until it eventually is using more memory than is allocated for the program to run, and it locks everything up.
Hmmm, there is an issue 134 on googlecode cardforge about a "Bogus DQT index 5" error exception. Sol seems to think that it might be caused when clicking on a corrupt card image.
Rob re-uploaded the set pics in response to notice that some of these card pics were corrupt. It may not help but you might want to consider removing the folders containing the set pics and then re-download them one more time. A time consuming experiment but if this helps to alleviate this issue then it would be worth the time invested.
Once again, good luck.
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: Heap space issues
by timmermac » 04 Jul 2011, 01:52
I'll have to try that. I don't know that it will have an effect on my heap issues, but it won't hurt to try. I've got a screenshot illustrating just what's happening to my heap space. It'll be attached. I'm only ever able to play 2 or 3 matches in a row, no matter what my heap space min/max are set to. I don't remember having this much trouble with Forge until January or February, so some time in there is when how Forge uses memory changed.
- Attachments
-
- This is what Forge did during a 3 match set.
"I just woke up, haven't had coffee, let alone a pee in 7 days, and I find out you stole my ass and made a ...mini-me! Carter, I should be irked currently, yes?" - Jack O'Neill
Re: Heap space issues
by Braids » 09 Jul 2011, 05:55
i have steadily been committing code changes to reduce the number of temporary CardList instances we use in several places. this should lower unnecessary heap allocations. it has made forge somewhat faster; it is most noticable in the deck editors when filtering by name using the Filter menu (not the text box).
i'll check my messages in about 9.5 hours to see if i broke anything serious. i was much more careful changing CardFactory this time and more thorough with my own acceptance tests.
longer term heap issues won't go away until we switch more hash fields to trees and find memory leaks like the ones timmermac experiences.
i'll check my messages in about 9.5 hours to see if i broke anything serious. i was much more careful changing CardFactory this time and more thorough with my own acceptance tests.
longer term heap issues won't go away until we switch more hash fields to trees and find memory leaks like the ones timmermac experiences.
"That is the dumbest thing I've ever seen." --Rob Cashwalker, regarding Innistrad double-sided cards. One of the first times he and I have ever agreed on something. 
-
Braids - Programmer
- Posts: 556
- Joined: 22 Jun 2011, 00:39
- Location: Unknown. Hobby: Driving myself and others to constructive madness.
- Has thanked: 1 time
- Been thanked: 1 time
Re: Heap space issues
by Braids » 15 Jul 2011, 02:33
ok, yes, pretty data. Object arrays? unexpected.jendave wrote:Snapshot of memory usage before the New Game screen even comes up.
what message are you conveying? are you trying to make a case for mocks, leaner startup . . . ? (profit?)
"That is the dumbest thing I've ever seen." --Rob Cashwalker, regarding Innistrad double-sided cards. One of the first times he and I have ever agreed on something.
-
Braids - Programmer
- Posts: 556
- Joined: 22 Jun 2011, 00:39
- Location: Unknown. Hobby: Driving myself and others to constructive madness.
- Has thanked: 1 time
- Been thanked: 1 time
Re: Heap space issues
by jendave » 15 Jul 2011, 14:56
No, not mocks or anything. The code uses arrays WAY too much. Tons of code use .toArray(). I started removing all of the Object[] and Deck[] instances, but it is a lot of work so far. Also, it is very invasive. I'll look at it more this weekend.Braids wrote:ok, yes, pretty data. Object arrays? unexpected.jendave wrote:Snapshot of memory usage before the New Game screen even comes up.
what message are you conveying? are you trying to make a case for mocks, leaner startup . . . ? (profit?)
Re: Heap space issues
by Braids » 15 Jul 2011, 17:03
please keep in mind that we have some good support for Generators, including Generators that filter or apply transforms to other Generators. this happens lazily, at iteration. i've also found that most Generators canjendave wrote: . . . The code uses arrays WAY too much. Tons of code use .toArray(). I started removing all of the Object[] and Deck[] instances, but it is a lot of work so far. Also, it is very invasive. I'll look at it more this weekend.
edit 1. be careful with YieldUtils.toIterable; i think it might leak memory if you don't finish iterating over all the elements.
edit 2. whom do i have to
"That is the dumbest thing I've ever seen." --Rob Cashwalker, regarding Innistrad double-sided cards. One of the first times he and I have ever agreed on something.
-
Braids - Programmer
- Posts: 556
- Joined: 22 Jun 2011, 00:39
- Location: Unknown. Hobby: Driving myself and others to constructive madness.
- Has thanked: 1 time
- Been thanked: 1 time
Re: Heap space issues
by Chris H. » 15 Jul 2011, 17:23
`Braids wrote:edit 2. whom do i have tosvn blamepraise for my new "Programmer" title?
I would assume that this would require a site Administrator or CCGHQ Administrator and/or possibly a Global moderator.
As a Forge Forum moderator I do not believe that I have that power.
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: Heap space issues
by friarsol » 15 Jul 2011, 17:43
I think it's based on number of posts.Chris H. wrote:`Braids wrote:edit 2. whom do i have tosvn blamepraise for my new "Programmer" title?
I would assume that this would require a site Administrator or CCGHQ Administrator and/or possibly a Global moderator.
As a Forge Forum moderator I do not believe that I have that power.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
14 posts
• Page 1 of 1
Who is online
Users browsing this forum: No registered users and 28 guests