Page 5 of 5

Re: StaticEffectFactory

PostPosted: 14 Jul 2011, 13:08
by Chris H.
Sloth wrote:Sidenote: Can we delete all enpump code now? I don't see a reason not to.
`
By all means.

There are two methods in CardFactoryUtil that are called by the enPump parsing code located in CardFactory_Auras. Might as well get it all at one time.

Re: StaticEffectFactory

PostPosted: 14 Jul 2011, 15:30
by Chris H.
I have finished the conversion of generic aura keyword to AF_Attach. The generic aura keyword is no longer needed.

If you place a System.out.println(card.getName()) in the generic aura keyword you should only get the Animate Wall card. The oracle text uses "Enchant Wall", notice the capital "W". This card now uses AF-Attach but it also passes the test for the generic aura keyword.

It should be safe to now comment out or to delete the enPump and generic aura code.

Re: StaticEffectFactory

PostPosted: 14 Jul 2011, 17:42
by Chris H.
Chris H. wrote:IIt should be safe to now comment out or to delete the enPump and generic aura code.
`
The enPump code is now commented out.

Re: StaticEffectFactory

PostPosted: 14 Jul 2011, 22:30
by Chris H.
Chris H. wrote:The enPump code is now commented out.
`
The generic aura code is also.

Re: StaticEffectFactory

PostPosted: 18 Jul 2011, 20:14
by jeffwadsworth
Does SVarCompare$ work with variables? Ex. SVarCompare$ LEX.

Re: StaticEffectFactory

PostPosted: 18 Jul 2011, 20:32
by Hellfish
Yes, it should work fine with them.