Drafting and Block/Set txt files

Posted:
09 Jul 2011, 16:54
by friarsol
I was just updating blocks and setdata when I noticed that there is an inconsistency. I don't know anything about this part of the code, so I figured I'd ask. It looks like in blocks.txt M10 and M11 are correctly referred to by their names "Magic 20XX" but in setInfo they are incorrectly referred to by "Magic The Gathering 20XX".
I remember some people were reporting weird issues where the AI wasn't selecting any land, so I thought this might correlated.
So A) does this name mean anything and B) could this be why the AI isn't grabbing land properly?
Either way we should probably fix it to be conisistent. I just didn't want to change anything, since I didn't want to break something based on the names.
Re: Drafting and Block/Set txt files

Posted:
09 Jul 2011, 20:29
by Rob Cashwalker
There shouldn't be any reason that type of inconsistency would be related to the land problem. Only the block names are used so far. But sure, go ahead and correct it.
Re: Drafting and Block/Set txt files

Posted:
10 Jul 2011, 20:26
by friarsol
Re: Drafting and Block/Set txt files

Posted:
11 Jul 2011, 03:42
by slowe
M12 booster packs don't have a file yet. I tried this too, then created M12.pack in res/boosterdata with the same contents as the M11 one.
Re: Drafting and Block/Set txt files

Posted:
11 Jul 2011, 17:27
by Chris H.
slowe wrote:M12 booster packs don't have a file yet. I tried this too, then created M12.pack in res/boosterdata with the same contents as the M11 one.
`
M10.pack and the M11.pack files are identical.
Commons:10
Uncommons:3
Rares:1
Mythics:1
`
I would assume that M12 will use the same numbers?
Re: Drafting and Block/Set txt files

Posted:
11 Jul 2011, 17:32
by friarsol
Yep all new sets are that. It might be worth it to have a "default" if the specific set doesn't exist to just use this.
Re: Drafting and Block/Set txt files

Posted:
11 Jul 2011, 18:06
by Chris H.
slowe wrote:M12 booster packs don't have a file yet. I tried this too, then created M12.pack in res/boosterdata with the same contents as the M11 one.
`
Thank you slowe, your fix is now on the SVN.
Re: Drafting and Block/Set txt files

Posted:
11 Jul 2011, 19:58
by Rob Cashwalker
friarsol wrote:Yep all new sets are that. It might be worth it to have a "default" if the specific set doesn't exist to just use this.
It's the default for the default constructor... aka "Full". But yes, I see where it would be helpful to have a default if the pack file isn't found.