Also, I ran into some issues with r29415: since there are hundreds of thousands of net decks now available for Forge it can be a bit of a pain for an ordinary user (who does not know how to make some kind of a batch script to automate the process) to fix the decks in a way such that they contain those new accented symbols. Is it possible, in any way, to make the game detect these card names both ways when loading decks (special character or not), showing pictures, and asking the user to type card names?. Kind of like making those symbols equivalent to their non-accented counterparts.
EDIT: I tried to implement this in r29417, but my implementation may not be efficient (it depends on how often reIndex needs to be actually called... I know it's called when the cards are read from disk and CardDb is initially compiled but it looks like it may also be called under some other circumstances, please take a look at the code...).P.S. I'm also not sure how to type those symbols, so if, let's say, I want to find
Deja Vu by typing its name in the card search dialog box, this complicates my search experience (I can only type "D" and then I have to manually scroll down because the accented "e" is not detected if I type a simple "e").
P.P.S. Another issue with it is that it doesn't show correct pictures for those cards anymore (because CCGHQ card packs have unaccented names for these cards).
EDIT: Looks like I fixed this one in r29416 by changing the file encoding.P.P.P.S. And one more issue, this time with the dev environment: I can't open ImageUtil.java in NetBeans now, it says "this file can't be safely opened with the UTF-8 encoding", and if I proceed it opens it but it shows all those accented symbols as question marks... Is the source file really saved in UTF-8? :/ Also, when compiling Forge I get a lot of warnings, I think these warnings hint that the relevant code is actually not being treated properly when the game is compiled -
EDIT: Looks like I fixed this one in r29416 by changing the file encoding.- Code: Select all
Compiling 115 source files to /home/agetian/NetBeansProjects/trunk/forge-core/target/classes
forge/util/ImageUtil.java:[110,48] unmappable character for encoding UTF-8
.......
P.P.P.P.S. After reading ImageUtil.java in Vim and checking its file encoding I see that it's set to "latin-1" instead of to "UTF-8"... Something's wrong with that for sure, I think... -
EDIT: Looks like I fixed this one in r29416 by changing the file encoding.- Agetian