It is currently 04 Mar 2021, 01:07
   
Text Size

Developing Bugs

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, friarsol, Blacksmith, KrazyTheFox, Agetian, CCGHQ Admins

Re: Developing Bugs

Postby ArsenalNut » 22 Sep 2011, 13:17

Some recent change has broken CardUtil.getThisTurnEntered. I tried a new Morbid card and it didn't work. Then I tried one that worked before and it didn't work either.
So many cards, so little time
User avatar
ArsenalNut
 
Posts: 509
Joined: 08 Jul 2011, 03:49
Has thanked: 27 times
Been thanked: 121 times

Re: Developing Bugs

Postby Hellfish » 22 Sep 2011, 14:05

I'm guessing somewhere around r10528. I'll take a look and see if I can figure it out.

EDIT:Figured it out, the error may have been present earlier. Comparing a string and an Enum using .equals() is not the way to go.
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
User avatar
Hellfish
Programmer
 
Posts: 1297
Joined: 07 Jun 2009, 10:41
Location: South of the Pumphouse
Has thanked: 110 times
Been thanked: 169 times

Re: Developing Bugs

Postby ArsenalNut » 26 Sep 2011, 05:38

While digging through the ManaPool code for issue #83 & #306, I found there is no reference in the rest of Forge to "removeManaFromFloating". This method is also the only caller of "removeManaFrom(final ArrayList<Mana> pool, final ManaCost mc, Card c)". As far as I can tell, these methods have been around since the change over from Git back to Subversion. Is there an etiquette for unused methods like these? Is it alright if I blow them away?
So many cards, so little time
User avatar
ArsenalNut
 
Posts: 509
Joined: 08 Jul 2011, 03:49
Has thanked: 27 times
Been thanked: 121 times

Re: Developing Bugs

Postby friarsol » 26 Sep 2011, 13:12

I probably added those originally because I was planning on changing around how the ManaPool worked, but may not have actually changed it. If they don't seem useful in the future feel free to remove them.
friarsol
Global Moderator
 
Posts: 7565
Joined: 15 May 2010, 04:20
Has thanked: 242 times
Been thanked: 953 times

Re: Developing Bugs

Postby friarsol » 21 Oct 2011, 03:12

Edit: Nevermind. I hate Eclipse.
friarsol
Global Moderator
 
Posts: 7565
Joined: 15 May 2010, 04:20
Has thanked: 242 times
Been thanked: 953 times

Re: Developing Bugs

Postby friarsol » 17 Dec 2011, 22:51

Since cardforge is still down I'm going to post this here.

It looks like the AI is targeting himself with Keldon Marauders for both of it's triggers. Not sure what might have changed in these files, and I have no idea how long it has been like that.
friarsol
Global Moderator
 
Posts: 7565
Joined: 15 May 2010, 04:20
Has thanked: 242 times
Been thanked: 953 times

Re: Developing Bugs

Postby Sloth » 18 Dec 2011, 08:46

friarsol wrote:It looks like the AI is targeting himself with Keldon Marauders for both of it's triggers. Not sure what might have changed in these files, and I have no idea how long it has been like that.
Fixed! Thanks Sol.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Developing Bugs

Postby friarsol » 19 Dec 2011, 04:13

I don't have a chance to look into this, but I got this crash when I tried to Suspend Festering March

java.lang.NullPointerException
at forge.card.trigger.TriggerSpellAbilityCast.performTest(TriggerSpellAbilityCast.java:101)
at forge.card.trigger.TriggerHandler.runSingleTrigger(TriggerHandler.java:417)
at forge.card.trigger.TriggerHandler.runTrigger(TriggerHandler.java:340)
at forge.MagicStack.add(MagicStack.java:683)
at forge.gui.input.InputPayManaCost.done(InputPayManaCost.java:229)
friarsol
Global Moderator
 
Posts: 7565
Joined: 15 May 2010, 04:20
Has thanked: 242 times
Been thanked: 953 times

Re: Developing Bugs

Postby Sloth » 19 Dec 2011, 09:38

friarsol wrote:I don't have a chance to look into this, but I got this crash when I tried to Suspend Festering March

java.lang.NullPointerException
at forge.card.trigger.TriggerSpellAbilityCast.performTest(TriggerSpellAbilityCast.java:101)
at forge.card.trigger.TriggerHandler.runSingleTrigger(TriggerHandler.java:417)
at forge.card.trigger.TriggerHandler.runTrigger(TriggerHandler.java:340)
at forge.MagicStack.add(MagicStack.java:683)
at forge.gui.input.InputPayManaCost.done(InputPayManaCost.java:229)
Fixed! Thanks Sol!
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Developing Bugs

Postby Doublestrike » 14 Jan 2012, 07:40

On my Windows x64 box I've got this red exclamation point over my whole project (see pic) in Eclipse. And of course, it won't compile.

I've tried checking the build path, tried updating Maven dependencies (with force), and even removed and checked out the whole project again from the SVN - no dice. I've tried a few google searches too. :?

Has anyone seen this or fixed it in the past? I'm running Windows x64 with Tortoise SVN and Eclipse IDE. Tortoise reports everything is OK (see pic).

[EDIT - Eclipse reports no other problems throughout the file structure :( ]
Attachments
dir.png
Root directory
unresolved build.png
Build error
unresolved build.png (10.58 KiB) Viewed 2721 times
---
A joke is a very serious thing.
User avatar
Doublestrike
UI Programmer
 
Posts: 715
Joined: 08 Aug 2011, 09:07
Location: Bali
Has thanked: 183 times
Been thanked: 161 times

Re: Developing Bugs

Postby Chris H. » 14 Jan 2012, 12:10

Doublestrike wrote:On my Windows x64 box I've got this red exclamation point over my whole project (see pic) in Eclipse. And of course, it won't compile.

I've tried checking the build path, tried updating Maven dependencies (with force), and even removed and checked out the whole project again from the SVN - no dice. I've tried a few google searches too. :?

Has anyone seen this or fixed it in the past? I'm running Windows x64 with Tortoise SVN and Eclipse IDE. Tortoise reports everything is OK (see pic).

[EDIT - Eclipse reports no other problems throughout the file structure :( ]
`
I was able to update to rev 13142 this morning and the project built and ran.

Have you tried a

Maven -> Update Project Configuration...
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: Developing Bugs

Postby silly freak » 14 Jan 2012, 18:18

look into the Problems tab. it means that there is a project error, not a code error. e.g. a jar file is missing, artifact not resolved etc.
___

where's the "trust me, that will work!" switch for the compiler?
Laterna Magica - blog, forum, project, 2010/09/06 release!
silly freak
DEVELOPER
 
Posts: 598
Joined: 26 Mar 2009, 07:18
Location: Vienna, Austria
Has thanked: 93 times
Been thanked: 25 times

Re: Developing Bugs

Postby Doublestrike » 16 Jan 2012, 01:01

Thanks fellas, the "Problems" tab led me in the right direction, and what actually solved the problem was selecting the "Offline" checkbox in the "update configuration", which I hadn't been doing before. Don't know why that worked but it did, so I'm off and running.
---
A joke is a very serious thing.
User avatar
Doublestrike
UI Programmer
 
Posts: 715
Joined: 08 Aug 2011, 09:07
Location: Bali
Has thanked: 183 times
Been thanked: 161 times

Re: Developing Bugs

Postby silly freak » 16 Jan 2012, 09:31

one thing I have now and then with maven is corrupt artifacts in the local repository. so, if maven/eclipse suggests that an artifact is missing or something, but you're sure it shouldn't be, what I do is to go into ~/.m2/repository/org/groupId/artifactId/1.0.0 and check the files. if they're not alright, just delete the 1.0.0 directory so that it's re-downloaded. i've found that "force update of releases/snapshots" doesn't work in some cases; manual deleting does.
___

where's the "trust me, that will work!" switch for the compiler?
Laterna Magica - blog, forum, project, 2010/09/06 release!
silly freak
DEVELOPER
 
Posts: 598
Joined: 26 Mar 2009, 07:18
Location: Vienna, Austria
Has thanked: 93 times
Been thanked: 25 times

Re: Developing Bugs

Postby Doublestrike » 16 Jan 2012, 10:45

Funny that you mention that, I did notice that the fresh SVN copy would be OK, then I'd open Eclipse, which would be fine for a few moments, then it would turn evil on me.

It looked like Eclipse was changing the file, but I thought no, couldn't be that, right, I can trust the IDE not to screw with source files?!!! :lol:

We really need a "doggone Eclipse" smiley...
---
A joke is a very serious thing.
User avatar
Doublestrike
UI Programmer
 
Posts: 715
Joined: 08 Aug 2011, 09:07
Location: Bali
Has thanked: 183 times
Been thanked: 161 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 13 guests


Who is online

In total there are 13 users online :: 0 registered, 0 hidden and 13 guests (based on users active over the past 10 minutes)
Most users ever online was 1371 on 09 Feb 2020, 16:22

Users browsing this forum: No registered users and 13 guests

Login Form