r9779 Discussion
Post MTG Forge Related Programming Questions Here
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
3 posts
• Page 1 of 1
r9779 Discussion
by Braids » 14 Aug 2011, 21:03
Rev 9779, 2011-08-14 20:22:10
Author: Max mtg
Log message:
Quest Cardshop: after selling a card the picture at the right is being updated properly
i noticed src/main/java/forge/CardShopTableModel.java line 296 and src/main/java/forge/TableModel.java line 341 contain TODO comments. Max, are these methods complete? if they are, the TODO comments are misleading. can you either clarify what needs to be done in these comments or just remove them?
Author: Max mtg
Log message:
Quest Cardshop: after selling a card the picture at the right is being updated properly
i noticed src/main/java/forge/CardShopTableModel.java line 296 and src/main/java/forge/TableModel.java line 341 contain TODO comments. Max, are these methods complete? if they are, the TODO comments are misleading. can you either clarify what needs to be done in these comments or just remove them?
"That is the dumbest thing I've ever seen." --Rob Cashwalker, regarding Innistrad double-sided cards. One of the first times he and I have ever agreed on something. 

-
Braids - Programmer
- Posts: 556
- Joined: 22 Jun 2011, 00:39
- Location: Unknown. Hobby: Driving myself and others to constructive madness.
- Has thanked: 1 time
- Been thanked: 1 time
Re: r9779 Discussion
by Max mtg » 14 Aug 2011, 22:16
The methods complete the work they were desined to do.
I'll remove these comments soon. (done at 9783)
I'll remove these comments soon. (done at 9783)
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: r9779 Discussion
by Braids » 14 Aug 2011, 22:46
Max mtg wrote:The methods complete the work they were desined to do.
I'll remove these comments soon. (done at 9783)


"That is the dumbest thing I've ever seen." --Rob Cashwalker, regarding Innistrad double-sided cards. One of the first times he and I have ever agreed on something. 

-
Braids - Programmer
- Posts: 556
- Joined: 22 Jun 2011, 00:39
- Location: Unknown. Hobby: Driving myself and others to constructive madness.
- Has thanked: 1 time
- Been thanked: 1 time
3 posts
• Page 1 of 1
Who is online
Users browsing this forum: No registered users and 77 guests