Page 4 of 4

Re: MVC

PostPosted: 28 Aug 2011, 01:59
by Braids
@Doublestrike, i'm not real keen on MVC. if the model is an object in memory (instead of a database), then separating its behavior and its data storage breaks object orientation encapsulation. some people want to do that, and maybe they can do so elegantly, but i haven't quite accepted the idea. so, i put a much stronger emphasis on separating Model and View, putting what you might consider the Controller into the methods of the Model.

thanks for being so pliable. i wasn't looking forward to rewriting that code myself. #-o

Re: Aug 2011 GUI Overhaul

PostPosted: 28 Aug 2011, 02:03
by Doublestrike
Oh OK then I'll just do MV (hopefully). I'm a PHP/Javascript developer so it's nice to have someone to show me the ropes in Java. Although I may take a little while to catch on, I'll get there eventually. Back to work.

Re: Aug 2011 GUI Overhaul

PostPosted: 29 Aug 2011, 16:51
by Braids
Doublestrike wrote:Oh OK then I'll just do MV (hopefully). I'm a PHP/Javascript developer so it's nice to have someone to show me the ropes in Java. Although I may take a little while to catch on, I'll get there eventually. Back to work.
i've burned out, so you'll need to find someone else to help you. oh, and don't worry about CheckStyle, FindBugs, and PMD. i was under the wrong impression about the importance of those tools.

Re: Aug 2011 GUI Overhaul

PostPosted: 29 Aug 2011, 16:59
by jendave
Getting these errors during the compile. I do not see SplashViewProgressMonitor.java in the source tree.

Code: Select all
[ERROR] /Users/dhudson/mtg/forge/src/main/java/forge/view/swing/SplashFrame.java:[85,26] cannot find symbol
[ERROR] symbol  : class SplashViewProgressMonitor
[ERROR] location: class forge.view.swing.SplashFrame

Re: Aug 2011 GUI Overhaul

PostPosted: 30 Aug 2011, 15:10
by Doublestrike
Those must have been the errors @Sloth PMd me about (haven't heard back whether problem was resolved or not). Those files were renamed to SplashProgressModel and SplashProgressComponent and moved to forge.view.swing in r10070 (http://svn.slightlymagic.net/websvn/lis ... &rev=10070).

The code runs fine on my machine...the fault is probably mine but not sure what I did wrong - will fix it in the future if the error becomes apparent.

I just ran an "update to HEAD" to r10090 and it's still working.

Edit Apparently everything's OK now.