//TODO: It would be handy if the list of any sets can be cho

[Max mtg]

forge\quest\data\QuestBoosterPack.java lines 84-87 contain a nice devs' chat. Let's move it here.

r9834:

Code: Select all

            //TODO: It would be handy if the list of any sets can be chosen
            // ... Huh?
            // TODO: Braids: "It would also be handy if comments were written
            // in clear English."

r9840:

Code: Select all

            //TODO: It would be handy if the list of any sets can be chosen
            // Can someone clarify that? I don't understand it. -Braids

I don't know the original text's author intentions, but let me make a guess what those comments meant:
"We want to implement more options for customizing the starting cardpool, but cannot do it for now - so here is a place to insert the code that would do the thing - please someone, do this for the win"

If author of that initial comment (blame indicates jendave r9708 as author) comes here and expresses his opinion - that would be nice too.

[Chris H.]

The TODO is a little cryptic but I think that you have the right idea. We now have the ability to choose a T2 starting pool. It would be interesting and fun to also have the booster packs limited to T2.

And we have the selector in the constructed mode deck editor that selects by sets. A similar set up for quest mode is worth consideration.

Someone suggested that choosing a set for the starting pool + booster packs should cost us some credits at the start of a quest for play balancing issues.

Someone also suggested that we could have a few theme type choices to choose from at the start of a quest. I suspect that this would require more work. Play balancing issues might have this option costing more initial credits than set limits.

[Rob Cashwalker]

Before the git transition, I had begun revisions to limit the cardshop and prize cards to Type 2. Not sure where I stashed that code, but I'm still knee-deep in the new GUI.

[friarsol]

I had written the original comment because I was playing in that area to limit the sets for the starting pool (specifically I wanted Rath Cycle + Urza's Block). When I committed, I switched it to be all Sets in Standard and thought it would be handy if the list of (pool limiting) sets could be chosen (by the player when the quest starts). Rob had talked about limiting the whole quest and had some work done in the area, so I never came back to cleanup any of what I started in the area.

I had suggested both of the things that Chris is referring to along with plenty of other possibilities for Quest mode. We can revisit them at a later time once Questing is more customizable.

[Braids]

forge\quest\data\QuestBoosterPack.java lines 84-87 contain a nice devs' chat. Let's move it here.

r9834:
[code] //TODO: It would be handy if the list of any sets can be chosen
// ... Huh?
// TODO: Braids: "It would also be handy . . .

not one of my shining moments. i was rude, someone pointed it out, and i finally fixed it.

If author of that initial comment (blame indicates jendave r9708 as author) comes here and expresses his opinion - that would be nice too.

Dave {jendave} is incorrectly listed as the author for a lot of code at this point. i believe he did most of the work for moving the repositories from Git back to our current SVN server. somewhere in this process, we lost some history, so it looks like jendave did everything prior to 9733.

edit: is someone going to write some feature request(s) in Mantis for all this? i'm not volunteering, because i still don't completely understand.