Page 5 of 5

Re: Issue 157: which classes do we need?

PostPosted: 29 Aug 2011, 16:20
by jendave
Rob Cashwalker wrote:FYI, the SlightlyMagic SVN is going quite fast. I recall with GoogleCode, updating all 5000+ cards took an hour due to the stream crapping out every few hundred cards. It just did 8829 updates in about 6 minutes.
I agree. While Git was faster, the slightlymagic SVN speed is vastly better than Google's

Re: Issue 157: which classes do we need?

PostPosted: 29 Aug 2011, 16:44
by Braids
Max mtg wrote:
Braids wrote:i'm doing ok with svn. i'm having to do the update one letter folder at a time from the command line. i am very glad i was able to split the cardsfolder up alphabetically several weeks ago.

@Max mtg, i've added two boolean fields to CardRules: removedFromAIDecks and removedFromRandomDecks. i added them to the ctor and added two 'is' accessors for them. these values are important for being able to generate random decks for both the player and the AI, and also for AI drafting.
I strongly support the decision of splitting the cardsfolder - now the directories open faster and the needed card is faster to located. Despite of the update of all over 9000 files took me about a minute

You've done it right. These fields are definitelly necesary once we switch completely to generators based on lighweight classes.
well, i have burned out. my latest commit is rev 10061. it contains forge.card.CardRulesReader which does a lot of the parsing, but the higher level code has been commented out.

i have unassigned all issues from myself. i'm not sure when i'll be back.

edit: oh, and there is javadoc in the files i checked in. i was still under the illusion that documentation was important in this project.

Re: Issue 157: which classes do we need?

PostPosted: 29 Aug 2011, 17:49
by Max mtg
Braids wrote:well, i have burned out. my latest commit is rev 10061. it contains forge.card.CardRulesReader which does a lot of the parsing, but the higher level code has been commented out.

i have unassigned all issues from myself. i'm not sure when i'll be back.

edit: oh, and there is javadoc in the files i checked in. i was still under the illusion that documentation was important in this project.
But why? What happened to you? Is that about javadocs?

Re: Issue 157: which classes do we need?

PostPosted: 29 Aug 2011, 18:37
by Sloth
Braids wrote:well, i have burned out. my latest commit is rev 10061. it contains forge.card.CardRulesReader which does a lot of the parsing, but the higher level code has been commented out.

i have unassigned all issues from myself. i'm not sure when i'll be back.

edit: oh, and there is javadoc in the files i checked in. i was still under the illusion that documentation was important in this project.
I hope you will be back. A lot of important topics that haven't been touched for years have been discussed very lively because of you. [-o<

Re: Issue 157: which classes do we need?

PostPosted: 29 Aug 2011, 22:40
by slowe
Sloth wrote:
Braids wrote:well, i have burned out. my latest commit is rev 10061. it contains forge.card.CardRulesReader which does a lot of the parsing, but the higher level code has been commented out.

i have unassigned all issues from myself. i'm not sure when i'll be back.

edit: oh, and there is javadoc in the files i checked in. i was still under the illusion that documentation was important in this project.
I hope you will be back. A lot of important topics that haven't been touched for years have been discussed very lively because of you. [-o<
Take care, Braids. I may not post often, but I lurk about, and I hate to see someone so involved in Forge's progress leave. Hope you feel refreshed soon; we'll always be glad to see you back!

Re: Issue 157: which classes do we need?

PostPosted: 30 Aug 2011, 23:09
by Max mtg
CardReader is complete. Thanks to Braids, who has made a first and very important step in its development.
Feel free to use CardDb class - from now it contains all cards printed, among those, known by Forge of course. Mtg-data.txt is no longer unsed (but keep parsers' sources please, they might become useful)

Decks, DeckEdtitors (incl cardshop and boosterdraft), the drafting itself and QuestModel updates will follow in some time.