Collectible Card Game Headquarters

LazyCardFactory sometimes is asked for cards it cannot load.
Why is default factory's behaviour to throw?

Maybe it should return null, and let the invoking code decide that to do about that?

What cards could it possibly not be able to load? Your mtg-data cards?

Rob Cashwalker wrote:What cards could it possibly not be able to load? Your mtg-data cards?

Why just my mtg-data cards?
Imagine you downloaded a deck, forge wants to check if all cards are supported. LazyCardFactory does not know which cards are, and can not check by searching in precached ones.

But this is unrelated to my original question abouth throwing exceptions

Max mtg wrote:

Rob Cashwalker wrote:What cards could it possibly not be able to load? Your mtg-data cards?

Why just my mtg-data cards?
Imagine you downloaded a deck, forge wants to check if all cards are supported. LazyCardFactory does not know which cards are, and can not check by searching in precached ones.

But this is unrelated to my original question abouth throwing exceptions

my current thinking is to throw a new checked exception, so the UI could figure out how to tell the user. the checked exception forces the caller to deal with the problem. but returning null just means we'll get NullPointerExceptions when we don't expect them.

see also issue 29 {Handle getCard() invalid card name more gracefully}