Page 1 of 1

r10057 has broken the build (

PostPosted: 29 Aug 2011, 18:03
by Max mtg
Unfortunatelly, Braids has not commited the moved classes

http://svn.slightlymagic.net/websvn/lis ... &rev=10057
Code: Select all
- Splash view/model renamed, moved to forge.view.swing folder
- Small fix to decouple interface from implementation
- Add dispatch thread test
- Updated javadoc
So I guess, until Braids commits the missing files, for that time being we should restore the old version from SVN to make the build working again
    /trunk/src/main/java/net/slightlymagic/braids/util/progress_monitor/SplashModelProgressMonitor.java
    /trunk/src/main/java/net/slightlymagic/braids/util/progress_monitor/SplashViewProgressMonitor.java

Re: r10057 has broken the build (

PostPosted: 29 Aug 2011, 18:53
by jendave
Fixed

Re: r10057 has broken the build (

PostPosted: 29 Aug 2011, 19:24
by Sloth
jendave wrote:Fixed
There's still something messed up.

EDIT: I think I fixed.

Re: r10057 has broken the build (

PostPosted: 29 Aug 2011, 19:45
by Max mtg
jandave, sloth, thanks a lot!

Re: r10057 has broken the build (

PostPosted: 30 Aug 2011, 16:19
by Doublestrike
Just finally found and read this post (ouch).

General apologies all around. :oops:

Could someone tell me why this happened (or how to prevent)? To my understanding (which generally follows the explanation at viewtopic.php?f=52&t=1093&start=105#p68947) I get things working on my machine, update to the head, then commit. When anyone opens up their dev environment, they update to the latest revision, and off they go. I must be missing something...?

Re: r10057 has broken the build (

PostPosted: 30 Aug 2011, 16:57
by Sloth
Doublestrike wrote:Just finally found and read this post (ouch).

General apologies all around. :oops:

Could someone tell me why this happened (or how to prevent)? To my understanding (which generally follows the explanation at viewtopic.php?f=52&t=1093&start=105#p68947) I get things working on my machine, update to the head, then commit. When anyone opens up their dev environment, they update to the latest revision, and off they go. I must be missing something...?
I think you forgot to submit new (or newly named) classes in commit 10057. This happened to me all the time. The program I use (TortoiseSVN) won't check unversioned files by default only chnaged ones.