Page 1 of 1

There will be another massive change

PostPosted: 06 Sep 2011, 15:22
by Max mtg
I'm changing the String[] GameType field to an enumeration type.
Will update all affected files, expect a big commit.
As a dependency deckType will be switched to that enumeration type too.
DeckManager may also be object of changes (because for now it loads all the deck into memory on start and then - on closing deckeditor for instance - it DELETES all the decks on disk and writes them again - this should not happen) according to issue 87

BTW, when are we going to release 1.1.3? (so that I would refrain from making big changes before a milestone release)

Also, if anyone would have troubles with that transition, ask me - I'll help you.

Re: There will be another massive change

PostPosted: 07 Sep 2011, 04:10
by Rob Cashwalker
In my local copy for the new gui, I added "Quest" as a game type in Constants.GameTypes. Constants.Runtime.GameType should stay as a string, I think?

Re: There will be another massive change

PostPosted: 07 Sep 2011, 07:52
by Max mtg
Rob Cashwalker wrote:In my local copy for the new guWhyi, I added "Quest" as a game type in Constants.GameTypes. Constants.Runtime.GameType should stay as a string, I think?
why not enumeration? I have also added quest type there
string can be assigned any crap unlike enum

Re: There will be another massive change

PostPosted: 09 Sep 2011, 11:15
by Max mtg
Just commited the change.
This allowed me to untie deck editors from global variable AllZone().Constants.GameType

Hope, you'll be fine with those too

Re: There will be another massive change

PostPosted: 09 Sep 2011, 16:00
by Rob Cashwalker
So where is it now?

Re: There will be another massive change

PostPosted: 09 Sep 2011, 17:55
by Max mtg
Rob Cashwalker wrote:So where is it now?
Maybe it's not that massive, but it is in SVN already.

check out Constant.Runtime.gameType
moreover I think this piece of data with some extra effort can be moved into a local variable.

Re: There will be another massive change

PostPosted: 09 Sep 2011, 18:28
by Max mtg
@10335 fixed an exception in Quest Load from old saves