Collectible Card Game Headquarters

The past three times in the past week that I have downloaded LQ set pics there have been approximately 320 pics to download each time. This includes what looks like to be a lot of basic lands (see below for part of the list). Are these really changing every day or is there something else triggering them to download every time?

| Open

USG/Forest4.full.jpg http://cardforge.org/fpics/US/Rm9yZXN0NC5mdWxsLmpwZw
TMP/Forest4.full.jpg http://cardforge.org/fpics/TE/Rm9yZXN0NC5mdWxsLmpwZw
ZEN/Forest4.full.jpg http://cardforge.org/fpics/ZEN/Rm9yZXN0NC5mdWxsLmpwZw
4ED/Forest3.full.jpg http://cardforge.org/fpics/4E/Rm9yZXN0My5mdWxsLmpwZw
3ED/Forest3.full.jpg http://cardforge.org/fpics/R/Rm9yZXN0My5mdWxsLmpwZw
SOM/Forest4.full.jpg http://cardforge.org/fpics/SOM/Rm9yZXN0NC5mdWxsLmpwZw
COM/Forest4.full.jpg http://cardforge.org/fpics/COM/Rm9yZXN0NC5mdWxsLmpwZw
TSP/Forest4.full.jpg http://cardforge.org/fpics/TSP/Rm9yZXN0NC5mdWxsLmpwZw
ODY/Forest4.full.jpg http://cardforge.org/fpics/OD/Rm9yZXN0NC5mdWxsLmpwZw
MIR/Forest4.full.jpg http://cardforge.org/fpics/MI/Rm9yZXN0NC5mdWxsLmpwZw
PTK/Forest3.full.jpg http://cardforge.org/fpics/P3/Rm9yZXN0My5mdWxsLmpwZw
7ED/Forest4.full.jpg http://cardforge.org/fpics/7E/Rm9yZXN0NC5mdWxsLmpwZw
POR/Forest4.full.jpg http://cardforge.org/fpics/PT/Rm9yZXN0NC5mdWxsLmpwZw
ROE/Forest4.full.jpg http://cardforge.org/fpics/ROE/Rm9yZXN0NC5mdWxsLmpwZw
10E/Forest4.full.jpg http://cardforge.org/fpics/10E/Rm9yZXN0NC5mdWxsLmpwZw
RAV/Forest4.full.jpg http://cardforge.org/fpics/RAV/Rm9yZXN0NC5mdWxsLmpwZw
6ED/Forest4.full.jpg http://cardforge.org/fpics/6E/Rm9yZXN0NC5mdWxsLmpwZw
5ED/Forest4.full.jpg http://cardforge.org/fpics/5E/Rm9yZXN0NC5mdWxsLmpwZw
ONS/Forest4.full.jpg http://cardforge.org/fpics/ON/Rm9yZXN0NC5mdWxsLmpwZw
S99/Forest4.full.jpg http://cardforge.org/fpics/ST/Rm9yZXN0NC5mdWxsLmpwZw
MBS/Forest2.full.jpg http://cardforge.org/fpics/MBS/Rm9yZXN0Mi5mdWxsLmpwZw
8ED/Forest4.full.jpg http://cardforge.org/fpics/8E/Rm9yZXN0NC5mdWxsLmpwZw
CHK/Forest4.full.jpg http://cardforge.org/fpics/CHK/Rm9yZXN0NC5mdWxsLmpwZw
PO2/Forest3.full.jpg http://cardforge.org/fpics/P2/Rm9yZXN0My5mdWxsLmpwZw
9ED/Forest4.full.jpg http://cardforge.org/fpics/9E/Rm9yZXN0NC5mdWxsLmpwZw
ICE/Forest3.full.jpg http://cardforge.org/fpics/IA/Rm9yZXN0My5mdWxsLmpwZw
MRD/Forest4.full.jpg http://cardforge.org/fpics/MR/Rm9yZXN0NC5mdWxsLmpwZw
SHM/Forest4.full.jpg http://cardforge.org/fpics/SHM/Rm9yZXN0NC5mdWxsLmpwZw
LEA/Forest2.full.jpg http://cardforge.org/fpics/A/Rm9yZXN0Mi5mdWxsLmpwZw
LEB/Forest3.full.jpg http://cardforge.org/fpics/B/Rm9yZXN0My5mdWxsLmpwZw
INV/Forest4.full.jpg http://cardforge.org/fpics/IN/Rm9yZXN0NC5mdWxsLmpwZw
NPH/Forest2.full.jpg http://cardforge.org/fpics/NPH/Rm9yZXN0Mi5mdWxsLmpwZw
MMQ/Forest4.full.jpg http://cardforge.org/fpics/MM/Rm9yZXN0NC5mdWxsLmpwZw
ALA/Forest4.full.jpg http://cardforge.org/fpics/ALA/Rm9yZXN0NC5mdWxsLmpwZw
M11/Forest4.full.jpg http://cardforge.org/fpics/M11/Rm9yZXN0NC5mdWxsLmpwZw
M10/Forest4.full.jpg http://cardforge.org/fpics/M10/Rm9yZXN0NC5mdWxsLmpwZw
M12/Forest4.full.jpg http://cardforge.org/fpics/M12/Rm9yZXN0NC5mdWxsLmpwZw
LRW/Forest4.full.jpg http://cardforge.org/fpics/LRW/Rm9yZXN0NC5mdWxsLmpwZw
2ED/Forest3.full.jpg http://cardforge.org/fpics/U/Rm9yZXN0My5mdWxsLmpwZw

I can confirm this. All cards with multiple pictures in a set are not recognized as already downloaded.

Hmm... I have to handle this

Max, what have you done to my baby?

Rob Cashwalker wrote:Max, what have you done to my baby?

Your baby will be fine

done in 10422

Good job. Probably should look for other instances where CardFactory needs to be replaced by CardDB.

Rob Cashwalker wrote:Good job. Probably should look for other instances where CardFactory needs to be replaced by CardDB.

Thanks.
I would love to replace iteration over CardFactory to iteration over CardDb, however I haven't succeeded to remove all ocurrencies.

Imagine, we remove "implements iterable<card>" from cardfactory. Then the following errors would occur:

Code: Select all

Description   Resource   Path   Location   Type
The local variable in may not have been initialized   CardFactoryUtilTest.java   /Forge-stable/src/test/java/forge/card/cardFactory   line 34   Java Problem
The method filter(Iterable<Card>, CardListFilter) in the type CardFilter is not applicable for the arguments (CardFactoryInterface, new CardListFilter(){})   Generate2ColorDeck.java   /Forge-stable/src/main/java/forge/deck/generate   line 94   Java Problem
The method filter(Iterable<Card>, CardListFilter) in the type CardFilter is not applicable for the arguments (CardFactoryInterface, new CardListFilter(){})   Generate3ColorDeck.java   /Forge-stable/src/main/java/forge/deck/generate   line 103   Java Problem
The method filter(Iterable<Card>, CardListFilter) in the type CardFilter is not applicable for the arguments (CardFactoryInterface, new CardListFilter(){})   Generate5ColorDeck.java   /Forge-stable/src/main/java/forge/deck/generate   line 111   Java Problem
The method filterBadCards(Iterable<Card>, int) in the type GenerateConstructedMultiColorDeck is not applicable for the arguments (CardFactoryInterface, int)   GenerateConstructedMultiColorDeck.java   /Forge-stable/src/main/java/forge/deck/generate   line 226   Java Problem
The method filterBadCards(Iterable<Card>) in the type GenerateConstructedDeck is not applicable for the arguments (CardFactoryInterface)   GenerateConstructedDeck.java   /Forge-stable/src/main/java/forge/deck/generate   line 101   Java Problem


They need some time to analyze if in these cases CardFactory can be replaced by CardDb or not.

Those Deck Generators are fine to be switched, they just filter by color and type mostly.