Buffers have not been created

Posted:
13 Sep 2011, 04:09
by friarsol
I just went through Mantis and closed 5-6 Duplicate bugs to Issue 186.
http://cardforge.org/bugz/view.php?id=186Does anyone have any clue what this is about? It seems pretty prevalent and is occurring at the end of game/matches. And generally in Quest mode.
Max, maybe this has something to do with some of your changes?
Re: Buffers have not been created

Posted:
13 Sep 2011, 07:46
by PhoenixAvenger
Not sure if this is the right place for this kind of bug report, but I'll report my findings since it seems pertinent to the topic.
This "buffers have not been created" error occurs at the end of any game that is within a match, be it a win, loss, or draw, but does not show up when exiting a match or starting a new match from the main screen or quest screen. It is not a fatal error, though - I can just click "close" on the bug report window and proceed with the next game as normal, and no residue from the previous game appears to affect the new game. This happens every time, though, so it is an annoyance, but nothing more than that.
Occasionally, at the very end of a match, duplicate win/loss prompts occur, but I can't reproduce this with any regularity and it may well have been just recently fixed in SVN anyway.
Before this occurs, though, the main window does not close before the results screen goes up, and any simultaneous triggers on the stack once the game in question is decided still have to be clicked through before proceeding. Something tells me this has something to do with a request to see the game state before ending a game or something of that nature.
In short, it's just an annoyance that probably stems from some game state step not being in the right order at the game conclusion prompt. It would probably be prudent to poke around Gui_WinLose or whatever it's called now - the code has changed so much lately, and I can't follow it as easily as I once could, so I don't know where else to look if that doesn't lead anywhere.
EDIT: Max may have fixed this in r10394/r10410 - you might want to test this to make sure. (Relevant files would probably be GameAction and Gui_WinLose.)
Re: Buffers have not been created

Posted:
13 Sep 2011, 12:46
by Max mtg
PhoenixAvenger wrote:Occasionally, at the very end of a match, duplicate win/loss prompts occur, but I can't reproduce this with any regularity and it may well have been just recently fixed in SVN anyway.
Before this occurs, though, the main window does not close before the results screen goes up, and any simultaneous triggers on the stack once the game in question is decided still have to be clicked through before proceeding. Something tells me this has something to do with a request to see the game state before ending a game or something of that nature.
EDIT: Max may have fixed this in r10394/r10410 - you might want to test this to make sure. (Relevant files would probably be GameAction and Gui_WinLose.)
I have fixed the multiple winloss appearance two days ago in 10394.
Unfortunatelly this bug is present in 1.1.3 being distributed now as the latest beta.