Collectible Card Game Headquarters

Max mtg wrote:

friarsol wrote:

Max mtg wrote:There never was only one point into cards inside a zone. You could always obtain a zone and query cards from it directly.

Well, then we should fix that too. A single entry point will make sure that every function that wants access is getting it the same way.

Thanks, I have more interesting things to do.

Wow.... Unbelievable.

Well, the laughing smiley was a bit surplus, but tracking down functions that grab zones and query cards from it directly is tedious to say the least.

Solution: Make AllZoneUtil.getCardsIn(Zone) use Player.getCardsIn(Zone) and put your phasing filter in Player.getCardsIn(Zone). I volunteer in testing and fixing calls that get around this.

Sloth wrote:Well, the laughing smiley was a bit surplus, but tracking down functions that grab zones and query cards from it directly is tedious to say the least.

Ok. Fair enough.

Max, you're right, it is tedious. I was just expecting the cleaned up code to be fully centralized.

Thanks for volunteering Sloth.

It looked like Sol was pointing me what to do, and I've had enough of that refactoring last Sunday. So, maybe we should (have it all centralized)... but we can't have that for now.

That zone centralization is in relativelly good condition now. Player.getCardsIn(Zone) is an utility function, which wraps a CardList around what's found in zone.getCards(). Any code comes to querying zone anyway. We cannot make private getZone() in Player, nor limit the visibility of getCards(), because many pieces of code need zones themselves (to move a card to that zone for instance)

There are lots of places which need programmers' attention more than this zone-peeking.

Max mtg wrote:It looked like Sol was pointing me what to do, and I've had enough of that refactoring last Sunday. So, maybe we should (have it all centralized)... but we can't have that for now.

That zone centralization is in relativelly good condition now. Player.getCardsIn(Zone) is an utility function, which wraps a CardList around what's found in zone.getCards(). Any code comes to querying zone anyway. We cannot make private getZone() in Player, nor limit the visibility of getCards(), because many pieces of code need zones themselves (to move a card to that zone for instance)

There are lots of places which need programmers' attention more than this zone-peeking.

Understandable. Refactoring is a huge drain, and will rarely feel as rewarding as adding new features.

I'll figure something out when I have some time to get everything on the same track. This way Phased Out cards will be ignored when requesting through that centralized pipeline, but during the Phasing portion of the Untap step they will be available through a unique function call.

Ah... I see now, you wanted to find a place in the calls chain to intercept the cardlist and exclude the phased-out ones.

The first solution I'd suggest - leave those 16 cards with phasing and concentrate on Innistrad's double faced ones.
The second... would involve modifying DefaultPlayerZone to return two lists of cards - one for all cards and second for only phased in, to use the 1st one for displaying cards and second for all game rules.