Token image downloading

[slapshot5]

Is there a reason that the downloading of token images with Download Card LQ Pictures and Download Card Set LQ Pictures is disabled?

Was this just part of the lightweight CardFactory changes?

I'd like to re-enable it.

-slapshot5

[Max mtg]

When I changed the getNeededCards() functions - there was no tokes download, or it was commented out. So I'm absolutelly sure that I didn't break it.

Given a list of all tokens, the download can be restored very easily.

[slapshot5]

When I changed the getNeededCards() functions - there was no tokes download, or it was commented out. So I'm absolutelly sure that I didn't break it.

Given a list of all tokens, the download can be restored very easily.

Yeah, I've got the code working. Just didn't want to check it in yet in case there was a reason for the removal.

-slapshot5

[Doublestrike]

Since we're on this topic, sort of, what's the general feeling about removing the "pics" directory from version control? (I'll update the code to work correctly).

I like to test with card pictures, but every time I go to commit SVN tries to commit all my pictures so I have to cut and paste all over the place. So, if there's no Howl from Beyond, I'd like to remove pics from the control.

[friarsol]

Since we're on this topic, sort of, what's the general feeling about removing the "pics" directory from version control? (I'll update the code to work correctly).

I like to test with card pictures, but every time I go to commit SVN tries to commit all my pictures so I have to cut and paste all over the place. So, if there's no Howl From Beyond, I'd like to remove pics from the control.

Why not just add them to your svn:ignore?

[Doublestrike]

Could do, but seemed like sort of a hack-y solution. Seems the whole folder is there just to support a few icons used in Quest mode.

[Hellfish]

You could do like I do and keep a pics folder away from actual Forge installations and just change your main.properties file to point there.Nice when you have multiple Forges going(Latest beta,latest svn checkout, own experimental). Just don't do like I do and accidentally commit your main.properties from time to time.

[friarsol]

Could do, but seemed like sort of a hack-y solution. Seems the whole folder is there just to support a few icons used in Quest mode.

Not exactly hacky, considering Forge crashes if those icons don't exist.

[Rob Cashwalker]

I think anything that is not a card pic should just be moved to the images folder.

I just made a http://cardforge.org/fpics/tokens it contains the tokens.zip (extracted) that moomarc posted recently. If anyone would like to maintain the tokens folder, I will make ftp access.

[moomarc]

I think anything that is not a card pic should just be moved to the images folder.

I just made a http://cardforge.org/fpics/tokens it contains the tokens.zip (extracted) that moomarc posted recently. If anyone would like to maintain the tokens folder, I will make ftp access.

I don't mind maintaining it. The if I ever get to finishing the pet tokens I can add it directly.

[Doublestrike]

I think anything that is not a card pic should just be moved to the images folder.

This is more of what I was saying...since pics aren't SVN controlled, but icons are, perhaps there's a better place for icons (and tokens?) and pics should be removed from SVN control.

[moomarc]

I think anything that is not a card pic should just be moved to the images folder.

This is more of what I was saying...since pics aren't SVN controlled, but icons are, perhaps there's a better place for icons (and tokens?) and pics should be removed from SVN control.

The tokens still have mostly CR artwork so at this stage I'd say leave them with the pics.

On another point, is there any reason why we don't have the quest opponent icons included in the pics download launched from in-game? It would make things so much easier for users if all they had to download from the forum was the actual beta build.

[slapshot5]

On another point, is there any reason why we don't have the quest opponent icons included in the pics download launched from in-game? It would make things so much easier for users if all they had to download from the forum was the actual beta build.

I can add them when I restore the token download. I just need names and locations.

-slapshot5

[moomarc]

On another point, is there any reason why we don't have the quest opponent icons included in the pics download launched from in-game? It would make things so much easier for users if all they had to download from the forum was the actual beta build.

I can add them when I restore the token download. I just need names and locations.

-slapshot5

I should be able to host them on my domain. That should make life a bit easier for Rob.

Edit: Argh! Can't access the downloads for the opponent icons, the boosters or any of the mediafire downloads in fact, so I can't get the images. Keeps giving a connection error although mediafire itself is fine. So as soon as I manage to get the images I'll host them for you to link to.

[slapshot5]

What do people think for an implementation? I'm hesitant to put the quest opponent icons and booster images in the "Download Set LQ Pics" and "Download LQ Pics" options. Since those are only in quest (right?), I feel there should be some kind of in-game downloading within quest mode for those. Personally, I never use Quest, so I don't really need these.

Or, they can be added to the normal LQ downloaders, and I can change the name to "Download In-Game Images" or something like that.

Thoughts?

-slapshot5