Mind's Desire Conversion

[friarsol]

So a few weeks back I was working on converting Mind's Desire to script. The script itself works alongside the code changes, but there's some unresolved issues with it. (Most specifically, Mind's Desire pumps the Exiled card with a Keyword, but when the Card is cast, the keyword isn't being removed from the Card).

I've been extremely busy with both work and life lately, so I don't know when I'll be able to get back to this. If anyone is interested in picking this up, I'm going to post the patch and you can see what's going on.

I was attempting to write the code in a way that allowed cards like Yawgmoth's Will to follow in its footsteps. And it seems like it should work once the kinks are worked out. In fact, those cards might be easier since they are granting their privileges as a Static Effect, not a one-time use Pump.

Remember this is for cards that allow you to Play a card for the remainder of the turn, not for SAs that allow you to Play Cards as part of the resolution of a SA.

Aerial Caravan is fine.
Brilliant Ultimatum is not.

Here's the bug tracker # if you want to finish this code: http://cardforge.org/bugz/view.php?id=223

[Sloth]

I will give it a try.

EDIT: The "May be played" keyword works fine. I can't see any implementation of the "without paying mana cost" part though. Did you do some work on this too Sol?

Regarding the pump persisting through to the battlefield, I'm surprised myself. I knew that moving cards to the battlefield will not change the card object (a lot of stuff depends on this), but moving them to the stack should use copyCard which does not copy extrinsic keywords.

[friarsol]

Oh, that might be the other reason I didn't commit. I guess I forgot where I had left things off. Probably we need to pass something from SA_Requirements to CostPayment to inform it to that the ManaCost is already considered paid. So we just need to figure out when that occurs.

There must be something else going on that's causing some issues related to the Pumping and changing zones. Hopefully, there's an appropriate solution that fixes some long-term problem that we could never resolve.

[Sloth]

I've tested a lot today and discovered several fishy things in the changeZone and copyCard code. I will not start to change anything until Hellfish commits his MultiState code, since conflicts would arise.

[friarsol]

Sounds good. Thanks for getting the initial part in Sloth. I wasn't even thinking about doing it for simpler cards. Yawgmoth's Agenda might be able to be scripted now as a combination of that (for Graveyards), Arcane Laboratory. Although, the last ability might be hardcoded right now, so maybe it's not quite there.

[Hellfish]

Hmm, I was gonna wait until after the next beta to commit in case of showstopper bugs (like the unblocked attacker crash >_>) , maybe that's a slightly worse idea then?

[friarsol]

Hmm, I was gonna wait until after the next beta to commit in case of showstopper bugs (like the unblocked attacker crash >_>) , maybe that's a slightly worse idea then?

Probably don't need to wait for next beta, especially if we're going to delay the next beta until it's ironed out. There will definitely be more eyes on it if it's checked in.