Page 6 of 6

Re: Incorrect Scripts

PostPosted: 17 Apr 2012, 23:51
by squee1968
While scripting Bend or Break, I looked at Death or Glory, and noticed a couple of things. Firstly, the ChosenPile$ DBReturn and the other should be reversed, since DoG states "Exile the pile of an opponent's choice..." and also, shouldn't the Origin$ Library be Origin$ Graveyard on both the ChangeZone SVars?

Re: Incorrect Scripts

PostPosted: 20 Apr 2012, 15:30
by squee1968
Vodalian Illusionist has flanking. It should not.

Re: Incorrect Scripts

PostPosted: 20 Apr 2012, 15:41
by friarsol
squee1968 wrote:Vodalian Illusionist has flanking. It should not.
Very true.

Re: Incorrect Scripts

PostPosted: 25 Apr 2012, 09:19
by mark
Sludge Strider has an error: It only triggers if an artifact is put into the graveyard but should also trigger if the artifact is exiled or put to the hand.
I guess it should be "Origin$ Battlefield | Destination$ Any" instead of "Origin$ Battlefield | Destination$ Graveyard"

Re: Incorrect Scripts

PostPosted: 17 May 2012, 12:01
by mark
If no other creature except Fettergeist is on the battlefield, the player is prompted to pay 0 mana in his upkeep, but the OK-button cannot be clicked, only the cancel button is clickable, which sacrifices Fettergeist.

(also: please apply the fix to Sludge Strider from my posting above)

Re: Incorrect Scripts

PostPosted: 17 May 2012, 12:47
by moomarc
mark wrote:If no other creature except Fettergeist is on the battlefield, the player is prompted to pay 0 mana in his upkeep, but the OK-button cannot be clicked, only the cancel button is clickable, which sacrifices Fettergeist.

(also: please apply the fix to Sludge Strider from my posting above)
The Fettergeist issue probably belongs more in the bugs thread, but I did apply the fix for Sludge Strider. Thanks.

Re: Incorrect Scripts

PostPosted: 17 May 2012, 15:47
by moomarc
@Sloth: In the Play ability for Howltooth Hollow you just added, what's up with the ForgetRemembered param? There's nothing in the code for it and I'm not sure if it makes sense as a ForgetOtherRemembered where it's placed in the script at the moment. Am I missing something?

Re: Incorrect Scripts

PostPosted: 17 May 2012, 19:08
by friarsol
moomarc wrote:@Sloth: In the Play ability for Howltooth Hollow you just added, what's up with the ForgetRemembered param? There's nothing in the code for it and I'm not sure if it makes sense as a ForgetOtherRemembered where it's placed in the script at the moment. Am I missing something?
Maybe he meant to have a Cleanup => ClearRemembered SubAbility?

Re: Incorrect Scripts

PostPosted: 18 May 2012, 11:42
by Sloth
moomarc wrote:@Sloth: In the Play ability for Howltooth Hollow you just added, what's up with the ForgetRemembered param? There's nothing in the code for it and I'm not sure if it makes sense as a ForgetOtherRemembered where it's placed in the script at the moment. Am I missing something?
Thanks for reminding me. Because cards don't become new game objects when changing zones, there needed to be some scripting to make Howltooth Hollow forget about it.

It doesn't work with a subability because if the player chooses not to play the card, the forgetting should not happen. I think this problem is still there for cards that target (if the player chooses to play the card but cancels the targeting).

Re: Incorrect Scripts

PostPosted: 18 May 2012, 12:38
by moomarc
Sloth wrote:
moomarc wrote:@Sloth: In the Play ability for Howltooth Hollow you just added, what's up with the ForgetRemembered param? There's nothing in the code for it and I'm not sure if it makes sense as a ForgetOtherRemembered where it's placed in the script at the moment. Am I missing something?
Thanks for reminding me. Because cards don't become new game objects when changing zones, there needed to be some scripting to make Howltooth Hollow forget about it.

It doesn't work with a subability because if the player chooses not to play the card, the forgetting should not happen. I think this problem is still there for cards that target (if the player chooses to play the card but cancels the targeting).
I think ideally the whole remembered system needs some tweaking. Perhaps we need a 'TrackRemembered' parameter that flags the host and affected cards. Then if the host card changes zones the flags and remembered list is cleared, and if one of the affected cards changes zones (except to the stack) it is removed from the remembered list and has its trackedBy flag removed. Not sure if that makes sense.