Page 1 of 6

Incorrect Scripts

PostPosted: 12 Nov 2011, 23:19
by friarsol
Sometimes I put these on the Wiki, but I don't know how much those get seen, so I'm going to start a thread for cards that I notice whose scripts are wrong and fixable. Feel free to add your own, or fix the scripts as appropriate.

Lightning Surge - This shouldn't be two spells, it should be a spell with a non-Threshold conditional, and subability with a Threshold conditional.

Knowledge Vault - Sacrificing the Vault is not a cost, it happens as part of resolution of the ability.

Re: Incorrect Scripts

PostPosted: 13 Nov 2011, 03:33
by jeffwadsworth
friarsol wrote:Sometimes I put these on the Wiki, but I don't know how much those get seen, so I'm going to start a thread for cards that I notice whose scripts are wrong and fixable. Feel free to add your own, or fix the scripts as appropriate.

Lightning Surge - This shouldn't be two spells, it should be a spell with a non-Threshold conditional, and subability with a Threshold conditional.

Knowledge Vault - Sacrificing the Vault is not a cost, it happens as part of resolution of the ability.
:) I would love to see the script (with current code) of Knowledge Vault.

Re: Incorrect Scripts

PostPosted: 20 Nov 2011, 15:03
by jeffwadsworth
Goblin Charbelcher is similar to Knowledge Vault in that both need to "Remember" two different objects.

Re: Incorrect Scripts

PostPosted: 25 Nov 2011, 22:06
by slapshot5
I think Rending Vines is incorrect. It should use conditions instead of targeting restrictions.

Re: Incorrect Scripts

PostPosted: 09 Jan 2012, 15:57
by Sloth
The script of Sudden Spoiling does not work. "RemoveAllAbilities" is not fully supported in AnimateAll (it only removes keywords, no activated, triggered or other static abilities).

Re: Incorrect Scripts

PostPosted: 13 Jan 2012, 13:51
by ArsenalNut
The second ability for Brutal Deceiver, Callous Deceiver, and Feral Deceiver pumps no matter what cards is revealed. The scripts should be using conditionals.

Re: Incorrect Scripts

PostPosted: 22 Jan 2012, 07:08
by Sloth
The recently added script for Angelic Arbiter is not correct. There should be no triggers in the script. The static abilities should work even when Angelic Arbiter enters the battlefield after the attack (or after a spell was cast).

Re: Incorrect Scripts

PostPosted: 22 Jan 2012, 08:16
by jeffwadsworth
Sloth wrote:The recently added script for Angelic Arbiter is not correct. There should be no triggers in the script. The static abilities should work even when Angelic Arbiter enters the battlefield after the attack (or after a spell was cast).
I will remove it soon. Late here.

I suppose it would have to use something like:

Opponent.attackedThisTurn
Opponent.castSpellThisTurn

with a Continuous static with Checks.

Re: Incorrect Scripts

PostPosted: 22 Jan 2012, 08:27
by Sloth
jeffwadsworth wrote:I will remove it soon. Late here.

I suppose it would have to use something like:

Opponent.attackedThisTurn
Opponent.castSpellThisTurn

with a Continuous static with Checks.
Yes. I think the second condition is already possible: "SVar:X:Count$ThisTurnCast_Card.YouDontCtrl".

I will try to make the first one scriptable.

EDIT: Done!

Re: Incorrect Scripts

PostPosted: 07 Feb 2012, 03:40
by jeffwadsworth
.Rathi Dragon. What if you do not wish to sacrifice the mountains?
.Puresteel Paladin. The original attach ability is still on the card.

Re: Incorrect Scripts

PostPosted: 07 Feb 2012, 04:07
by friarsol
jeffwadsworth wrote:.Rathi Dragon. What if you do not wish to sacrifice the mountains?
.Puresteel Paladin. The original attach ability is still on the card.
I don't think Puresteel Paladin should remove the original attach ability, the card is literally granting Equip 0. It doesn't say "You may spend 0 instead of paying for any Equip costs"

Re: Incorrect Scripts

PostPosted: 07 Feb 2012, 04:07
by friarsol
It looks like Catastrophe is wrong, you have to make the decision on casting, not on resolution.

Re: Incorrect Scripts

PostPosted: 07 Feb 2012, 04:14
by jeffwadsworth
Well, if you are forced to sacrifice the mountains, then there are tons of cards like Rathi Dragon that can be added. I always thought you had a choice.

Re: Incorrect Scripts

PostPosted: 07 Feb 2012, 04:29
by timmermac
No, there's no choice there. If you don't sacrifice the mountains, Rathi Dragon is immediately sacrificed.

Re: Incorrect Scripts

PostPosted: 07 Feb 2012, 04:34
by friarsol
timmermac wrote:No, there's no choice there. If you don't sacrifice the mountains, Rathi Dragon is immediately sacrificed.
What? The choice is whether or not you want to sacrifice the Mountains.

117.12a Some spells, activated abilities, and triggered abilities read, "[Do something] unless you [do something else]." This means the same thing as "You may [do something else]. If you don't, [do something]."