Remove SVar= from SubAbility

by **Chris H.** » 16 Jan 2012, 01:54

Hey Slapshot,

I noticed revs 13170 to 13173. You are replacing "SubAbility$ SVar=" with "SubAbility$ " and was wondering if you needed some help in this area.

It looks like SubAbilities have been simplified and removing the "SVar=" portion would help to provide a good example for all of us to follow.

There appears to be 965 card files left to convert. I can start with the letter A once I release the next beta.

The work involved looks fairly simple. I do not think that I can screw it up too much.

by **Doublestrike** » 16 Jan 2012, 01:56

Famous last words

by **friarsol** » 16 Jan 2012, 02:05

Yea when we first wrote SubAbilities "Drawbacks" were still around, so to differentiate them I added SVar so it would be clear to call the SubAbility code. It's been quite some time since the last Drawback was removed from the scripts so the SVar= is unnecessary, and should be removed.

by **slapshot5** » 16 Jan 2012, 02:27

Thanks Chris. I've got it covered. I was on the road all day, so that's all the further I got with checkins. One the beta goes out, I'll check the rest in.

-slapshot5

by **Chris H.** » 16 Jan 2012, 02:29

slapshot5 wrote:Thanks Chris. I've got it covered. I was on the road all day, so that's all the further I got with checkins. One the beta goes out, I'll check the rest in.

`
Ah, the work is done, you just need to find the chance to merge in the other 900+ card files. =D>

by **slapshot5** » 16 Jan 2012, 05:25

I've fixed the cards in DKA branch that I found with this. And I've put a note in the DKA thread not to include this.

-slapshot5