Bug Reports (snapshot builds)

[jeffwadsworth]

When gaining a choice to reveal a card with Delver of Secrets, it's unintuitive to show the Delver instead of the revealed card. Playing with unknown cards, I have to guess if the revealed card is an instant or sorcery.

Fixed.

[moomarc]

Just a small bug: the deck editor is diplaying AE cards strangely this morning (it doesn't affect the card info panel though).

[friarsol]

r14154

Just want to give some more detrails on the quest bug.

1. Win match and I return to main screen >> Old quest opponents are still listed
2. Go into spell shop, buy something >> Old quest opponents are still listed
3. Go into bazaar, buy something >> Old quest opponents are still listed
4. Edit deck >> New quest opponents now listed.

Once I try to play an opponent, either old or new, I'm stuck on the last phase I was in when I won, and can't play. This is a pretty critical bug. So hopefully we can figure out when it happened, and get it resolved.

Multi-game seems to be fixed. However, old quest opponents are still listed when i finished a match. I have to go into challenges and go back to get the redraw with the new opponents.

[Sloth]

In r14057 (think I saw the same thing in 14013), after I've completed a match, the next time I start a match it's stuck in the end-of-match phase...

Despite my previous brief effort this is still happening. It's actually a symptom of a deeper problem, of neatness and organization. Another symptom was that preferences saving hullabaloo a little while ago.

This is because of new games, game cleanups, runtime constant inits, etc. happening all over the place instead of in a single known location. I just spent some time looking at this, so I guess I'll dig deep and get this done. Evolve or die type of thing

I think this is related:
When i concede my first game, quit the match and start a new match there is no Mulligan prompt.

With r14227 conceding and quitting a match works fine now. Winning a match still messes up the next match (not starting with mullingan or upkeep phase).
EDIT: I tested again and this time the second match after playing a match without conceding was not messed up.

[Max mtg]

Just a small bug: the deck editor is diplaying AE cards strangely this morning (it doesn't affect the card info panel though).

What is your OS?
I have replaced (in the code taht shows card name in table column) AE with Æ to make card names look closer to what is printed on cards http://magiccards.info/query?q=aether&v=card&s=cname

[friarsol]

The same bug moomarc has I see to on Windows 7, both 64 and 32 bit.

[Chris H.]

Just a small bug: the deck editor is diplaying AE cards strangely this morning (it doesn't affect the card info panel though).

What is your OS?
I have replaced (in the code taht shows card name in table column) AE with Æ to make card names look closer to what is printed on cards http://magiccards.info/query?q=aether&v=card&s=cname

`
I am using Apple Mac OS X Lion version 10.7.3 and in the deck editor I am not seeing either AE or Æ.

`

[Max mtg]

ok, let's try a different approach (store AE as \u00C6 rather than the very character) - update to 14233 and tell me if it worked for you

[Chris H.]

ok, let's try a different approach (store AE as \u00C6 rather than the very character) - update to 14233 and tell me if it worked for you

`
Your new approach looks correct on Mac OS X. Thank you.

`

[Sloth]

I've got a weird bug (r14233): When i add a new quest deck to the quest decks folder, i get these errors:

| Open

java.lang.NullPointerException
at forge.view.home.ViewSettings.populatePrefs(ViewSettings.java:216)
at forge.view.home.ViewSettings.<init>(ViewSettings.java:117)
at forge.view.ViewHomeUI.<init>(ViewHomeUI.java:81)
at forge.view.FView.instantiateCachedUIStates(FView.java:164)
at forge.view.FView$2.run(FView.java:103)
at java.awt.event.InvocationEvent.dispatch(Unknown Source)
at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
at java.awt.EventQueue.access$000(Unknown Source)
at java.awt.EventQueue$1.run(Unknown Source)
at java.awt.EventQueue$1.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)

and

| Open

java.util.ConcurrentModificationException
at java.util.AbstractList$Itr.checkForComodification(Unknown Source)
at java.util.AbstractList$Itr.next(Unknown Source)
at forge.quest.data.QuestEventManager.assembleDuelDifficultyLists(QuestEventManager.java:313)
at forge.quest.data.QuestEventManager.assembleAllEvents(QuestEventManager.java:99)
at forge.control.FControl.initialize(FControl.java:99)
at forge.view.Main.main(Main.java:59)

When i remove the deck file, the error is gone.

[jeffwadsworth]

I've got a weird bug (r14233): When i add a new quest deck to the quest decks folder, i get these errors:

| Open

java.lang.NullPointerException
at forge.view.home.ViewSettings.populatePrefs(ViewSettings.java:216)
at forge.view.home.ViewSettings.<init>(ViewSettings.java:117)
at forge.view.ViewHomeUI.<init>(ViewHomeUI.java:81)
at forge.view.FView.instantiateCachedUIStates(FView.java:164)
at forge.view.FView$2.run(FView.java:103)
at java.awt.event.InvocationEvent.dispatch(Unknown Source)
at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
at java.awt.EventQueue.access$000(Unknown Source)
at java.awt.EventQueue$1.run(Unknown Source)
at java.awt.EventQueue$1.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)

and

| Open

java.util.ConcurrentModificationException
at java.util.AbstractList$Itr.checkForComodification(Unknown Source)
at java.util.AbstractList$Itr.next(Unknown Source)
at forge.quest.data.QuestEventManager.assembleDuelDifficultyLists(QuestEventManager.java:313)
at forge.quest.data.QuestEventManager.assembleAllEvents(QuestEventManager.java:99)
at forge.control.FControl.initialize(FControl.java:99)
at forge.view.Main.main(Main.java:59)

When i remove the deck file, the error is gone.

I am seeing the exact same errors. But I didn't add anything, just grabbed the source from scratch.

[Max mtg]

Looks like a number threads are trying to get some lazily initialized fields that are not thread safe

[Max mtg]

I hope 14234 will solve it, but the code is not mine, so no idea how this will affect the game

[friarsol]

AE looks good on Win7 with the unicode fix.

[moomarc]

ok, let's try a different approach (store AE as \u00C6 rather than the very character) - update to 14233 and tell me if it worked for you

`
Your new approach looks correct on Mac OS X. Thank you.

`

Working on my Windows 7 perfectly now too. Thanks.