Collectible Card Game Headquarters

myk wrote:

Chris H. wrote:When adjusting the column widths the mouse pointer used to change when it was hovered over the titles. This feature has apparently dissapeared.

did this happen recently? when did you notice it? What JVM are you running (I see a resolved bug that mentions this for the JDK)?

 
OS: Mac OS X Version: 10.7.5 Architecture: x86_64
Java Version: 1.6.0_37 Vendor: Apple Inc.

I am not sure when this situation developed. Reading the commit logs this morning convinced me to check out the changes in the deck editor.

We had a similar problem happen months ago and a number of people commented on not being able to change the widths of the columns. In reality they could but they had not tried. It was a case where the lack of the mouse pointer changing lead them to believe that this changing column widths feature had been removed or was broken.

Chris H. wrote:OS: Mac OS X Version: 10.7.5 Architecture: x86_64
Java Version: 1.6.0_37 Vendor: Apple Inc.

I am not sure when this situation developed. Reading the commit logs this morning convinced me to check out the changes in the deck editor.

We had a similar problem happen months ago and a number of people commented on not being able to change the widths of the columns. In reality they could but they had not tried. It was a case where the lack of the mouse pointer changing lead them to believe that this changing column widths feature had been removed or was broken.

I am actually seeing this same issue on both OSX 10.8 (same jvm version) and Linux (OpenJDK 1.11.5), but AFAIR, this has been been there for a while -- I thought the columns couldn't be resized before I tried the first time too.

myk wrote:I am actually seeing this same issue on both OSX 10.8 (same jvm version) and Linux (OpenJDK 1.11.5), but AFAIR, this has been been there for a while -- I thought the columns couldn't be resized before I tried the first time too.

 
You are right.

The last beta that had the changeable mouse pointer is Forge Beta: 10-26-2012 ver 1.3.0 which is based on the code found in SVN rev 17721.

I would not lose too much sleep over it, if this missing feature can be added back in then great, but this is not a mission critical feature ... but it would be a good thing if we can add it back in.

If you are curious then checkout the earlier beta to see what it looked like.

Chris H. wrote:The last beta that had the changeable mouse pointer is Forge Beta: 10-26-2012 ver 1.3.0 which is based on the code found in SVN rev 17721.

while I'm waiting for feedback on the deck editor filters, I'll see if I can do some bisection and figure out which commit broke the functionality

hrm, I found the problem, but I need to investigate the implications of fixing it -- it's line 87 of FView.java:

Code: Select all

lpnDocument.add(TargetingOverlay.SINGLETON_INSTANCE.getPanel(), TARGETING_LAYER);


commenting this line out gets the resize cursor back, but I need to figure out while it's there in the first place : )

Edit: TARGETING_LAYER is defined as JLayeredPane.MODAL_LAYER - 1, which seems to be playing games with internal constants. If I replace the above line with:

Code: Select all

lpnDocument.add(TargetingOverlay.SINGLETON_INSTANCE.getPanel(), JLayeredPane.MODAL_LAYER);


everything /seems/ to work -- the start game overlay looks ok, and targeting highlights look ok. On the other hand, I'm not entirely sure I know what to look for to decide whether those overlays are behaving as expected. Could someone else who knows a little more about this test the fix out?

Asellia wrote:I have had this trouble since 1.3.4 or so, I think, but it appears that I cannot partake in challenges. I have been using a series of custom worlds I made, utilizing default enemies/challenges, however, I cannot seem to pick challenges even when I have enough wins:
Edit:

I was using "forge-1.3.6-20130123.120651-5" as reference

Asellia, apologies for not replying sooner. I have been busy fixing other things.

Could you please zip and post your res/quest/data folder (from a situation where you ought to have got a challenge and aren't getting one)? I really want to solve the problem, and that could speed up the process considerably.

myk wrote:hrm, I found the problem, but I need to investigate the implications of fixing it -- it's line 87 of FView.java:

Code: Select all

lpnDocument.add(TargetingOverlay.SINGLETON_INSTANCE.getPanel(), TARGETING_LAYER);


commenting this line out gets the resize cursor back, but I need to figure out while it's there in the first place : )

Edit: TARGETING_LAYER is defined as JLayeredPane.MODAL_LAYER - 1, which seems to be playing games with internal constants. If I replace the above line with:

Code: Select all

lpnDocument.add(TargetingOverlay.SINGLETON_INSTANCE.getPanel(), JLayeredPane.MODAL_LAYER);


everything /seems/ to work -- the start game overlay looks ok, and targeting highlights look ok. On the other hand, I'm not entirely sure I know what to look for to decide whether those overlays are behaving as expected. Could someone else who knows a little more about this test the fix out?

A little more on this - changing the layer index is just part of the fix, we also have to resize it in FView.java. Otherwise the targeting arrows don't appear in the match (now that I looked more into how the targeting layer is used, I know what to look for). I'm testing it out in my branch and will get it merged when I merge the rest of the code there.

friarsol wrote:r19213

Hands of Binding ciphered on my Mogg Flunkies. It doesn't have trample. I attack with it and an 8/8 Trample. AI blocks some on my trampler and 2/2 Wither to my Flunkie. Cipher on the Flunkie triggers (incorrectly, since I didn't damage a player).

Fixed! The generated trigger was just missing the player clause.

friarsol wrote:Is Draft or Sealed working for anyone else?

Fixed! Thanks sol.

I just checked in a number of changes to the deck editor in trunk. please report any bugs you run into here. I also found that the font for the default skin lacked some internal metadata that was causing text on all labels to be permanently top-aligned instead of centered. There were a lot of fonts that work fine, but I tried to choose one that looked as similar as possible to the font that was there. Please tell me if the new font causes any trouble for anyone!

hey Sloth -- I reverted r19291 for now -- the change to EditorTableView. It was preventing the catalog from updating in the quest deck editor and spell shop.

Edit: I found the root cause -- it was the change I made last week that reapplies the filters when the deck editor is reloaded. I'll find a better place to put that line.
Edit 2: I found a better place to reapply the filters that works for all modes. Sorry for the inconvenience!

The ETB Ability of Overlaid Terrain has a "0:" before the "As ~ ETB" in the description. Looks like this is related to the ETB conversion

friarsol wrote:The ETB Ability of Overlaid Terrain has a "0:" before the "As ~ ETB" in the description. Looks like this is related to the ETB conversion

Fixed. Just forgot to remove the cost.

A subability Effect using param "RememberObjects$ Remembered" makes the effect remember redundant information, e.g. Circle of Protection.

Edit: Shortcut "E" is not functional.

swordshine wrote:Edit: Shortcut "E" is not functional.

What does shortcut E mean?