Page 89 of 487

Re: Bug Reports (snapshot builds)

PostPosted: 19 Feb 2013, 02:58
by reeeech
Sorry, I thought it was cool to post here.

Alright, no prob. I'll stick with 1.3.7 til then.

Cheers!

Re: Bug Reports (snapshot builds)

PostPosted: 19 Feb 2013, 03:58
by timmermac
reeeech wrote:That's odd?

I downloaded 1.3.8 again and keep getting the same problem. 1.3.7 works just fine for me.

I've made a new deck as well. Anytime the dredge mechanic is supposed to happen I keep getting that messege, but, before the pulldown window giving me the option to dredge or draw.
You can get the most current snapshot release here

Re: Bug Reports (snapshot builds)

PostPosted: 20 Feb 2013, 06:18
by RumbleBBU
Fresh from SVN, Refresh, Clean and run results in this for me:

NullPointerException | Open
Code: Select all
Forge Version:    Forge version SVN
Operating System: Windows XP 5.1 x86
Java Version:     1.6.0_21 Sun Microsystems Inc.null

java.lang.NullPointerException
   at forge.gui.deckeditor.controllers.CEditorPreferences.initialize(CEditorPreferences.java:75)
   at forge.view.FView.initialize(FView.java:106)
   at forge.control.FControl$6.run(FControl.java:179)
   at java.awt.event.InvocationEvent.dispatch(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)

What am I doing wrong?

Re: Bug Reports (snapshot builds)

PostPosted: 20 Feb 2013, 08:02
by myk
try moving your res/preferences/editor.preferences file somewhere safe and starting up forge again. if that fixes the problem, could you post your editor.preferences file?

Re: Bug Reports (snapshot builds)

PostPosted: 20 Feb 2013, 08:57
by RumbleBBU
Interesting...it seems that one of the preference files was indeed at fault but not the editor preferences file. At least not solely. I had to replace all preference files with the default ones before I got Forge to launch.

The contents of my non-working preferences directory are included in the zip for your perusal.

Re: Bug Reports (snapshot builds)

PostPosted: 20 Feb 2013, 16:36
by myk
Thanks! I'll take a look at them.

Edit: current build is broken due to failing tests : (
test failures | Open
Code: Select all
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running TestSuite
Configuring TestNG with: org.apache.maven.surefire.testng.conf.TestNGMapConfigurator@73d6776d
[white, red, blue]
failed : 41.0
failed : 42.0
Tests run: 9, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 1.567 sec <<< FAILURE!

Results :

Failed tests:   test(forge.item.DeckHintsTest)
  testCards(forge.item.DeckHintsTest)
  testColor(forge.item.DeckHintsTest)
  testKeywords(forge.item.DeckHintsTest)

Tests run: 9, Failures: 4, Errors: 0, Skipped: 0
target/surefire-reports/junitreports/TEST-forge.item.DeckHintsTest.xml | Open
Code: Select all
<?xml version="1.0" encoding="UTF-8"?>
<!-- Generated by org.testng.reporters.JUnitReportReporter -->
<testsuite hostname="valheru.level" name="forge.item.DeckHintsTest" tests="4" failures="4" timestamp="20 Feb 2013 16:49:08 GMT" time="0.040" errors="0">
  <testcase name="testCards" time="0.001" classname="forge.item.DeckHintsTest">
    <failure type="java.lang.NullPointerException">
      <![CDATA[java.lang.NullPointerException
   at forge.card.CardRules.getName(CardRules.java:121)
   at forge.item.CardPrinted.<init>(CardPrinted.java:196)
   at forge.item.CardPrinted.build(CardPrinted.java:219)
   at forge.item.DeckHintsTest.readCard(DeckHintsTest.java:142)
   at forge.item.DeckHintsTest.testCards(DeckHintsTest.java:51)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
   at java.lang.reflect.Method.invoke(Method.java:597)
   at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80)
   at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:46)
   at org.testng.internal.InvokeMethodRunnable.run(InvokeMethodRunnable.java:37)
   at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:439)
   at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
   at java.util.concurrent.FutureTask.run(FutureTask.java:138)
   at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
   at java.lang.Thread.run(Thread.java:680)
]]>
    </failure>
  </testcase> <!-- testCards -->
  <testcase name="test" time="0.036" classname="forge.item.DeckHintsTest">
    <failure type="java.lang.NullPointerException">
      <![CDATA[java.lang.NullPointerException
   at forge.card.CardRules.getName(CardRules.java:121)
   at forge.item.CardPrinted.<init>(CardPrinted.java:196)
   at forge.item.CardPrinted.build(CardPrinted.java:219)
   at forge.item.DeckHintsTest.readCard(DeckHintsTest.java:142)
   at forge.item.DeckHintsTest.test(DeckHintsTest.java:30)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
   at java.lang.reflect.Method.invoke(Method.java:597)
   at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80)
   at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:46)
   at org.testng.internal.InvokeMethodRunnable.run(InvokeMethodRunnable.java:37)
   at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:439)
   at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
   at java.util.concurrent.FutureTask.run(FutureTask.java:138)
   at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
   at java.lang.Thread.run(Thread.java:680)
]]>
    </failure>
  </testcase> <!-- test -->
  <testcase name="testKeywords" time="0.002" classname="forge.item.DeckHintsTest">
    <failure type="java.lang.NullPointerException">
      <![CDATA[java.lang.NullPointerException
   at forge.card.CardRules.getName(CardRules.java:121)
   at forge.item.CardPrinted.<init>(CardPrinted.java:196)
   at forge.item.CardPrinted.build(CardPrinted.java:219)
   at forge.item.DeckHintsTest.readCard(DeckHintsTest.java:142)
   at forge.item.DeckHintsTest.testKeywords(DeckHintsTest.java:73)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
   at java.lang.reflect.Method.invoke(Method.java:597)
   at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80)
   at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:46)
   at org.testng.internal.InvokeMethodRunnable.run(InvokeMethodRunnable.java:37)
   at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:439)
   at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
   at java.util.concurrent.FutureTask.run(FutureTask.java:138)
   at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
   at java.lang.Thread.run(Thread.java:680)
]]>
    </failure>
  </testcase> <!-- testKeywords -->
  <testcase name="testColor" time="0.001" classname="forge.item.DeckHintsTest">
    <failure type="java.lang.NullPointerException">
      <![CDATA[java.lang.NullPointerException
   at forge.card.CardRules.getName(CardRules.java:121)
   at forge.item.CardPrinted.<init>(CardPrinted.java:196)
   at forge.item.CardPrinted.build(CardPrinted.java:219)
   at forge.item.DeckHintsTest.readCard(DeckHintsTest.java:142)
   at forge.item.DeckHintsTest.testColor(DeckHintsTest.java:92)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
   at java.lang.reflect.Method.invoke(Method.java:597)
   at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80)
   at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:46)
   at org.testng.internal.InvokeMethodRunnable.run(InvokeMethodRunnable.java:37)
   at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:439)
   at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
   at java.util.concurrent.FutureTask.run(FutureTask.java:138)
   at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
   at java.lang.Thread.run(Thread.java:680)
]]>
    </failure>
  </testcase> <!-- testColor -->
</testsuite> <!-- forge.item.DeckHintsTest -->
Edit 2: it looks like the culprit is r19776

Re: Bug Reports (snapshot builds)

PostPosted: 20 Feb 2013, 17:57
by Max mtg
tests pass with 19787+

Re: Bug Reports (snapshot builds)

PostPosted: 20 Feb 2013, 18:04
by myk
confirmed, thx! Also, thanks for cleaning out the mantis deps form the pom. It really reduces the size of the .jar deliverable!

Rumble: it looks like your editor.default.preferences file hadn't been updated - it didn't have the new RANKING columns listed. Is it possible that the src directory was updated on your system, but not res?

Re: Bug Reports (snapshot builds)

PostPosted: 20 Feb 2013, 22:47
by myk
Hey Max, it looks like world filtering was broken somewhere between r19776 and r19787. Here's how to repro:
  1. start forge, go to deck editor
  2. click Add Filter, select World->Standard
  3. two exceptions come up (we probably have a separate bug somewhere else that doesn't stop processing when an exception is thrown)
NullPointerException | Open
Code: Select all
Forge Version:    Forge version 1.3.9-SNAPSHOT-r19787
Operating System: Mac OS X 10.8.2 x86_64
Java Version:     1.6.0_37 Apple Inc.null

java.lang.NullPointerException
   at forge.gui.deckeditor.tables.EditorTableModel.showSelectedCard(EditorTableModel.java:194)
   at forge.gui.deckeditor.tables.EditorTableModel$2.focusGained(EditorTableModel.java:224)
   at java.awt.AWTEventMulticaster.focusGained(AWTEventMulticaster.java:203)
   at java.awt.Component.processFocusEvent(Component.java:6271)
   at java.awt.Component.processEvent(Component.java:6138)
   at java.awt.Container.processEvent(Container.java:2083)
   at java.awt.Component.dispatchEventImpl(Component.java:4744)
   at java.awt.Container.dispatchEventImpl(Container.java:2141)
   at java.awt.Component.dispatchEvent(Component.java:4572)
   at java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1856)
   at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:911)
   at java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:523)
   at java.awt.Component.dispatchEventImpl(Component.java:4616)
   at java.awt.Container.dispatchEventImpl(Container.java:2141)
   at java.awt.Component.dispatchEvent(Component.java:4572)
   at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:704)
   at java.awt.EventQueue.access$400(EventQueue.java:82)
   at java.awt.EventQueue$2.run(EventQueue.java:663)
   at java.awt.EventQueue$2.run(EventQueue.java:661)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:98)
   at java.awt.EventQueue$3.run(EventQueue.java:677)
   at java.awt.EventQueue$3.run(EventQueue.java:675)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
   at java.awt.EventQueue.dispatchEvent(EventQueue.java:674)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
   at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
   at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:205)
   at java.awt.Dialog$1.run(Dialog.java:1044)
   at java.awt.Dialog$3.run(Dialog.java:1096)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.awt.Dialog.show(Dialog.java:1094)
   at java.awt.Component.show(Component.java:1591)
   at java.awt.Component.setVisible(Component.java:1543)
   at java.awt.Window.setVisible(Window.java:843)
   at java.awt.Dialog.setVisible(Dialog.java:984)
   at forge.error.BugReporter._showDialog(BugReporter.java:228)
   at forge.error.BugReporter.reportException(BugReporter.java:93)
   at forge.error.BugReporter.reportException(BugReporter.java:100)
   at forge.error.ExceptionHandler.handle(ExceptionHandler.java:62)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
   at java.lang.reflect.Method.invoke(Method.java:597)
   at java.awt.EventDispatchThread.handleException(EventDispatchThread.java:412)
   at java.awt.EventDispatchThread.processException(EventDispatchThread.java:318)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:312)
   at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188)
   at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)
NullPointerException | Open
Code: Select all
Forge Version:    Forge version 1.3.9-SNAPSHOT-r19787
Operating System: Mac OS X 10.8.2 x86_64
Java Version:     1.6.0_37 Apple Inc.null

java.lang.NullPointerException
   at forge.card.CardRulesPredicates$PredicateExistsInSets.apply(CardRulesPredicates.java:472)
   at forge.card.CardRulesPredicates$PredicateExistsInSets.apply(CardRulesPredicates.java:1)
   at com.google.common.base.Predicates$CompositionPredicate.apply(Predicates.java:536)
   at com.google.common.base.Predicates$AndPredicate.apply(Predicates.java:343)
   at com.google.common.base.Predicates$AndPredicate.apply(Predicates.java:343)
   at com.google.common.base.Predicates$OrPredicate.apply(Predicates.java:377)
   at com.google.common.base.Predicates$CompositionPredicate.apply(Predicates.java:536)
   at com.google.common.collect.Iterators$8.computeNext(Iterators.java:736)
   at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
   at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138)
   at forge.util.Aggregates.uniqueByLast(Aggregates.java:118)
   at forge.gui.deckeditor.tables.EditorTableView.updateView(EditorTableView.java:483)
   at forge.gui.deckeditor.tables.EditorTableView.setFilter(EditorTableView.java:385)
   at forge.gui.deckeditor.controllers.CCardCatalog.applyCurrentFilter(CCardCatalog.java:354)
   at forge.gui.deckeditor.controllers.CCardCatalog.addRestriction(CCardCatalog.java:403)
   at forge.gui.deckeditor.controllers.CCardCatalog.access$5(CCardCatalog.java:376)
   at forge.gui.deckeditor.controllers.CCardCatalog$5$2.run(CCardCatalog.java:148)
   at forge.gui.GuiUtils$1.actionPerformed(GuiUtils.java:149)
   at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2028)
   at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2351)
   at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
   at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
   at javax.swing.AbstractButton.doClick(AbstractButton.java:389)
   at javax.swing.plaf.basic.BasicMenuItemUI.doClick(BasicMenuItemUI.java:809)
   at com.apple.laf.AquaMenuItemUI.doClick(AquaMenuItemUI.java:137)
   at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(BasicMenuItemUI.java:850)
   at java.awt.Component.processMouseEvent(Component.java:6382)
   at javax.swing.JComponent.processMouseEvent(JComponent.java:3275)
   at java.awt.Component.processEvent(Component.java:6147)
   at java.awt.Container.processEvent(Container.java:2083)
   at java.awt.Component.dispatchEventImpl(Component.java:4744)
   at java.awt.Container.dispatchEventImpl(Container.java:2141)
   at java.awt.Component.dispatchEvent(Component.java:4572)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4619)
   at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4280)
   at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4210)
   at java.awt.Container.dispatchEventImpl(Container.java:2127)
   at java.awt.Window.dispatchEventImpl(Window.java:2489)
   at java.awt.Component.dispatchEvent(Component.java:4572)
   at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:704)
   at java.awt.EventQueue.access$400(EventQueue.java:82)
   at java.awt.EventQueue$2.run(EventQueue.java:663)
   at java.awt.EventQueue$2.run(EventQueue.java:661)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:98)
   at java.awt.EventQueue$3.run(EventQueue.java:677)
   at java.awt.EventQueue$3.run(EventQueue.java:675)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
   at java.awt.EventQueue.dispatchEvent(EventQueue.java:674)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
   at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188)
   at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

Re: Bug Reports (snapshot builds)

PostPosted: 20 Feb 2013, 23:03
by Max mtg
Now I get this one instead of the mentioned above. Guess it's yours

Choose 'main world' quest filter

NullPointerException | Open
Code: Select all
Forge Version:    Forge version SVN
Operating System: Windows 7 6.1 amd64
Java Version:     1.6.0_24 Sun Microsystems Inc.null

java.lang.NullPointerException
   at forge.gui.deckeditor.controllers.CCardCatalog.buildFormatRestriction(CCardCatalog.java:515)
   at forge.gui.deckeditor.controllers.CCardCatalog.buildWorldRestriction(CCardCatalog.java:528)
   at forge.gui.deckeditor.controllers.CCardCatalog.access$13(CCardCatalog.java:522)
   at forge.gui.deckeditor.controllers.CCardCatalog$5$5.run(CCardCatalog.java:206)
   at forge.gui.GuiUtils$1.actionPerformed(GuiUtils.java:149)
   at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
   at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
   at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
   at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
   at javax.swing.AbstractButton.doClick(Unknown Source)
   at javax.swing.plaf.basic.BasicMenuItemUI.doClick(Unknown Source)
   at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(Unknown Source)
   at java.awt.Component.processMouseEvent(Unknown Source)
   at javax.swing.JComponent.processMouseEvent(Unknown Source)
   at java.awt.Component.processEvent(Unknown Source)
   at java.awt.Container.processEvent(Unknown Source)
   at java.awt.Component.dispatchEventImpl(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Window.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$000(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue$2.run(Unknown Source)
   at java.awt.EventQueue$2.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)


Re: Bug Reports (snapshot builds)

PostPosted: 21 Feb 2013, 01:08
by myk
got it. thanks!

edit: new one in the ImageCache. I reproduced this by buying a booster pack in the spell shop, also when winning a duel.
edit2: I think it might be happening for cards that lack pictures. I just had it happen in the deck editor when I selected a card that I hadn't downloaded the pic for yet.

RuntimeException | Open
Code: Select all
Forge Version:    Forge version 1.3.9-SNAPSHOT-r19795
Operating System: Mac OS X 10.8.2 x86_64
Java Version:     1.6.0_37 Apple Inc.

java.lang.RuntimeException: Error doing rescale. Target size was 0x0 but must be at least 3x3.
   at com.mortennobel.imagescaling.ResampleOp.doFilter(ResampleOp.java:114)
   at com.mortennobel.imagescaling.AdvancedResizeOp.filter(AdvancedResizeOp.java:81)
   at forge.ImageCache.scaleImage(ImageCache.java:101)
   at forge.ImageCache.getImage(ImageCache.java:65)
   at forge.gui.CardPicturePanel.setImage(CardPicturePanel.java:129)
   at forge.gui.CardPicturePanel.setCard(CardPicturePanel.java:113)
   at forge.gui.CardListViewer$SelListener.valueChanged(CardListViewer.java:205)
   at javax.swing.DefaultListSelectionModel.fireValueChanged(DefaultListSelectionModel.java:167)
   at javax.swing.DefaultListSelectionModel.fireValueChanged(DefaultListSelectionModel.java:147)
   at javax.swing.DefaultListSelectionModel.fireValueChanged(DefaultListSelectionModel.java:194)
   at javax.swing.DefaultListSelectionModel.changeSelection(DefaultListSelectionModel.java:388)
   at javax.swing.DefaultListSelectionModel.changeSelection(DefaultListSelectionModel.java:398)
   at javax.swing.DefaultListSelectionModel.setSelectionInterval(DefaultListSelectionModel.java:442)
   at javax.swing.JList.setSelectedIndex(JList.java:2209)
   at forge.gui.CardListViewer.show(CardListViewer.java:139)
   at forge.gui.deckeditor.controllers.CEditorQuestCardShop.addCard(CEditorQuestCardShop.java:339)
   at forge.gui.deckeditor.CDeckEditorUI$1.move(CDeckEditorUI.java:158)
   at forge.gui.deckeditor.CDeckEditorUI.moveSelectedCards(CDeckEditorUI.java:145)
   at forge.gui.deckeditor.CDeckEditorUI.addSelectedCards(CDeckEditorUI.java:154)
   at forge.gui.deckeditor.CDeckEditorUI$4.keyPressed(CDeckEditorUI.java:317)
   at java.awt.AWTEventMulticaster.keyPressed(AWTEventMulticaster.java:232)
   at java.awt.Component.processKeyEvent(Component.java:6340)
   at javax.swing.JComponent.processKeyEvent(JComponent.java:2809)
   at java.awt.Component.processEvent(Component.java:6159)
   at java.awt.Container.processEvent(Container.java:2083)
   at java.awt.Component.dispatchEventImpl(Component.java:4744)
   at java.awt.Container.dispatchEventImpl(Container.java:2141)
   at java.awt.Component.dispatchEvent(Component.java:4572)
   at java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1856)
   at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:722)
   at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:1000)
   at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:865)
   at java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:686)
   at java.awt.Component.dispatchEventImpl(Component.java:4616)
   at java.awt.Container.dispatchEventImpl(Container.java:2141)
   at java.awt.Window.dispatchEventImpl(Window.java:2489)
   at java.awt.Component.dispatchEvent(Component.java:4572)
   at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:704)
   at java.awt.EventQueue.access$400(EventQueue.java:82)
   at java.awt.EventQueue$2.run(EventQueue.java:663)
   at java.awt.EventQueue$2.run(EventQueue.java:661)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:98)
   at java.awt.EventQueue$3.run(EventQueue.java:677)
   at java.awt.EventQueue$3.run(EventQueue.java:675)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
   at java.awt.EventQueue.dispatchEvent(EventQueue.java:674)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
   at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188)
   at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

Re: Bug Reports (snapshot builds)

PostPosted: 21 Feb 2013, 01:54
by friarsol
I don't think we should be crashing if a card doesn't have Oracle text. During spoiler season we often have cards without Oracle text.

Code: Select all
Deathlace has no Oracle text
java.lang.NullPointerException
   at forge.item.CardDb$CardSorter.addNewCard(CardDb.java:425)

Re: Bug Reports (snapshot builds)

PostPosted: 21 Feb 2013, 02:01
by friarsol
myk wrote:\
edit: new one in the ImageCache. I reproduced this by buying a booster pack in the spell shop.
It happens for me if I just try to start a constructed duel. (random random)

Crash | Open
java.lang.RuntimeException: Error doing rescale. Target size was -2x-2 but must be at least 3x3.
at com.mortennobel.imagescaling.ResampleOp.doFilter(ResampleOp.java:114)
at com.mortennobel.imagescaling.AdvancedResizeOp.filter(AdvancedResizeOp.java:81)
at forge.ImageCache.scaleImage(ImageCache.java:101)
at forge.ImageCache.getImage(ImageCache.java:58)
at forge.gui.CardPicturePanel.setImage(CardPicturePanel.java:133)
at forge.gui.CardPicturePanel.setCard(CardPicturePanel.java:121)
at forge.gui.CardPicturePanel.<init>(CardPicturePanel.java:87)
at forge.gui.match.views.VAntes$AntePanel.<init>(VAntes.java:183)
at forge.gui.match.views.VAntes.addAnteCard(VAntes.java:133)
at forge.game.GameNew.actuateGame(GameNew.java:312)

Re: Bug Reports (snapshot builds)

PostPosted: 21 Feb 2013, 04:29
by myk
I checked in a quick fix to the ImageCache error just to get things working again, but I did not go through to grok all of its implications. Max, could you review r19799 and revert/modify it as necessary?

Re: Bug Reports (snapshot builds)

PostPosted: 21 Feb 2013, 07:21
by Sloth
friarsol wrote:I don't think we should be crashing if a card doesn't have Oracle text. During spoiler season we often have cards without Oracle text.

Code: Select all
Deathlace has no Oracle text
java.lang.NullPointerException
   at forge.item.CardDb$CardSorter.addNewCard(CardDb.java:425)
This line causes a lot of spam when i start Forge:

Code: Select all
if ( StringUtils.isBlank( oracleText ) ) System.err.println(name + " has no Oracle text");
All vanilla creatures have a blank oracle text.