Collectible Card Game Headquarters

You fix is fair, thanks, myk.
I've never seen a component to request that small images, though.

sol, ok, you may proceed without Oracle, but the red messages in console will remind you to add the texts anyway.
Your exception is unrelated to Oracle texts. You haven't included the new card in any sets. That's why you crashed here:

Code: Select all

CardPrinted lastAdded = null;
for (final Entry<String, CardInSet> s : card.getSetsPrinted()) {
    lastAdded = this.addToLists(card, cardName, s);
}
if ( lastAdded.getRules().isTraditional() )

Whenever i use "Setup Game State" i get this error:

| Open

java.lang.NullPointerException
at forge.ImageCache.scaleImage(ImageCache.java:91)
at forge.ImageCache.getImage(ImageCache.java:58)
at forge.view.arcane.CardPanel.setCard(CardPanel.java:656)
at forge.view.arcane.CardPanel$1.componentResized(CardPanel.java:173)
at java.awt.Component.processComponentEvent(Unknown Source)

@Sloth: 19808

Hi, i found a bug with Bramblewood Paragon:

When i put a token elf warrior onto the battlefield, the counter +1/+1 not placed on the token.

Sorry my english

Max mtg wrote:sol, ok, you may proceed without Oracle, but the red messages in console will remind you to add the texts anyway.
Your exception is unrelated to Oracle texts. You haven't included the new card in any sets. That's why you crashed here:

Well, the error message told me I didn't have Oracle text, so it's not surprising I thought that. Anyway, I don't think we should crash if there aren't any sets listed either, for the same reasons as above, during spoiler season all of the cards will not have any SetInfo to grab yet.

friarsol wrote:

Max mtg wrote:sol, ok, you may proceed without Oracle, but the red messages in console will remind you to add the texts anyway.
Your exception is unrelated to Oracle texts. You haven't included the new card in any sets. That's why you crashed here:

Well, the error message told me I didn't have Oracle text, so it's not surprising I thought that. Anyway, I don't think we should crash if there aren't any sets listed either, for the same reasons as above, during spoiler season all of the cards will not have any SetInfo to grab yet.

Cards without set won't get registered in the CardDb. CardPrinted is 'name+set+artindex+foil' - won't be created without set.
I can make Forge proceed without crashing, but the card will be unaccessible then.

During the spoiler season you know what set you are implementing, and you may provide just any rarity (besides, it's also known at the moment you get a spoiler), the missing picture won't lead to crashes. Let me know if it does.
So I see no problem at all in the SetInfo being a required field

Max mtg wrote:During the spoiler season you know what set you are implementing, and you may provide just any rarity (besides, it's also known at the moment you get a spoiler), the missing picture won't lead to crashes. Let me know if it does.
So I see no problem at all in the SetInfo being a required field

This seems hacky. We have an automated script to generate all of the SetInfo to exactly what it should be, if we're now requiring people to fill this information in (opposite to what we've been telling them in the past) there will be mistakes and cards will be listed incorrectly with the wrong Rarity, etc. Couldn't we just have an Unknown set fallback if no SetInfo is given?

It seems like a hassle to me that I can't just create a simple card script to test some functionality (as I was doing with Deathlace) but now have to either manually add Set lines, or run the scripts before I can test things.

Max mtg wrote:

friarsol wrote:

Max mtg wrote:sol, ok, you may proceed without Oracle, but the red messages in console will remind you to add the texts anyway.
Your exception is unrelated to Oracle texts. You haven't included the new card in any sets. That's why you crashed here:

Well, the error message told me I didn't have Oracle text, so it's not surprising I thought that. Anyway, I don't think we should crash if there aren't any sets listed either, for the same reasons as above, during spoiler season all of the cards will not have any SetInfo to grab yet.

Cards without set won't get registered in the CardDb. CardPrinted is 'name+set+artindex+foil' - won't be created without set.
I can make Forge proceed without crashing, but the card will be unaccessible then.

During the spoiler season you know what set you are implementing, and you may provide just any rarity (besides, it's also known at the moment you get a spoiler), the missing picture won't lead to crashes. Let me know if it does.
So I see no problem at all in the SetInfo being a required field

If the HQ url is missing it crashes. You can put in a dummy link like the setInfoScript used to do, but when the correct links are finally available then the python script won't work because it thinks it already has the set info. Maybe the reprint script will work though.

moomarc wrote:If the HQ url is missing it crashes. You can put in a dummy link like the setInfoScript used to do, but when the correct links are finally available then the python script won't work because it thinks it already has the set info. Maybe the reprint script will work though.

Right that's why I said it's hacky. I have to create fake info now, just to clear it out and rerun it later.

What is hacky about assigning the name of the upcoming edition (that you remember anyway) and just any rarity?
Does not the script check existing SetInfos?
It should check them, because some references to pictures on magiccards.info are already outdated (see any flip card, ex: akki_lavarunner_tok_tok_volcano_born.txt )


Looks like Forge used to deal somehow with incomplete scripts, probably by auto-assigning some bogus set. Implemented in r19810.

Thx, Marc, that was a real issue: r19811

Max mtg wrote:What is hacky about assigning the name of the upcoming edition (that you remember anyway) and just any rarity?
Does not the script check existing SetInfos?
It should check them, because some references to pictures on magiccards.info are already outdated (see any flip card, ex: akki_lavarunner_tok_tok_volcano_born.txt )

It doesn't check the SetInfo if the card already has some sets listed. Otherwise we'd be trying to hit magiccards.info 12000+ times in short order everytime the script would run.

I don't believe flip cards are handled by SetInfoScript, so that just proves my point that having scriptors hardcode this info will lead to issues.

We should probably consider whether we should still even be adding the magiccards.info URL at all. That is from when we did HQ downloads, but we haven't had that functionality for some time now. The users that want HQ pics grab them directly from the Pictures forum. Everyone else uses the LQ images from Wizards or the LQ set images we host on CardForge.org. As things stand, those links serve no purpose. If we plan to reinstate a "Download HQ Set Images" button, then keep it. Otherwise I reckon we should scrap it.

moomarc wrote:We should probably consider whether we should still even be adding the magiccards.info URL at all. That is from when we did HQ downloads, but we haven't had that functionality for some time now. The users that want HQ pics grab them directly from the Pictures forum. Everyone else uses the LQ images from Wizards or the LQ set images we host on CardForge.org. As things stand, those links serve no purpose.

That's probably true, and we could get rid of the picture link but we still need to get that data from somewhere. I've looked into using mtgdata.txt for that data (since we used it for some other related stuff), but magiccards.info is up with the new cards a few days before prerelease, whereas mtgdata.txt wasn't out and stable until a few weeks after prerelease.

friarsol wrote:

moomarc wrote:We should probably consider whether we should still even be adding the magiccards.info URL at all. That is from when we did HQ downloads, but we haven't had that functionality for some time now. The users that want HQ pics grab them directly from the Pictures forum. Everyone else uses the LQ images from Wizards or the LQ set images we host on CardForge.org. As things stand, those links serve no purpose.

That's probably true, and we could get rid of the picture link but we still need to get that data from somewhere. I've looked into using mtgdata.txt for that data (since we used it for some other related stuff), but magiccards.info is up with the new cards a few days before prerelease, whereas mtgdata.txt wasn't out and stable until a few weeks after prerelease.

The Picture line is still necessary as that handles the LQ non-set downloads and tends to be the first thing up (magicinfo appears to do the same thing and just grabs their initial low res images from Gatherer or http://www.wizards.com/global/images/magic/general/...). So it is just the magiccards.info URL unused at the moment. We could slowly start doing the same and host both set and non-set images on CardForge. We can upload a new set whenever it becomes available on gatherer. Seems an unnecessary step though unless we want to avoid Forge downloads hitting WotC.

moomarc wrote:The Picture line is still necessary as that handles the LQ non-set downloads and tends to be the first thing up

You misunderstood, I was just agreeing that the last portion of the SetInfo could be nuked.