myk wrote:friarsol wrote:I see the card back image. I can't see/find out whatever the original creature was.
Fixed in r20668. It's correct that double-sided cards cannot be flipped "face down", right?
That's not a good implementation, myk.
You see, the extra parameter you've added came to every sentence in the method
http://svn.slightlymagic.net/websvn/dif ... &peg=20668.
And you had to add another overload, and developers will have to think which method they should call and what to pass as extra parameter.
When you have to add extra parameters (that handle some uncommon special cases) to classes that provide core functionality, it's a true sign that you are following a dangerous path of ending up with spaghetti code.
It would be much easier to have face-down cards use same mechanism as flippables do.
Unfortunatelly I have already done so, and you won't have a chance to implement it. (20669)
Now player may either move mouse to CPicture and press the flip button there, or move mouse over card with SHIFT pressed to see a different side of a card when it's avaliable
Posted: 29 Mar 2013, 17:11