Collectible Card Game Headquarters

hey guys its bugs i found
Garruk Wildspeaker dont add counters
Heartless Summoning don't get -1/-1
Mind's Desire exile the cards but cant play

Hey Max, looks like the Sideboard crash is fixed, but the OK button gaining focus after declaring attackers doesn't seem to be (I think you suggested you put something in for it?). Thanks

Oh, if you guys are in there fiddling with UI, I know this has been reported as part of a crash but I haven't seen it on its own: the "end of turn" button only passes priority up to the end of combat phase, not through the full turn.

Almeida wrote:hey guys its bugs i found
Garruk Wildspeaker dont add counters
Heartless Summoning don't get -1/-1

I can't reproduce either of these. Are they still happening? You'll need to provide more information.

@Almeida, you must be using a daily build for April, 3rd. Yesterday's (or today's - depends on your timezone) build should not have that problems with Garruk and Summoning (I've tested on current SVN build - works fine)
Mind's Desire - storm worked, exiled 7 cards, but I could play only one out of them (via that lighning icon). Scripting problem, I think.

@Sol, InputAttack - I changed it in r20775, but it does not help

I have 3 issues to solve:
1. Concurrent redraw of playarea while some effect changes card's propeties... results in comodification exception. viewtopic.php?p=114632#p114632
2. Some UI stuff is done outside of EDT thread. Will have to plant a lot of asserts throughout the code to catch java.lang.ClassCastException at javax.swing.LayoutComparator.compare - viewtopic.php?p=114589#p114589
3. User actions being routed to an input that already has been used.

friarsol wrote:

Almeida wrote:hey guys its bugs i found
Garruk Wildspeaker dont add counters
Heartless Summoning don't get -1/-1

I can't reproduce either of these. Are they still happening? You'll need to provide more information.

garruk is fixed
heartless is fixed
Mind's Desire i cast with 20 spells and the storm trigger but i can't cast the spells exiled unless the last spells

Max mtg wrote:@Almeida, you must be using a daily build for April, 3rd. Yesterday's (or today's - depends on your timezone) build should not have that problems with Garruk and Summoning (I've tested on current SVN build - works fine)
Mind's Desire - storm worked, exiled 7 cards, but I could play only one out of them (via that lighning icon). Scripting problem, I think.

@Sol, InputAttack - I changed it in r20775, but it does not help

I have 3 issues to solve:
1. Concurrent redraw of playarea while some effect changes card's propeties... results in comodification exception. viewtopic.php?p=114632#p114632
2. Some UI stuff is done outside of EDT thread. Will have to plant a lot of asserts throughout the code to catch java.lang.ClassCastException at javax.swing.LayoutComparator.compare - viewtopic.php?p=114589#p114589
3. User actions being routed to an input that already has been used.

i know use lightning icon but only last spell appears

Max mtg wrote:Mind's Desire - storm worked, exiled 7 cards, but I could play only one out of them (via that lighning icon). Scripting problem, I think.

I think I see the issue. Looks like it might be in CopySpellAbility not changing the Source Card for all SubAbilities of a SA. If that's the case I'll have a fix in a bit.

Edit: Yep that was it. The first SpellAbility was remembering to a different card than the Pump SubAbility had access to. Anyway, fixed now.

Do we know if LKI Cards "lock in" StaticEffects that are affecting it when they are created? I'm trying to convert Grindstone to script, but it doesn't seem to understand the Painter's Servant combo, which would lead me to believe that may not be the case.

Commited a fix (r20803) for pt.2 of my list above - See if similiar crashes have ceased to occur: (Goblin Guide-related one from viewtopic.php?p=114589#p114589)

When using the ability of Geth, Lord of the Vault X gets calculated based on the target, but after paying you're again asked to pay an amount for X (although it doesn't seem to affect anything whether you pay or not).

moomarc wrote:When using the ability of Geth, Lord of the Vault X gets calculated based on the target, but after paying you're again asked to pay an amount for X (although it doesn't seem to affect anything whether you pay or not).

r20816 - That's an easy and simple fix

Adding the ChangeTargets of Counterspells bug here as a reminder:

MagicStack is popping the SA during the resolve instead of during finishResolving. This means you can't target the ChangeTargets SA with the Counterspell below it on the Stack.

Also, I noticed that it lists the CounterSpell in the potential targets which is wrong (a spell can never target itself), and I also noticed the Stack targeting isn't quite right either in this case.

1) Cast a creature.
2) Cast Divination
3) Cast Counterspell countering the creature
4) Cast Swerve targeting Counterspell

When Swerve resolves, you can choose all three spells on the stack. It looks like when we are peeking at the instances of the SAs, the targets that were previously reset are restored due to this action.

All cards with RepeatEach effect don't work for me

swordshine wrote:All cards with RepeatEach effect don't work for me

I've just tested Winds of Change and it worked fine.