Collectible Card Game Headquarters

friarsol wrote:r21433

CopyPermanent does not fire static ETB abilities.

1. Bring a Spike Feeder into play.
2. Cast Cackling Counterpart on it.
3. Watch as nothing seems to happen.

I just noticed this with Prime Speaker Zegana not ETB with counters when testing Momir Basic stuff, but the above is an easier repro.

Hmm, The reason for this bug looks simple. While the copy token gets moved to the battlefield, it is still "nowhere" or in "null", so it doesn't get included in Player.getAllCards() (I forget the exact name) that's used to round up all cards to look for replacement effects in. I'll take a look tomorrow if noone beats me to it.

EDIT: Done in r21442

I'm going to Unburial Rites a very old issue here, forgive me. This one has a bit of history, and several users and devs had different behavior on their ends, so not everyone might be experiencing this. The problem at the time was that we couldn't get any of the devs to reproduce this, so I'd really appreciate confirmation from at least one other person for whom this is true.

Only one image is used per basic land per game on the human side unless the "randomize card art" option is checked (it isn't the same image every game, however.) If that option is checked, basic lands will use all the images from one set (other cards will draw from multiple sets in which they appear.)

This first cropped up around 12.9, as a fix for an issue where all lands from a set would be used *except* for the very first. Some users experienced this after that fix, some did not. The theory floated at the time was that it had something to do with using HQ images, although I've tested with both LQ and HQ images and have the exact same behavior (at the time, and again with today's daily.)

Anyway, I imagine that the expected behavior should be that without "randomize card art" checked all the island/etc. images from one set should be seen in play, and if the option is checked then a random assortment of mountains/etc. from across all sets should be displayed.

Just to confirm, this has been present at all times for me since 12.10. I'm bringing it up now in part because Xitax posted a 32-bit compatible version of his set-assignment tool for decklists which mostly negates the issue for me (and brought it to mind,) and because I repro'ed it with LQ images earlier in the day (I do this occasionally to check if anything has changed.)

Description: Clicking on the Quest Duel button

UncheckedExecutionException | Open

Code: Select all

Forge Version:    1.3.15-r21351
Operating System: Windows XP 5.1 x86
Java Version:     1.7.0_21 Oracle Corporation

com.google.common.util.concurrent.UncheckedExecutionException: java.awt.color.CMMException: Invalid image format
   at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2258)
   at com.google.common.cache.LocalCache.get(LocalCache.java:3990)
   at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3994)
   at com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4878)
   at forge.ImageCache.getImage(ImageCache.java:202)
   at forge.ImageCache.scaleImage(ImageCache.java:152)
   at forge.ImageCache.getIcon(ImageCache.java:131)
   at forge.gui.home.quest.PnlEvent.<init>(PnlEvent.java:53)
   at forge.gui.home.quest.CSubmenuDuels.update(CSubmenuDuels.java:119)
   at forge.gui.home.CHomeUI.itemClick(CHomeUI.java:40)
   at forge.gui.home.LblMenuItem$1.mousePressed(LblMenuItem.java:50)
   at java.awt.Component.processMouseEvent(Unknown Source)
   at javax.swing.JComponent.processMouseEvent(Unknown Source)
   at java.awt.Component.processEvent(Unknown Source)
   at java.awt.Container.processEvent(Unknown Source)
   at java.awt.Component.dispatchEventImpl(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Window.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$200(Unknown Source)
   at java.awt.EventQueue$3.run(Unknown Source)
   at java.awt.EventQueue$3.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
   at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue$4.run(Unknown Source)
   at java.awt.EventQueue$4.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)
Caused by: java.awt.color.CMMException: Invalid image format
   at sun.java2d.cmm.kcms.CMM.checkStatus(Unknown Source)
   at sun.java2d.cmm.kcms.CMM.createTransform(Unknown Source)
   at java.awt.image.ColorConvertOp.filter(Unknown Source)
   at com.sun.imageio.plugins.jpeg.JPEGImageReader.acceptPixels(Unknown Source)
   at com.sun.imageio.plugins.jpeg.JPEGImageReader.readImage(Native Method)
   at com.sun.imageio.plugins.jpeg.JPEGImageReader.readInternal(Unknown Source)
   at com.sun.imageio.plugins.jpeg.JPEGImageReader.read(Unknown Source)
   at javax.imageio.ImageIO.read(Unknown Source)
   at javax.imageio.ImageIO.read(Unknown Source)
   at forge.ImageLoader._findFile(ImageLoader.java:88)
   at forge.ImageLoader.load(ImageLoader.java:52)
   at forge.ImageLoader.load(ImageLoader.java:1)
   at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3589)
   at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2374)
   at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2337)
   at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2252)
   ... 41 more


Diogenes wrote:The AI played a Tablet of the Guilds, resulting in the following NPE when it had to choose colors:

Code: Select all

Forge Version:    1.3.16-SNAPSHOT-r21419

java.lang.NullPointerException at forge.game.ai.ComputerUtilCard.getColorByProminence(ComputerUtilCard.java:835)


Fixed by 21441

Hi, about Sylvan Library, if I got a Dark Confidant out the additional card it gives me also appear as drawn with Sylvan Library (I can choose between the one from Dark Confidant, the one from my draw step and two more from Sylvan Library, wich is not true as Dark Confidant doesn't draw cards.)

I couldn't use Conjurer's Closet ability on Master of the Pearl Trident which I took to an opponent with Overtaker . I do not know if it is a bug.

Conjurer's closet : At the beginning of your end step, you may exile target creature you control, then return that card to the battlefield, under your control.

Planechase related: Very frequently when you planeswalk away from a plane, it won't be removed from the command zone. The game continues with players having access to both planes and their abilities, until planeswalk is rolled on the planar die (of either plane). At that point, three planeswalking triggers will go on the stack and the game will crash.

The following crash was recorded without using rigged rolls (just lots and lots of mana - it took me 19 rolls to get the first planeswalk.)

UnsupportedOperationException | Open

Code: Select all

Forge Version:    1.3.16-SNAPSHOT-r21467
Operating System: Windows Vista 6.0 x86
Java Version:     1.7.0_21 Oracle Corporation

java.lang.UnsupportedOperationException
   at java.util.AbstractList.remove(Unknown Source)
   at java.util.AbstractList$Itr.remove(Unknown Source)
   at java.util.AbstractList.removeRange(Unknown Source)
   at java.util.AbstractList.clear(Unknown Source)
   at forge.game.player.Player.leaveCurrentPlane(Player.java:2998)
   at forge.card.ability.effects.PlaneswalkEffect.resolve(PlaneswalkEffect.java:29)
   at forge.card.spellability.AbilitySub.resolve(AbilitySub.java:130)
   at forge.card.ability.AbilityUtils.resolveApiAbility(AbilityUtils.java:1055)
   at forge.card.ability.AbilityUtils.resolve(AbilityUtils.java:1034)
   at forge.game.ai.ComputerUtil.playNoStack(ComputerUtil.java:314)
   at forge.card.trigger.WrappedAbility.resolve(WrappedAbility.java:372)
   at forge.card.ability.AbilityUtils.resolveApiAbility(AbilityUtils.java:1055)
   at forge.card.ability.AbilityUtils.resolve(AbilityUtils.java:1034)
   at forge.game.zone.MagicStack.resolveStack(MagicStack.java:617)
   at forge.game.phase.PhaseHandler$1.run(PhaseHandler.java:746)
   at forge.game.phase.PhaseHandler.passPriority(PhaseHandler.java:754)
   at forge.game.player.PlayerController.passPriority(PlayerController.java:82)
   at forge.game.ai.AiController.onPriorityRecieved(AiController.java:830)
   at forge.game.ai.AiInputCommon$1.run(AiInputCommon.java:74)
   at forge.FThreads$1.run(FThreads.java:115)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)


This next crash is very similar, but it occurred while planeswalking away from Bant with only one plane in play. I did use a rigged roll.

UnsupportedOperationException | Open

Code: Select all

Forge Version:    1.3.16-SNAPSHOT-r21467
Operating System: Windows Vista 6.0 x86
Java Version:     1.7.0_21 Oracle Corporation

java.lang.UnsupportedOperationException
   at java.util.AbstractList.remove(Unknown Source)
   at java.util.AbstractList$Itr.remove(Unknown Source)
   at java.util.AbstractList.removeRange(Unknown Source)
   at java.util.AbstractList.clear(Unknown Source)
   at forge.game.player.Player.leaveCurrentPlane(Player.java:2998)
   at forge.card.ability.effects.PlaneswalkEffect.resolve(PlaneswalkEffect.java:29)
   at forge.card.spellability.AbilitySub.resolve(AbilitySub.java:130)
   at forge.card.ability.AbilityUtils.resolveApiAbility(AbilityUtils.java:1055)
   at forge.card.ability.AbilityUtils.resolve(AbilityUtils.java:1034)
   at forge.card.spellability.HumanPlaySpellAbility.fillRequirements(HumanPlaySpellAbility.java:107)
   at forge.game.player.HumanPlay.playSpellAbilityNoStack(HumanPlay.java:217)
   at forge.card.trigger.WrappedAbility.resolve(WrappedAbility.java:367)
   at forge.card.ability.AbilityUtils.resolveApiAbility(AbilityUtils.java:1055)
   at forge.card.ability.AbilityUtils.resolve(AbilityUtils.java:1034)
   at forge.game.zone.MagicStack.resolveStack(MagicStack.java:617)
   at forge.game.phase.PhaseHandler$1.run(PhaseHandler.java:746)
   at forge.game.phase.PhaseHandler.passPriority(PhaseHandler.java:754)
   at forge.game.player.PlayerController.passPriority(PlayerController.java:82)
   at forge.game.ai.AiController.onPriorityRecieved(AiController.java:830)
   at forge.game.ai.AiInputCommon$1.run(AiInputCommon.java:74)
   at forge.FThreads$1.run(FThreads.java:115)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)


Sorry for the double-post, but this is a completely distinct issue.

I just realized that the card-detail text is generated from the scripted abilities on cards, and is not using the Oracle text field in the card's file. This means that certain cards display "Unblockable" and "Indestructible" as keyworded abilities (they are not keywords,) rather than the proper "X is unblockable" or "X is indestructible", while others do not. On a minor aesthetic note, older-set or coreset creatures with landwalk appear under a search for "unblockable" in the deck editor, which does not appear anywhere in their details (Oracle retains reminder text for these cards.)

Is there a reason not to use the Oracle text in the card detail field? I feel it would be superior to the current system.

[Edit:] Here's as good a place as any to bring up a UI issue, I guess. There was talk over in the feature requests thread to make the AI's spell casting more obvious. I think the number one reason I don't realize the AI is doing something is because I have my stack and combat tabs sharing a pane, and the UI doesn't return focus to the stack when the AI does anything during combat - I only realize when I attempt to pass to the next step, only to see that the step-tracker hasn't advanced (and I have allowed the AI's action resolve without having responded.) Can it be changed so that focus returns to the stack tab when anything goes on the stack?

On a related note, I've been hunting down a bug where the AI can play spells during its untap step (between turns, no step is highlighted on the track.) I also believe I've seen abilities auto-resolve, I think when the AI puts multiple on the stack during untap, but I haven't been able to repro this (it's too easy to pass priority habitually from CU to UP.) Just figure I'd mention this in case I never find repro steps.

Description: AI used cycling on Rejuvenate.
This crash seems to happen when AI used cycling (verified with other cards) on my turn.

NullPointerException | Open

Code: Select all

Forge Version:    1.3.16-SNAPSHOT-r21467
Operating System: Windows XP 5.1 x86
Java Version:     1.7.0_21 Oracle Corporation

java.lang.NullPointerException
   at forge.card.trigger.TriggerSpellAbilityCast.performTest(TriggerSpellAbilityCast.java:58)
   at forge.card.trigger.TriggerHandler.runSingleTrigger(TriggerHandler.java:328)
   at forge.card.trigger.TriggerHandler.runWaitingTrigger(TriggerHandler.java:252)
   at forge.card.trigger.TriggerHandler.runWaitingTriggers(TriggerHandler.java:193)
   at forge.game.zone.MagicStack.unfreezeStack(MagicStack.java:200)
   at forge.game.zone.MagicStack.addAndUnfreeze(MagicStack.java:183)
   at forge.game.ai.ComputerUtil.handlePlayingSpellAbility(ComputerUtil.java:115)
   at forge.game.ai.AiController.playSpellAbilities(AiController.java:878)
   at forge.game.ai.AiController.onPriorityRecieved(AiController.java:826)
   at forge.game.ai.AiInputCommon$1.run(AiInputCommon.java:74)
   at forge.FThreads$1.run(FThreads.java:115)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)


If you play modes like constructed or vanguard and select some decks/colours and hover over the selected deck option (for example "Custom User deck" it will reset selected deck or colour (which is annoying if you switch tabs in vanguard).

I can confirm that the AI will cast spells during its untap step. As no one's supposed to get priority, it resolves immediately and you can't respond. Simple steps to repro: give AI a Doom Blade in hand and enough mana sources in play to cast it, making sure they're tapped. Give yourself a nonblack creature. Pass the turn.

Another weird bug: whenever I use any Deathrite Shaman ability, AI gets the benefit (I haven't tried against multiple opponents; not sure what would happen). Interestingly, the stack description correctly says who will gain/lose life or add mana. I've checked, and it doesn't matter whose cards are exiled.

Both r21481.

slowe wrote:Another weird bug: whenever I use any Deathrite Shaman ability, AI gets the benefit (I haven't tried against multiple opponents; not sure what would happen). Interestingly, the stack description correctly says who will gain/lose life or add mana. I've checked, and it doesn't matter whose cards are exiled.

@Max: It looks like you've removed the activatingPlayer variable of SpellAbilityStackInstances in r21468. How should the game know who activated the spell or ability later?

Description: Modular artifact creature dies without any other creatures or artifacts in play.

IllegalArgumentException | Open

Code: Select all

Forge Version:    1.3.15-SNAPSHOT-r21296
Operating System: Mac OS X 10.8.3 x86_64
Java Version:     1.6.0_45 Apple Inc.

java.lang.IllegalArgumentException: Min must not be greater than Max
   at forge.control.input.InputSelectManyBase.<init>(InputSelectManyBase.java:30)
   at forge.control.input.InputSelectCards.<init>(InputSelectCards.java:10)
   at forge.control.input.InputSelectCardsFromList.<init>(InputSelectCardsFromList.java:13)
   at forge.card.cardfactory.CardFactoryUtil$23.run(CardFactoryUtil.java:3220)
   at forge.card.spellability.AbilityTriggered.resolve(AbilityTriggered.java:112)
   at forge.card.spellability.AbilityTriggered.run(AbilityTriggered.java:122)
   at forge.Card.executeTrigger(Card.java:2869)
   at forge.game.GameAction.sacrificeDestroy(GameAction.java:1359)
   at forge.game.GameAction.destroyNoRegeneration(GameAction.java:1289)
   at forge.game.GameAction.destroy(GameAction.java:1218)
   at forge.game.GameAction.checkStateEffects(GameAction.java:1028)
   at forge.game.zone.MagicStack.finishResolving(MagicStack.java:737)
   at forge.card.ability.AbilityUtils.resolveSubAbilities(AbilityUtils.java:1048)
   at forge.card.ability.AbilityUtils.resolveApiAbility(AbilityUtils.java:1066)
   at forge.card.ability.AbilityUtils.resolve(AbilityUtils.java:1039)
   at forge.game.zone.MagicStack.resolveStack(MagicStack.java:615)
   at forge.game.phase.PhaseHandler$1.run(PhaseHandler.java:743)
   at forge.game.phase.PhaseHandler.passPriority(PhaseHandler.java:751)
   at forge.game.player.PlayerController.passPriority(PlayerController.java:83)
   at forge.control.input.InputBase$1.run(InputBase.java:78)
   at forge.FThreads$1.run(FThreads.java:113)
   at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
   at java.lang.Thread.run(Thread.java:680)


Diogenes wrote:Is there a reason not to use the Oracle text in the card detail field? I feel it would be superior to the current system.

It took me a few minutes to realize that this is probably done so that the UI properly reflects when a creature loses abilities. Since this is legitimately useful, I guess the only bug is that indestructible and unblockable appear as keywords - but I'd still like to be able to read the original Oracle text somehow.

Would it be possible to change the appearance of these two to "CARDNAME is unblockable" and "CARDNAME is indestructible" in the card details, and also make hovering over or clicking on the card detail panel display the card's unmodified Oracle text?

Description: Restarted the game using Karn Liberated's ability. Modular artifacts were added to the battlefield including an Arcbound Crusher which get's +1+1 for all the artifacts now added to the battlefield from Karn's exile. Then this happened.
(Apparently my post looks too spamy with off-site URLs. So I removed some details which may have resembled a url. Buggy forum.)

Forge Version: 1.3.15-SNAPSHOT-r21296
Operating System: Mac OS X 10.8.3 x86_64
Java Version: 1.6.0_45 Apple Inc.

RuntimeException: Trying to unlock input which is not locked! Do check when your threads terminate!
at forge-control-input-InputControl-unlock(InputControl-java:208)