Collectible Card Game Headquarters

Agetian wrote:

Bog Wraith wrote:r29619
Cast a Banefire for 3x at a Precursor Golem destroying it. Both tokens should have gone with it but as you can see, the Precursor Golem is in the graveyard while the two tokens survive on the battlefield. I should have been able to attack with a clean board on my opponents side. It looks like the 3 damage was applied to the Precursor Golem which is id'd as #271, all 3 times instead of having the other 2 times being targeted at the tokens.

Fixed (r29624). The fix is a bit radical, let me know if there are any issues.

- Agetian

Ok, I will keep an eye on the interaction of Precursor Golem with the different removal/damage spells that I can hurl at it. Thanks!

I played a creature with Llanowar Reborn on the battlefield. Opponent killed it. I tried to answer the Graft prompt with "yes" and the counter was removed from Llanowar Reborn, which is incorrect -- moving counters has some fairly strict guidelines and if the counter can't be put on the destination card for whatever reason, than it can't be removed from the source card either.

Marek14 wrote:I played a creature with Llanowar Reborn on the battlefield. Opponent killed it. I tried to answer the Graft prompt with "yes" and the counter was removed from Llanowar Reborn, which is incorrect -- moving counters has some fairly strict guidelines and if the counter can't be put on the destination card for whatever reason, than it can't be removed from the source card either.

Not sure how to fix this one, pushed it to the tracker for now. Does anyone have an idea how to correct this?

- Agetian

Agetian wrote:Not sure how to fix this one, pushed it to the tracker for now. Does anyone have an idea how to correct this?

Seems related to the Animate Dead issue from a week or two ago. The card the getDefinedCards returns is actually the current card state, and the CountersMoveEffect doesn't check a) if the card is the same timestamped version of the one it expects. (i.e. not necessarily the current state of the card) and b) if that card is in the "expected" zone, in general this for MoveCounters this is going to be the Battlefield.

This might be a scenario where Triggers need to differentiate, whether or not you need the current state of the triggered card, or the actual card that triggered.

Agetian wrote:

Bog Wraith wrote:r29619
Cast a Banefire for 3x at a Precursor Golem destroying it. Both tokens should have gone with it but as you can see, the Precursor Golem is in the graveyard while the two tokens survive on the battlefield. I should have been able to attack with a clean board on my opponents side. It looks like the 3 damage was applied to the Precursor Golem which is id'd as #271, all 3 times instead of having the other 2 times being targeted at the tokens.

Fixed (r29624). The fix is a bit radical, let me know if there are any issues.

- Agetian

This seems to be working with most cards. The only exception I found so far is the -X/-X from Profane Command.

@ Friarsol: Thanks a lot for the clarification and for the fix!

About the issue mentioned by Excessum (with Profane Command not being copied by Precursor Golem even if it's the only card targeted): this is interesting - I'm working on it and there seem to be two related issues: one is that TriggerSpellAbilityCast doesn't always count the number of targeted objects correctly (it can count the same target twice if the same object is targeted by two different subabilities), and even if that part is remedied, then AB CopySpellAbility only copies the first part of the spell but not the subabilities (e.g. if Profane Command is cast in the "-X/-X" and "gains Fear" mode, then only the "-X/-X" part is copied). Still looking into it...

EDIT: Tried to fix this in r29653. This should take care of both of the issues above for the most part. However, there is still at least one remaining issue that I was unable to fix - Radiate does not even detect the possibility of copying a one-target Profane Command for some reason, and its code path does not go through any of the target number detection branches that I've found. I tried trapping some other code but the breakpoints did not hit. Any ideas where it might be acquiring the (wrong) target number information from?

- Agetian

r29657: I tried to fix the Profane Command/other similar spells being copyable by Radiate, however, my fix may be too permissive and may have unwanted side effects. If you think it's going to cause problems with some cases, please let me know.

- Agetian

r29659

AI bounced my Deep-Sea Kraken after it was cast via Suspend. Now it appears I'm unable to re-cast or re-suspend it.

friarsol wrote:r29659

AI bounced my Deep-Sea Kraken after it was cast via Suspend. Now it appears I'm unable to re-cast or re-suspend it.

Seems true for any bounced creature cast via Suspend... Sadly, haven't found the cause for it yet.
EDIT: Pushed it to bug tracker and seems like I found the issue, investigating.

EDIT 2: After several hours of experimentation all I was able to achieve was implement a hacky workaround that works but that pollutes the code... (r29662). The problem is - suspend-cast bounced cards do not set the zone correctly somewhere deep in the code such that they end up being in the hand but they're treated as if they were on the battlefield. That's why the checkZoneRestrictions check in SpellAbilityRestriction.java fails and the card becomes uncastable. The only way I've found to make it work is to change the zone of the original (uncopied) card in ChangeZone early, in that case it's later processed correctly. I tried experimenting with the various view-updating functions (updateStateForView, updating the zone for view, etc.) but none of that helped. Moreover, if the suspend-cast card does *not* get copied inside ChangeZone at all (e.g. if I route if through the simple "copied = c" code path), then Unsummon doesn't work on it at all (?), the spell resolves but the card is not returned to hand. I'm baffled as to why this code behaves so strangely with suspend-cast bounced cards in particular, but if anyone is good with this area of code, please help!

- Agetian

When flood counters from Quicksilver Fountain are removed, the lands stop being Islands, but they retain the ability to tap for blue mana.

Marek14 wrote:When flood counters from Quicksilver Fountain are removed, the lands stop being Islands, but they retain the ability to tap for blue mana.

This appears to be a visual glitch (if you tap e.g. a Forest after the flood counters are removed it taps for green, but the card detail box says it taps for blue), looks like a missed updateStateForView call or something like that... if anybody knows where this should be updated, please assist.

- Agetian

I was investigating a bug report that indicated that Stolen Goods did not work correctly (did not allow the player to cast the card without paying its mana cost). In trying to fix it I revealed a rather big issue in the code that I'm not sure what to make of or how to fix.

Some cards that make you able to cast spells from cards owned by your opponent work using the MayPlay/MayPlayWithoutManaCost mechanism (which works but has a couple visual glitches - in particular, the ability is not visually cleared from the card after it stops being active; also, if you're able to cast a spell without paying its mana cost, you're also allowed to choose an option to cast it and pay its mana cost - this is probably incorrect). Some other cards try to make it work by adding a hidden keyword to the card, for example "May be played by opponent without paying its mana cost". While there are a couple references to these hidden keywords in the code, they're not hooked to anything that may allow them to work (for instance, they do not participate in checking for zone restrictions or for activator restrictions for spells). Therefore, they literally do nothing, and any card that currently depends on them does not work.

Is the MayPlay/MayPlayWithoutManaCost mechanism "newer" than the keywords? Was it supposed to replace it? Or were the keywords a part of the code that someone started and did not finish / that got broken later?... At any rate, I'm not sure what to do with these cards. I converted a couple of them to MayPlay/MayPlayWithoutManaCost (see r29676), and visual glitches aside, that at least makes them functional. If you have an idea how this *should* be implemented / what should be done, your assistance is highly welcome!

Will also track this on the bug tracker as Issue 19.

- Agetian

still problems with status checking when sacrificing creatures,
it should check the last known status while it was on the battlefield.

===

Creature equipped with Mortarpod and soulbond to Nightshade Peddler got sacrificed by the effect of Mortarpod.

The damage should be deadly because of Deathtouch but its not.
---
might be related to my problem with Savra, Queen of the Golgari
and sacrificing a non-green/non-black creature while controlling Painter's Servant (and changing the color to green or black)

---

happens for Ashmouth Hound with Basilisk Collar too.
I attack, enemy blocks but before the damage effect resolves Ashmouth Hound is send to hand, but it had deathtouch while it was on the field

The ability of Rekindled Flame should be optional.

March of the Machines + Mycosynth Lattice combo doesn't work if the former came first.