Page 321 of 487

Re: Bug Reports (snapshot builds)

PostPosted: 16 Jan 2016, 12:55
by Agetian
Searing Light, Goblin Freerunner, Dread Defiler, Fall of the Titans and Kozilek's Return are fixed as of r30681. The deck editor issue with {C} cards is fixed in r30682.

- Agetian

Re: Bug Reports (snapshot builds)

PostPosted: 16 Jan 2016, 16:31
by matrix4767
r30683:
Oath of Gideon doesn't make planeswalkers enter the battlefield with another loyalty counter on them.

Re: Bug Reports (snapshot builds)

PostPosted: 16 Jan 2016, 18:17
by Agetian
matrix4767 wrote:r30683:
Oath of Gideon doesn't make planeswalkers enter the battlefield with another loyalty counter on them.
Oath of Gideon is fixed (r30684).

The following issues are best fixed by someone else, I couldn't figure out how to fix them:
tjtillman wrote:r30676
Gameplay Bugs:
-Deceiver of Form doesn't work correctly - Never have the option to either make other creatures a copy of the revealed card, nor have the option to have the revealed card placed on bottom of library
-Kalitas, Traitor of Ghet zombie trigger didn't trigger off an opponent's land creature dying

AI:
-Holdout Settlement default is to tap a creature instead of colorless when a specific color isn't needed (not a bug, but would be nice to default to colorless when a color isn't needed)
-CPU always chooses not to create a land creature on Landfall from Embodiment of Insight and Embodiment of Fury
-CPU always chooses not to create a land creature when Wall of Resurgence enters the battlefield
-CPU always chooses not to create a land creature when Cyclone Sire dies
As far as Deceiver of Form goes, there's a misnamed SVar (CopyAll instead of DBCopyAll), but correcting it still fails to make the card work properly - in particular, the card copying ability doesn't work at all + the user is prompted whether he wants to reveal the card or not (something that shouldn't be optional) but is not prompted as to whether he wants to make other creatures copies (something that should be optional).

- Agetian

Re: Bug Reports (snapshot builds)

PostPosted: 16 Jan 2016, 18:50
by friarsol
I've already been looking at the AI payment for Holdout Settlement (it's in my list in the other thread). I'm not really familiar with the code, so its slow debugging plus I don't have a lot of time to look at things. I'm still trying to find the right place that sorts the mana abilities on a card when the AI is considering them. That seems to be the spot that needs updating. Anyone happen to know where that is?

Re: Bug Reports (snapshot builds)

PostPosted: 17 Jan 2016, 03:10
by Bog Wraith
Make a Stand when cast, asks for 1 Red mana instead of 1 White & 2 generic mana.

I reset the board state by bringing in cards to play & to my hand to facilitate the bug after the game in question was completed.

Re: Bug Reports (snapshot builds)

PostPosted: 17 Jan 2016, 03:22
by friarsol
Bog Wraith wrote:Make a Stand when cast, asks for 1 Red mana instead of 1 White & 2 generic mana.
Fixed.

-Holdout Settlement default is to tap a creature instead of colorless when a specific color isn't needed (not a bug, but would be nice to default to colorless when a color isn't needed)
Ok, this appears to be working the way it should again. Still not exactly sure why it stopped working, but now we're explicitly sorting the mana abilities on a single card.

Re: Bug Reports (snapshot builds)

PostPosted: 17 Jan 2016, 05:55
by jje4th
Description: Unhandled exception when trying to cast Consuming Sinkhole with another effect on the stack. (life loss from visions of brutality)

[spoiler=RuntimeException][code]
Forge Version: SVN
Operating System: Windows 8.1 6.3 amd64
Java Version: 1.8.0_11 Oracle Corporation

RuntimeException: AbilityFactory : getAbility -- no API in Consuming Sinkhole:
at forge.game.ability.AbilityFactory.getAbility(AbilityFactory.java:106)

[had to trim the stack so I could post - the board thought the stack was offsite URLs]

Re: Bug Reports (snapshot builds)

PostPosted: 18 Jan 2016, 03:03
by Bog Wraith
Yet another crash with a Shared Fate in play & using the same deck list as I posted earlier in this thread. This time, I was attempting to cast the A.I.'s Selesnya Charm from exile when this crash happened. I clicked on the card in exile when this crash report was generated:


RuntimeException | Open
Code: Select all
Forge Version:    1.5.48-SNAPSHOT-r30688
Operating System: Mac OS X 10.10.5 x86_64
Java Version:     1.8.0_66 Oracle Corporation

java.lang.RuntimeException: AbilityFactory : getAbility -- no API in :
   at forge.game.ability.AbilityFactory.getAbility(AbilityFactory.java:106)
   at forge.game.ability.effects.CharmEffect.makePossibleOptions(CharmEffect.java:39)
   at forge.player.PlayerControllerHuman.chooseModeForAbility(PlayerControllerHuman.java:1086)
   at forge.game.ability.effects.CharmEffect.makeChoices(CharmEffect.java:82)
   at forge.player.HumanPlay.playSpellAbility(HumanPlay.java:101)
   at forge.player.PlayerControllerHuman.playChosenSpellAbility(PlayerControllerHuman.java:938)
   at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:957)
   at forge.game.GameAction.startGame(GameAction.java:1479)
   at forge.game.Match.startGame(Match.java:96)
   at forge.match.HostedMatch$2.run(HostedMatch.java:220)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
   at java.lang.Thread.run(Thread.java:745)

Re: Bug Reports (snapshot builds)

PostPosted: 18 Jan 2016, 03:25
by friarsol
Bog Wraith wrote:Yet another crash with a Shared Fate in play & using the same deck list as I posted earlier in this thread. This time, I was attempting to cast the A.I.'s Selesnya Charm from exile when this crash happened. I clicked on the card in exile when this crash report was generated:
Yea the error was suggesting it was a Charm spell. Just haven't had an opportunity to look into it with OGW being released and the colorless mana hiccups. I think it's just an issue where the card isn't set to the faceup side fast enough before the Charm decision is attempting to be made. So you get a Charm decision for a face down card, which... doesn't have any.

Re: Bug Reports (snapshot builds)

PostPosted: 18 Jan 2016, 03:30
by Bog Wraith
Ok, I was just about to post another crash, this time using r30695. It's the same type, this time with Azorius Charm.

After what I just read from you, it's not necessary for me to post it. I'll wait until a fix is posted & if you can leave a comment in this thread letting us know it is ok to try again.

Re: Bug Reports (snapshot builds)

PostPosted: 18 Jan 2016, 05:59
by bink
Description: [As soon as all 3 urza lands are in play the games crashes whenever mana must be paid.]

NumberFormatException | Open
Code: Select all
Forge Version:    1.5.48-SNAPSHOT-r30696
Operating System: Windows Vista 6.0 x86
Java Version:     1.8.0_60 Oracle Corporation

java.lang.NumberFormatException: For input string: "C"
   at java.lang.NumberFormatException.forInputString(Unknown Source)
   at java.lang.Integer.parseInt(Unknown Source)
   at java.lang.Integer.parseInt(Unknown Source)
   at forge.game.GameActionUtil.generatedMana(GameActionUtil.java:554)
   at forge.ai.ComputerUtilMana.payManaCost(ComputerUtilMana.java:366)
   at forge.ai.ComputerUtilMana.canPayManaCost(ComputerUtilMana.java:51)
   at forge.match.input.InputPayMana$4.evaluate(InputPayMana.java:403)
   at forge.match.input.InputPayMana$4.evaluate(InputPayMana.java:400)
   at forge.util.Evaluator.run(Evaluator.java:8)
   at forge.game.player.Player.runWithController(Player.java:2457)
   at forge.match.input.InputPayMana.runAsAi(InputPayMana.java:359)
   at forge.match.input.InputPayMana.updateMessage(InputPayMana.java:406)
   at forge.match.input.InputPayMana$5.run(InputPayMana.java:432)
   at forge.GuiDesktop.invokeInEdtNow(GuiDesktop.java:72)
   at forge.FThreads.invokeInEdtNowOrLater(FThreads.java:30)
   at forge.match.input.InputPayMana.onStateChanged(InputPayMana.java:429)
   at forge.match.input.InputPayMana.showMessage(InputPayMana.java:420)
   at forge.match.input.InputBase.showMessageInitial(InputBase.java:75)
   at forge.match.input.InputProxy$1.run(InputProxy.java:73)
   at java.awt.event.InvocationEvent.dispatch(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$500(Unknown Source)
   at java.awt.EventQueue$3.run(Unknown Source)
   at java.awt.EventQueue$3.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)

Re: Bug Reports (snapshot builds)

PostPosted: 18 Jan 2016, 10:08
by matrix4767
r30697: Deceiver of Form still doesn't ask if you want to put the revealed card on the bottom of your library.

Re: Bug Reports (snapshot builds)

PostPosted: 18 Jan 2016, 13:12
by friarsol
matrix4767 wrote:r30697: Deceiver of Form still doesn't ask if you want to put the revealed card on the bottom of your library.
And that's why you shouldn't test cards while holding a little one. Should be an easy enough fix.

Another note for myself is that colorless (as in color) comparisons are still a little broken due to the tweaks for colorless mana. The simplest way to check this is to start a new quest and you'll end up with 0 colorless cards.

Re: Bug Reports (snapshot builds)

PostPosted: 18 Jan 2016, 17:06
by tjtillman
r30697

Gameplay:
-Sweep Away - When played on an attacking creature it just bounces the creature to opponent's hand, not top of library as it should.


AI:
-Harvester Troll - So it seems there is some algorithm for the CPU to choose whether to sacrifice a creature or a land to get the 2 counters. However, whatever that is, if there are too few lands and Harvester Troll enters the battlefield as the CPU's only creature, it will sacrifice itself to get the 2 counters rather than a land or not do it at all.

-Support mechanic - When the CPU has an opportunity to support 2 or more creatures it will only support 1 creature.


Thanks for all your great work guys!

Re: Bug Reports (snapshot builds)

PostPosted: 18 Jan 2016, 20:18
by Agetian
tjtillman wrote:-Sweep Away - When played on an attacking creature it just bounces the creature to opponent's hand, not top of library as it should.
This issue is fixed (r30698).

- Agetian