Collectible Card Game Headquarters

r30701:
Linvala, the Preserver doesn't check if you have less life than your opponent, even if you do.

matrix4767 wrote:r30701:
Linvala, the Preserver doesn't check if you have less life than your opponent, even if you do.

Fixed (r30702).

- Agetian

r307202:
Auto mana cost payment doesn't recognize if there are {C} producing lands on the battlefield.
Sometimes, if you try to cast anything with {C} in its mana cost and try to tap a Wastes, it won't work. Other times, it works normally.
You'll have to tap the land first, then pay the cost.

In addition to matrix4767's report I can add that both the auto-payment for cards with {C} in their cost and the ability of the AI to play the said cards are definitely broken again. I tried some simple debugging but couldn't come up with the conclusion as to what exactly is broken this time. Perhaps it has something to do with the changes implemented in r30699, like something was not yet adapted to this change?.. At any rate, help in fixing these issues is welcome.

- Agetian

Agetian wrote:In addition to matrix4767's report I can add that both the auto-payment for cards with {C} in their cost and the ability of the AI to play the said cards are definitely broken again. I tried some simple debugging but couldn't come up with the conclusion as to what exactly is broken this time. Perhaps it has something to do with the changes implemented in r30699, like something was not yet adapted to this change?.. At any rate, help in fixing these issues is welcome.

- Agetian

Not too surprising since AI and autopayment are the same codepath. Colors and mana were way too intertwined and needed to be separated, probably just a few spots that were going a different route that I missed. Since Colorless as a card "color" now means something completely different than Colorless as a Mana type. And Forge assumed it was the same in lots of places.

friarsol wrote:Not too surprising since AI and autopayment are the same codepath. Colors and mana were way too intertwined and needed to be separated, probably just a few spots that were going a different route that I missed. Since Colorless as a card "color" now means something completely different than Colorless as a Mana type. And Forge assumed it was the same in lots of places.

Ok, I got the auto-payment/AI issue sorted out, my solution looks a bit hacky, maybe there's a better way of doing it (please take a look when you have a second).
I can't figure out what's wrong with the payment input for Wastes though (when you can't tap Wastes to pay for {C} during the mana payment). Here's a reproducible case:

Let's say you have Wastes and four Mountains. In your hand you have Walker of the Wastes. You click the Walker in your main phase and get prompted to pay its mana cost. If you pay {C} first (tap Wastes) and then pay with all four Mountains, there is no problem. However, if you pay first (tapping four Mountains), then the game will not let you tap Wastes to pay for the {C} part, it'll just blink the prompt as if the payment is illegal. Note that clicking "Auto" to pay the remaining part will work (since r30703).

- Agetian

Agetian wrote:Ok, I got the auto-payment/AI issue sorted out, my solution looks a bit hacky, maybe there's a better way of doing it (please take a look when you have a second).
I can't figure out what's wrong with the payment input for Wastes though (when you can't tap Wastes to pay for {C} during the mana payment). Here's a reproducible case:

Let's say you have Wastes and four Mountains. In your hand you have Walker of the Wastes. You click the Walker in your main phase and get prompted to pay its mana cost. If you pay {C} first (tap Wastes) and then pay with all four Mountains, there is no problem. However, if you pay first (tapping four Mountains), then the game will not let you tap Wastes to pay for the {C} part, it'll just blink the prompt as if the payment is illegal. Note that clicking "Auto" to pay the remaining part will work (since r30703).

- Agetian

I had a fix just committed that's a bit more robust than yours and also fixes your issue with the input payment in that scenario.

Nice, thanks for help, Sol!

- Agetian

Hopefully that's all the spots missing, but there may be a few more hiding in weird corner cases. I missed this one because it was a different function being called than I was expecting mattering, but pretty much anything MagicColor is used, but we actually care about Mana we should probably be using a Mana-named function just in case Colorless can come out of it.

friarsol wrote:Hopefully that's all the spots missing, but there may be a few more hiding in weird corner cases. I missed this one because it was a different function being called than I was expecting mattering, but pretty much anything MagicColor is used, but we actually care about Mana we should probably be using a Mana-named function just in case Colorless can come out of it.

I had noticed that cards containing {C} in their mana cost were being filtered out in CardManagers (like Deck Editor) when you filtered down to only colorless cards. Has that been fixed as well?

drdev wrote:I had noticed that cards containing {C} in their mana cost were being filtered out in CardManagers (like Deck Editor) when you filtered down to only colorless cards. Has that been fixed as well?

I think Agetian fixed that one last night. Seems to be working in the latest.

Agetian wrote:

matrix4767 wrote:r30701:
Linvala, the Preserver doesn't check if you have less life than your opponent, even if you do.

Fixed (r30702).

- Agetian

FYI, this fix isnt 100% correct since it ignores the intervening if aspect of Linvala 2.0. It should work in most cases, but it'd be better to get it working with the Conditional on the trigger itself so it gets checked twice.

friarsol wrote:

Agetian wrote:

matrix4767 wrote:r30701:
Linvala, the Preserver doesn't check if you have less life than your opponent, even if you do.

Fixed (r30702).

- Agetian

FYI, this fix isnt 100% correct since it ignores the intervening if aspect of Linvala 2.0. It should work in most cases, but it'd be better to get it working with the Conditional on the trigger itself so it gets checked twice.

Tbh I'm not very well-versed in the trigger-related code, so I'm probably not the best guy to take a look at this... It looks like the conditional code is not implemented for the triggers at all (or something like that) 'cause it doesn't look like it gets checked at all. Do you know how to get this implemented properly?..

- Agetian

Enemy does have Nyxborn Rollicker and two Okk.

i attack with 5 creatures, all of them does have Menace because of Firemantle Mage and enemy does block one of them with only his Nyxborn Rollicker but he should not be able to.

Hanmac wrote:Enemy does have Nyxborn Rollicker and two Okk.

i attack with 5 creatures, all of them does have Menace because of Firemantle Mage and enemy does block one of them with only his Nyxborn Rollicker but he should not be able to.

What version is this? I checked on the latest snapshot and Nyxborn Rollicker can't block by itself, thus Menace works as it should.
Are you sure Firemantle Mage's Rally activated that turn?