Collectible Card Game Headquarters

r31149:
Blood Tyrant is wrong, it should have been AFLifeLost, currently the life gain is hard coded.
also Urborg Syphon-Mage has Player.Opponent but should have Player.Other, because it does hit team mates.

Hanmac wrote:r31149:
Blood Tyrant is wrong, it should have been AFLifeLost, currently the life gain is hard coded.
also Urborg Syphon-Mage has Player.Opponent but should have Player.Other, because it does hit team mates.

Fixed (r31152).

- Agetian

Description: [In a commander game, AI 1 is attacking AI 2 after AI3 and Human lost]

ConcurrentModificationException | Open

Code: Select all

Forge Version:    1.5.52-SNAPSHOT-r31152
Operating System: Windows 7 6.1 x64
Java Version:     1.8.0_45 Oracle Corporation

java.util.ConcurrentModificationException
   at java.util.HashMap$HashIterator.nextNode(Unknown Source)
   at java.util.HashMap$ValueIterator.next(Unknown Source)
   at java.util.AbstractCollection.addAll(Unknown Source)
   at java.util.HashSet.<init>(Unknown Source)
   at forge.game.combat.CombatView.getDefenders(CombatView.java:69)
   at forge.screens.match.controllers.CCombat.getCombatDescription(CCombat.java:66)
   at forge.screens.match.controllers.CCombat.update(CCombat.java:53)
   at forge.screens.match.CMatchUI.showCombat(CMatchUI.java:370)
   at forge.control.FControlGameEventHandler$1.run(FControlGameEventHandler.java:89)
   at java.awt.event.InvocationEvent.dispatch(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$500(Unknown Source)
   at java.awt.EventQueue$3.run(Unknown Source)
   at java.awt.EventQueue$3.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)


forge-gui-desktop-1.5.52-SNAPSHOT-31145

Playing a commander game I cast Blue Sun's Zenith for 2 during round 15. During round 19 Narset, Enlightened Master exiles Blue Sun's Zenith and I cast it from exile to have in shuffled into my library. At this point it's for some reason cast with x=2. I have seen this happening a few times. So far it seems to me that if I have cast Blue Sun's Zenith before it will be cast from exile with x equal to the previous value of x not zero as it's my impression it should be.

r31154:

Pyromancer's Goggles fixed with r31155 | Open

Pyromancer's Goggles did miss the DBCleanup SVar.

Harness the Storm does not allow to cast spells with overload cost or other alternate costs.

Brain in the Jar fixed with r31156 | Open

Brain in the Jar does does not work with the Srcy X ability.
it always does "Scry 0".
hm might have "ChosenX" instead of "XChoice" does not work, but the first ability does need "References$ Y"

(What do i need to do to get write access to the svn?)

Champion ability fixed by r31157 | Open

Edit:

still something is wrong with the Champion ability,
for example with Lighting Crafter:

first i play a Shaman(1)
then i play Lightning Crafter(2) Champion the first Shaman(1)
then i play Lightning Crafter(3) Champion the first Lightning Crafter(2)
because of that Shaman(1) returns
then i destroy/exile both creatures
(no creatures left)
now Lightning Crafter(2) returns and want to Champion something, i say yes so that it does try to search the field, don't find anything but does not sacrifice itself like it should.

i think it might be a missing CleanUp and adding it to returnChampion
in CardFactoryUtil.java line 2337 and following:

Code: Select all

String returnChampion = "DB$ ChangeZone | Defined$ Remembered | Origin$ Exile | Destination$ Battlefield | SubAbility$ ChampionCleanup";
card.setSVar("ChampionCleanup", "DB$ Cleanup | ClearRemembered$ True");

Edit:
Exquisite Firecraft: first has the Spell Mastery Section doubled while in the game. and Second i did try to use it to deal damage to Arlinn, Embraced by the Moon while she was in her Moon State, but i couldn't do it. i don't know why.

r31156
Kalitas, Traitor of Ghet
When he exist the battlefield, should put the zombie token at the case of death at the same time.

r31158
When Double-Faced Cards on the back face state was baunced by Reflector Mage, It can't play the card by front face until next turn.
It shoud be able to play because they are another name.

Maybe I have reported, I can't redirect non combat damage to planeswalkers of Magic Origin yet.
(ex. Jace, Telepath Unbound)

stormcat, yeah i noticed too, it does happen for Arlinn, Embraced by the Moon 's Nightform too.

stormcat wrote:Maybe I have reported, I can't redirect non combat damage to planeswalkers of Magic Origin yet.
(ex. Jace, Telepath Unbound)

I tried fixing it sometime back, but couldn't get it to work. I think the PW redirection system just needs an overhaul.

thanks for looking at the redirection system, even if you are not manage to fix it yet.

r31160: casting Avacyn's Judgment for its madness cost, copy it with Pyromancer's Goggles should make a copy which does have copied Madness and X too. but currently it does not.

===
also i need to investigate Pyromancer's Goggles more, because i got it a few times that it does copy a spell twice which should not happen.

===
r31160:
i noticed for Confront the Unknown but it might happen for other cards,
it does say: "put (1) 0/0 Clue token onto the battlefield", imo it should say "Investigate".

hm while fixing that, the TokenEffect#getStackDescription maybe should not add power/toughness into the description when the token is not a creature.

===
defending Goblin Chirurgeon causes StackOverflowError when i attack with many creatures with Trample

Code: Select all

   at forge.ai.ComputerUtilCombat.canDestroyBlockerBeforeFirstStrike(ComputerUtilCombat.java:1775)
   at forge.ai.ComputerUtilCombat.shieldDamage(ComputerUtilCombat.java:613)
   at forge.ai.ComputerUtilCombat.totalShieldDamage(ComputerUtilCombat.java:592)
   at forge.ai.ComputerUtilCombat.lifeThatWouldRemain(ComputerUtilCombat.java:289)
   at forge.ai.ComputerUtilCombat.lifeInSeriousDanger(ComputerUtilCombat.java:453)
   at forge.ai.ComputerUtil.getCardPreference(ComputerUtil.java:326)
   at forge.ai.ComputerUtilCost.checkSacrificeCost(ComputerUtilCost.java:261)
   at forge.ai.ComputerUtilCost.checkSacrificeCost(ComputerUtilCost.java:314)
   at forge.ai.ComputerUtil.canRegenerate(ComputerUtil.java:652)



===
31162:
for now Declaration in Stone might work like that, but other trigger that may react to investigate might not like that. (currently they only have for the first time)

but without DBRepeat, DBCleanup does need to be added to DBInvestigate.

r31162
I played triggered ability of Kozilek's Return, destroy all creatures including Archangel Avacyn.
Curious to say, transforming of Avacyn triggered and resolved in next upkeep.
And Avacyn has been put graveyard remain back face.

Hanmac wrote:31162:
for now Declaration in Stone might work like that, but other trigger that may react to investigate might not like that. (currently they only have for the first time)

but without DBRepeat, DBCleanup does need to be added to DBInvestigate.

Stop being so concerned about "what might be", we would drive ourselves crazy with that. The repeat there was wrong, my console out was spitting up an infinite loop when using it.

friarsol wrote:

Hanmac wrote:31162:
for now Declaration in Stone might work like that, but other trigger that may react to investigate might not like that. (currently they only have for the first time)

but without DBRepeat, DBCleanup does need to be added to DBInvestigate.

Stop being so concerned about "what might be", we would drive ourselves crazy with that. The repeat there was wrong, my console out was spitting up an infinite loop when using it.

that might be true, but it still does need some fix because in the current setting DBCleanup is not called from DBInvestigate, it does need "SubAbility$ DBCleanup"

Hanmac wrote:Stop being so concerned about "what might be", we would drive ourselves crazy with that. The repeat there was wrong, my console out was spitting up an infinite loop when using it.

that might be true, but it still does need some fix because in the current setting DBCleanup is not called from DBInvestigate, it does need "SubAbility$ DBCleanup"[/quote]
You have commit writes to fix all the small things like that if you like.