Collectible Card Game Headquarters

Hanmac wrote:i try to build newest r31196
because i wanted to fix some error with the Color CardView one some cards.

forge-core/src/main/java/forge/util/collect/FCollection.java:[335,38]
incompatible types: java.util.ArrayList<capture#1 of ? extends T> cannot be converted to java.util.List<T>

i don't know if its a error on forge or on my system ...

Doesn't happen to me. Must be a change you made.

I haven't any changes yet, but I want to add some Debug Code to Card Util.

I did upgrade my system, might be because of my Java version (my System has 8 as minimum)

friarsol wrote:Also, I wouldn't be afraid to ask, we were just trying to make sure you understood the rule correctly since you were being so adamant about it.

apologies, that came out as if i was blaming you, in fact i'm blaming myself. I'm just not used to these "free exploits" in magic. realizing there is an arbitrary exception in the rules has made me doubt said rules following a predictable pattern in that regard. for all i know there could be a clause stating that this is perfectly fine; that "planeswalkers gain loyalty whenever the +X ability is activated wether you intend to pay another card's tax or not"

VileTouch wrote:realizing there is an arbitrary exception in the rules has made me doubt said rules following a predictable pattern in that regard. for all i know there could be a clause stating that this is perfectly fine; that "planeswalkers gain loyalty whenever the +X ability is activated wether you intend to pay another card's tax or not"

If it were worded something like "Whenever an opponent activates a loyalty, counter that ability unless it's controller pays 2."

Here the whole ability is rolled back. Typically costs you can't undo are paid last, but there's some issues with cards like that not sorting costs properly before payment starts.

Hello all, with version 1.5.53 snapshot 31196
just in a game, the java process is tacking 13% of my proc juice... Why ?

r31203: Pious Evangel get sacrificed in his dark form Wayward Disciple.

Possible Reason: it does transform back into its day side in the graveyard, and then does search on the wrong side for the Ability.

Possible Fix: maybe if it somehow gets its LKI, that might fix the problem.
Another dirty fix would be to add the SVar-Ability of Wayward Disciple to Pious Evangel too.

java.lang.RuntimeException | Open

Code: Select all

Game-0 > java.lang.RuntimeException: AbilityFactory : getAbility -- no API in Pious Evangel:
   at forge.game.ability.AbilityFactory.getAbility(AbilityFactory.java:106)
   at forge.game.trigger.TriggerHandler.runSingleTrigger(TriggerHandler.java:495)
   at forge.game.trigger.TriggerHandler.runNonStaticTriggersForPlayer(TriggerHandler.java:366)
   at forge.game.trigger.TriggerHandler.runWaitingTrigger(TriggerHandler.java:326)
   at forge.game.trigger.TriggerHandler.runTrigger(TriggerHandler.java:263)
   at forge.game.GameAction.changeZone(GameAction.java:292)
   at forge.game.GameAction.moveTo(GameAction.java:450)
   at forge.game.GameAction.moveTo(GameAction.java:431)
   at forge.game.GameAction.moveToGraveyard(GameAction.java:527)
   at forge.game.GameAction.sacrificeDestroy(GameAction.java:1345)
   at forge.game.GameAction.sacrifice(GameAction.java:1229)
   at forge.game.cost.CostSacrifice.doPayment(CostSacrifice.java:120)
   at forge.game.cost.CostPartWithList.executePayment(CostPartWithList.java:96)
   at forge.game.cost.CostPartWithList.executePayment(CostPartWithList.java:109)
   at forge.game.cost.CostPartWithList.payAsDecided(CostPartWithList.java:134)
   at forge.game.cost.CostPayment.payCost(CostPayment.java:142)
   at forge.player.HumanPlaySpellAbility.playAbility(HumanPlaySpellAbility.java:114)
   at forge.player.HumanPlay.playSpellAbility(HumanPlay.java:132)
   at forge.player.PlayerControllerHuman.playChosenSpellAbility(PlayerControllerHuman.java:939)
   at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:958)
   at forge.game.GameAction.startGame(GameAction.java:1480)
   at forge.game.Match.startGame(Match.java:95)
   at forge.match.HostedMatch$2.run(HostedMatch.java:220)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
   at java.lang.Thread.run(Thread.java:745)


PS: i am currently fixing the problem with the Color, i fixed one part with adding a updateColors to CardView, but its not 100% fixed yet.

To show my problem: Pious Evangel // Wayward Disciple and other from SOI does show the wrong color in the CardView, for unknown reason it doesn't happen Civilized Scholar // Homicidal Brute

i tried to fix it my self, and it did work when it does transform on the battlefield by itself, but not when Pressing the Transform symbol on the CardView.

The Bug only does happen while in the game, not while doing it in the DeckEditor.

Description: Tried opening the game.

RuntimeException | Open

Code: Select all

Forge Version:    1.5.53-SNAPSHOT-r31205
Operating System: Windows 8.1 6.3 amd64
Java Version:     1.8.0_51 Oracle Corporation

java.lang.RuntimeException: java.io.EOFException: Unexpected end of ZLIB input stream
   at forge.quest.io.QuestDataIO.loadData(QuestDataIO.java:138)
   at forge.control.FControl.initialize(FControl.java:233)
   at forge.view.Main.main(Main.java:51)
Caused by: java.io.EOFException: Unexpected end of ZLIB input stream
   at java.util.zip.InflaterInputStream.fill(Unknown Source)
   at java.util.zip.InflaterInputStream.read(Unknown Source)
   at java.util.zip.GZIPInputStream.read(Unknown Source)
   at sun.nio.cs.StreamDecoder.readBytes(Unknown Source)
   at sun.nio.cs.StreamDecoder.implRead(Unknown Source)
   at sun.nio.cs.StreamDecoder.read(Unknown Source)
   at java.io.InputStreamReader.read(Unknown Source)
   at java.io.Reader.read(Unknown Source)
   at forge.quest.io.QuestDataIO.loadData(QuestDataIO.java:112)
   ... 2 more


Hi,

The card "Burn From Within" from SOI is marked as an instant, but it should be a sorcery.

Thanks

r31221

I had The Gitrong Monster out and I activated Sinister Concoction. The milled card was a land, and I discarded a land, and the result was I drew 2 cards. Since these are one action (payment of an activated ability's cost) shouldn't I only draw one card? (Gitrog: Whenever one or more...)

Also, any possibility on Briarbridge Patrol?

r31222

AI issue. Bound by Moonsilver (Can't transform) enchants Thraben Gargoyle, but as soon as CPU got to six mana, it paid the cost. It correctly didn't transform, but CPU wastes its mana this way.

tjtillman wrote:r31221

I had The Gitrong Monster out and I activated Sinister Concoction. The milled card was a land, and I discarded a land, and the result was I drew 2 cards. Since these are one action (payment of an activated ability's cost) shouldn't I only draw one card? (Gitrog: Whenever one or more...)

We looked into it, a level 3 judge said each type of cost counts as a different action.

tjtillman wrote:r31221
Also, any possibility on Briarbridge Patrol?

As far as I'm aware, it still doesn't work with things like Chandra's Ignition:

Briarbridge Patrol | Open

Name:Briarbridge Patrol
ManaCost:3 G
Types:Creature Human Warrior
PT:3/3
# Two pronged handling of investigation portion
T:Mode$ DamageDone | ValidSource$ Card | CombatDamage$ False | ValidTarget$ Creature | TriggerZones$ Battlefield | OncePerEffect$ True | Execute$ TrigToken | TriggerDescription$ Whenever Briarbridge Patrol deals damage to one or more creatures, investigate. (Put a colorless Clue artifact token onto the battlefield with "2, Sacrifice this artifact: Draw a card.")
T:Mode$ DealtCombatDamageOnce | ValidSource$ Card.Self | ValidTarget$ Creature | Execute$ TrigToken | Secondary$ True | TriggerDescription$ Whenever Briarbridge Patrol deals damage to one or more creatures, investigate. (Put a colorless Clue artifact token onto the battlefield with "2, Sacrifice this artifact: Draw a card.")
SVar:TrigToken:DB$ Token | TokenAmount$ 1 | TokenName$ Clue | TokenTypes$ Artifact,Clue | TokenOwner$ You | TokenColors$ Colorless | TokenImage$ c clue | TokenAltImages$ c_clue2,c_clue3,c_clue4,c_clue5,c_clue6 | TokenAbilities$ ABDraw
SVar:ABDraw:AB$ Draw | Cost$ 2 Sac<1/CARDNAME> | NumCards$ 1 | SpellDescription$ Draw a card.

# Accumulating Clues no matter which zone the Patrol is in
T:Mode$ Sacrificed | ValidCard$ Clue.YouCtrl | Execute$ TrigResearching | Static$ True
SVar:TrigResearching:DB$ StoreSVar | SVar$ ClueResearch | Type$ CountSVar | Expression$ ClueResearch/Plus.1
T:Mode$ Phase | Phase$ Cleanup | Execute$ TrigReset | Static$ True
SVar:TrigReset:DB$ StoreSVar | SVar$ ClueResearch | Type$ Number | Expression$ 0
SVar:ClueResearch:Number$0

# Trigger on Accumulated Clues
T:Mode$ Phase | Phase$ End of Turn | TriggerZones$ Battlefield | CheckSVar$ ClueResearch | SVarCompare$ GE3 | Execute$ TrigCheatCreature | TriggerDescription$ At the beginning of each end step, if you sacrificed three or more Clues this turn, you may put a creature card from your hand onto the battlefield.
SVar:TrigCheatCreature:DB$ ChangeZone | Origin$ Hand | Destination$ Battlefield | ChangeType$ Creature | ChangeNum$ 1 | SpellDescription$ You may put a creature card from your hand onto the battlefield.

is pretty close though.

Something doesn't work quite right resolving The Great Aurora.

It seems to fail mostly when there are tokens on the battlefield. I've seen it with zombie tokens and clue tokens.

Player should draw as many cards as permanents on the battlefield plus cards in hand, but I've seen this come back as low as a single card.

Also, the lands I get to put into play upon resolution trigger landfall from Jaddi Offshoot, which I'm pretty sure isn't how things would play out irl. The Jaddi Offshoots would not be present to see the landfall triggers.

Thanks!

r31225:
i found the culprit for my problem with Pious Evangel get "sacrificed" in his dark form Wayward Disciple.
viewtopic.php?p=196785#p196785

i tested it a bit more and it does not crash when the Wayward Disciple dies from damage or other things, only Sacrifice is problematic when it does happen because of a cost.

another test with the release 1.5.52 does show that there the sacrifice still worked, so it's a change between 31186..31225

showing a diff in /forge-game/ reveals that the problem is @jje4th 's commit r31190 with the CostPaymentStack.

maybe someone with more mightier skills than I can fix that again.

Hanmac wrote:r31225:
i found the culprit for my problem with Pious Evangel get "sacrificed" in his dark form Wayward Disciple.
viewtopic.php?p=196785#p196785

i tested it a bit more and it does not crash when the Wayward Disciple dies from damage or other things, only Sacrifice is problematic when it does happen because of a cost.

Can you provide a set of exact repro steps? I couldn't get it to crash sac'ing Wayward Disciple to Angelic Purge to pay the sac cost.

I also tried sac'ing a Wayward Disciple to transform another Pious Evangel and that worked just fine too.