Page 345 of 487

Re: Bug Reports (snapshot builds)

PostPosted: 29 May 2016, 19:45
by Marek14
Got the mythic Hellbent achievement after winning with Felidar Sovereign. Seems the game cleared the game state before the achievement was checked.

Re: Bug Reports (snapshot builds)

PostPosted: 30 May 2016, 01:04
by Bog Wraith
Forge_1.5.53 r31248

Created a Cube for EMA as it's not yet implemented in the Block/Sets in draft.

I've included both the .dck & .draft files.

Error could be from the cube I made, but I can't find it.
It states that the cardpool has been depleted. I still have the 1 card available when I try to select it.

Ran a draft twice and each time when I got to select the last card in pack 2, this crash occurred:

IllegalStateException | Open
Code: Select all
Forge Version:    1.5.53-SNAPSHOT-r31248
Operating System: Mac OS X 10.10.5 x86_64
Java Version:     1.8.0_91 Oracle Corporation

java.lang.IllegalStateException: The cardpool has been depleted and has no more cards for slot Any
   at forge.card.UnOpenedProduct.getBoosterPack(UnOpenedProduct.java:70)
   at forge.card.UnOpenedProduct.get(UnOpenedProduct.java:61)
   at forge.card.UnOpenedProduct.get(UnOpenedProduct.java:17)
   at forge.limited.BoosterDraft.get8BoosterPack(BoosterDraft.java:264)
   at forge.limited.BoosterDraft.nextChoice(BoosterDraft.java:241)
   at forge.screens.deckeditor.controllers.CEditorDraftingProcess.onAddItems(CEditorDraftingProcess.java:106)
   at forge.screens.deckeditor.controllers.ACEditorBase.addItems(ACEditorBase.java:173)
   at forge.screens.deckeditor.CDeckEditorUI$1.move(CDeckEditorUI.java:173)
   at forge.screens.deckeditor.CDeckEditorUI.moveSelectedItems(CDeckEditorUI.java:164)
   at forge.screens.deckeditor.CDeckEditorUI.addSelectedCards(CDeckEditorUI.java:171)
   at forge.screens.deckeditor.CDeckEditorUI$5.run(CDeckEditorUI.java:237)
   at forge.itemmanager.ItemManager.activateSelectedItems(ItemManager.java:1210)
   at forge.itemmanager.views.ImageView$4.onLeftDoubleClick(ImageView.java:247)
   at forge.toolbox.FMouseAdapter.mousePressed(FMouseAdapter.java:147)
   at java.awt.Component.processMouseEvent(Component.java:6532)
   at javax.swing.JComponent.processMouseEvent(JComponent.java:3324)
   at java.awt.Component.processEvent(Component.java:6300)
   at java.awt.Container.processEvent(Container.java:2236)
   at java.awt.Component.dispatchEventImpl(Component.java:4891)
   at java.awt.Container.dispatchEventImpl(Container.java:2294)
   at java.awt.Component.dispatchEvent(Component.java:4713)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4888)
   at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4522)
   at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4466)
   at java.awt.Container.dispatchEventImpl(Container.java:2280)
   at java.awt.Window.dispatchEventImpl(Window.java:2750)
   at java.awt.Component.dispatchEvent(Component.java:4713)
   at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
   at java.awt.EventQueue.access$500(EventQueue.java:97)
   at java.awt.EventQueue$3.run(EventQueue.java:709)
   at java.awt.EventQueue$3.run(EventQueue.java:703)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
   at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
   at java.awt.EventQueue$4.run(EventQueue.java:731)
   at java.awt.EventQueue$4.run(EventQueue.java:729)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
   at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
   at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
   at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

Re: Bug Reports (snapshot builds)

PostPosted: 30 May 2016, 05:09
by Bog Wraith
Forge_1.5.53 r31248

Not a double post as I want this crash I had in Constructed Standard play documented in its own bug report.

Screenshot of board state at time of crash.

Playing with Seasons Past deck, as Nissa, Vastwood Seer was flipping to Nissa, Sage Animist, this crash occured:


RuntimeException | Open
Code: Select all
Forge Version:    1.5.53-SNAPSHOT-r31248
Operating System: Mac OS X 10.10.5 x86_64
Java Version:     1.8.0_91 Oracle Corporation

java.lang.RuntimeException: AbilityFactory : getAbility -- no API in Nissa, Vastwood Seer:
   at forge.game.ability.AbilityFactory.getAbility(AbilityFactory.java:106)
   at forge.game.replacement.ReplacementHandler.executeReplacement(ReplacementHandler.java:169)
   at forge.game.replacement.ReplacementHandler.run(ReplacementHandler.java:134)
   at forge.game.replacement.ReplacementHandler.run(ReplacementHandler.java:71)
   at forge.game.GameAction.changeZone(GameAction.java:221)
   at forge.game.GameAction.moveTo(GameAction.java:451)
   at forge.game.GameAction.moveTo(GameAction.java:432)
   at forge.game.ability.effects.ChangeZoneEffect.changeKnownOriginResolve(ChangeZoneEffect.java:534)
   at forge.game.ability.effects.ChangeZoneEffect.resolve(ChangeZoneEffect.java:350)
   at forge.game.spellability.AbilitySub.resolve(AbilitySub.java:119)
   at forge.game.ability.AbilityUtils.resolveApiAbility(AbilityUtils.java:1236)
   at forge.game.ability.AbilityUtils.resolveSubAbilities(AbilityUtils.java:1229)
   at forge.game.ability.AbilityUtils.resolveApiAbility(AbilityUtils.java:1243)
   at forge.game.ability.AbilityUtils.resolve(AbilityUtils.java:1218)
   at forge.player.HumanPlaySpellAbility.playAbility(HumanPlaySpellAbility.java:142)
   at forge.player.HumanPlay.playSpellAbilityNoStack(HumanPlay.java:239)
   at forge.player.PlayerControllerHuman.playSpellAbilityNoStack(PlayerControllerHuman.java:241)
   at forge.game.trigger.WrappedAbility.resolve(WrappedAbility.java:421)
   at forge.game.ability.AbilityUtils.resolveApiAbility(AbilityUtils.java:1236)
   at forge.game.ability.AbilityUtils.resolve(AbilityUtils.java:1218)
   at forge.game.zone.MagicStack.resolveStack(MagicStack.java:504)
   at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:1004)
   at forge.game.GameAction.startGame(GameAction.java:1481)
   at forge.game.Match.startGame(Match.java:95)
   at forge.match.HostedMatch$2.run(HostedMatch.java:220)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
   at java.lang.Thread.run(Thread.java:745)

Re: Bug Reports (snapshot builds)

PostPosted: 30 May 2016, 05:35
by Hanmac
@Bog Wraith: totally my fault, i seems to broke it while i try to fixed Arlinn Kord.
(it should have also fixed the other DFC Planeswalkers)
the Fix was about the Damage Redirection that the DFC Planeswalker does miss the buildPlaneswalkerAbilities, now i need to see why they does crash for the other ones.

i try to investigate whats wrong and try fix it.

Edit:
fixed in r31249. but i think the root of that problem is the ReplacementHandler with this todo:
Code: Select all
// TODO: the source of replacement effect should be the source of the original effect
===

i did investigate a bit with Altered Ego and Creatures with {X} cost.
Ruling Says:
4/8/2016: If the chosen creature has {X} in its mana cost, that X is considered to be 0. The value of X in Altered Ego’s last ability will be whatever value was chosen for X while casting Altered Ego.
the easier way would be somehow to reset XManaCostPaid while copying (i will test that out)

but while searching the Code for xPaid, i found in SpellAbilityStackInstance.
Code: Select all
// TODO getXManaCostPaid should be on the SA, not the Card
so maybe the more correct way would be to fix the XManaCostPaid in general and that might fix Altered Ego too.

Re: Bug Reports (snapshot builds)

PostPosted: 30 May 2016, 16:04
by Marek14
This bug has occurred twice so far, once with Anurid Brushhopper and once with AEtherling.

After the card is exiled and comes back, clicking on it just causes the Prompt window to flash, but has no other effect. AEtherling's abilities can't be activated and it can't be selected to attack (but, notably, it WILL attack if I use the Alpha strike option, showing that this is an interface problem, not problem with game rules).

Skizzik should be sacrificed at the end of any turn, not just yours. I cast Skizzik (unkicked) under Confusion in the Ranks, swapping it with opponent's creature, but it survives long enough to attack me next turn.

Re: Bug Reports (snapshot builds)

PostPosted: 30 May 2016, 16:28
by Hanmac
The bugs with exile and return might be connected to the fix I did for transformed cards. I will test them.

Edit: fixed in r31251, getCardState are only problematic for DoubleFaced.
i tested it and AEtherling works again.

==
About Skizzik it's not a bug, it's correct because you can't sacrifice a creature you don't control.

Re: Bug Reports (snapshot builds)

PostPosted: 30 May 2016, 18:04
by matrix4767
r31251
EMA is included in the sets, but manually adding card pictures in a EMA folder doesn't make them appear.

Re: Bug Reports (snapshot builds)

PostPosted: 30 May 2016, 20:10
by Hanmac
matrix4767 wrote:r31251
EMA is included in the sets, but manually adding card pictures in a EMA folder doesn't make them appear.
What images did you use and did you name them right?

PS @others: one card from EMA is missing but that's a flagbearer which might be a bit more complicated to implement.

Re: Bug Reports (snapshot builds)

PostPosted: 30 May 2016, 21:00
by matrix4767
Hanmac wrote:
matrix4767 wrote:r31251
EMA is included in the sets, but manually adding card pictures in a EMA folder doesn't make them appear.
What images did you use and did you name them right?

PS @others: one card from EMA is missing but that's a flagbearer which might be a bit more complicated to implement.
I tried to make Vampiric Tutor and Victimize appear (named Vampiric Tutor.full.jpg, as every other image file), but instead they use an image from an older set.
t
Edit: Disregard this "report", turns out I had another folder location left over from a previous installation. The images load fine now.

Re: Bug Reports (snapshot builds)

PostPosted: 31 May 2016, 02:22
by stormcat
Forge reveal cards of back to library in ability of Scroll Rack, but it need not.

Re: Bug Reports (snapshot builds)

PostPosted: 31 May 2016, 09:11
by Marek14
Hanmac wrote:About Skizzik it's not a bug, it's correct because you can't sacrifice a creature you don't control.
No, you are wrong. Sacrifice is not a delayed trigger, but an ability of Skizzik itself. This would only be an issue if control of Skizzik changed with the ability on stack, which is not what happened in this case. Besides, even if it couldn't be sacrificed, the ability should still at least trigger.

Re: Bug Reports (snapshot builds)

PostPosted: 31 May 2016, 11:02
by stormcat
If they are not continuous same name cards in a edition file, they are not loaded all cards.
I confirmed by Islands in Duel Decks Blessed vs. Cursed.
It include 6 Islands, but loaded 3.

Re: Bug Reports (snapshot builds)

PostPosted: 31 May 2016, 16:54
by Bog Wraith
Bog Wraith wrote:Forge_1.5.53 r31248

Created a Cube for EMA as it's not yet implemented in the Block/Sets in draft.

I've included both the .dck & .draft files.

Error could be from the cube I made, but I can't find it.
It states that the cardpool has been depleted. I still have the 1 card available when I try to select it.

Ran a draft twice and each time when I got to select the last card in pack 2, this crash occurred:

IllegalStateException | Open
Code: Select all
Forge Version:    1.5.53-SNAPSHOT-r31248
Operating System: Mac OS X 10.10.5 x86_64
Java Version:     1.8.0_91 Oracle Corporation

java.lang.IllegalStateException: The cardpool has been depleted and has no more cards for slot Any
   at forge.card.UnOpenedProduct.getBoosterPack(UnOpenedProduct.java:70)
   at forge.card.UnOpenedProduct.get(UnOpenedProduct.java:61)
   at forge.card.UnOpenedProduct.get(UnOpenedProduct.java:17)
   at forge.limited.BoosterDraft.get8BoosterPack(BoosterDraft.java:264)
   at forge.limited.BoosterDraft.nextChoice(BoosterDraft.java:241)
   at forge.screens.deckeditor.controllers.CEditorDraftingProcess.onAddItems(CEditorDraftingProcess.java:106)
   at forge.screens.deckeditor.controllers.ACEditorBase.addItems(ACEditorBase.java:173)
   at forge.screens.deckeditor.CDeckEditorUI$1.move(CDeckEditorUI.java:173)
   at forge.screens.deckeditor.CDeckEditorUI.moveSelectedItems(CDeckEditorUI.java:164)
   at forge.screens.deckeditor.CDeckEditorUI.addSelectedCards(CDeckEditorUI.java:171)
   at forge.screens.deckeditor.CDeckEditorUI$5.run(CDeckEditorUI.java:237)
   at forge.itemmanager.ItemManager.activateSelectedItems(ItemManager.java:1210)
   at forge.itemmanager.views.ImageView$4.onLeftDoubleClick(ImageView.java:247)
   at forge.toolbox.FMouseAdapter.mousePressed(FMouseAdapter.java:147)
   at java.awt.Component.processMouseEvent(Component.java:6532)
   at javax.swing.JComponent.processMouseEvent(JComponent.java:3324)
   at java.awt.Component.processEvent(Component.java:6300)
   at java.awt.Container.processEvent(Container.java:2236)
   at java.awt.Component.dispatchEventImpl(Component.java:4891)
   at java.awt.Container.dispatchEventImpl(Container.java:2294)
   at java.awt.Component.dispatchEvent(Component.java:4713)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4888)
   at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4522)
   at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4466)
   at java.awt.Container.dispatchEventImpl(Container.java:2280)
   at java.awt.Window.dispatchEventImpl(Window.java:2750)
   at java.awt.Component.dispatchEvent(Component.java:4713)
   at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
   at java.awt.EventQueue.access$500(EventQueue.java:97)
   at java.awt.EventQueue$3.run(EventQueue.java:709)
   at java.awt.EventQueue$3.run(EventQueue.java:703)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
   at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
   at java.awt.EventQueue$4.run(EventQueue.java:731)
   at java.awt.EventQueue$4.run(EventQueue.java:729)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
   at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
   at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
   at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)
For the life of me I can't understand why this cube I made causes Forge to crash! :?

I've tried it under a number of different versions of Forge that I have and it crashes every time! All the other custom cubes work including the ones I've made in the past. I've gone over both the .dck file & .draft file a number of times, but I can't find anything that points to the cause. I'm not a programmer, so I might be missing something, but I just can't see anything.

I'm guessing that it's got to be coming from one of the two files I generated, but Hell if I know what that error is!

Can someone take a look and see if this crash occurs for you as well & if so, if they can figure this out because I'm not sure if this will effect all other future cubes that I create.

Re: Bug Reports (snapshot builds)

PostPosted: 31 May 2016, 18:23
by Hanmac
@Bog wraith: I have no idea about draft but you can try to add EMA to boosterboxes.txt with 24 boosters. I don't know if that would help.
Currently to sleepy to fix anything.

Re: Bug Reports (snapshot builds)

PostPosted: 31 May 2016, 22:36
by Bog Wraith
Hanmac wrote:@Bog wraith: I have no idea about draft but you can try to add EMA to boosterboxes.txt with 24 boosters. I don't know if that would help.
Currently to sleepy to fix anything.
I didn't think it would work, but I tried it and I was right, it didn't work.

What I did instead & what I should have known what to do but forgot, was add this line to the "blocks.txt" file:

Eternal Masters, 3/6/SOI, EMA

It now shows up in the "Block/Set" option when choosing it under the "Choose Draft Format" window. I ran a draft and everything seems ok so far. I chose SOI as the source for the land cards.
It also works fine under the Sealed format & generates the typical 6 packs you get for a Sealed Deck pool of cards.

I'll keep testing it and report if there are any problems, but it looks very good right now! 8)