Collectible Card Game Headquarters

Hi,
I'm using Forge 1.5.52.

I got two bugs:
Shimian Specter - when shimian deals damage and the opponent has no cards in hand, the program alerts that there is no cards in opponent's hand, shows the library but doesn't shuffles the library after.

Felidar Sovereign - when you in the game with 40 or more life the game get stuck and/or crash.

Turns out Eternal Masters brought a few Oracle text changes:
http://yawgatog.com/resources/oracle-changes/soi-ema/

1. Some cards that allow to cast spells as though they had flash mentioned "cards". They are changed to "spells". This should not be a functional change, since things that create copies of cards (like Isochron Scepter) don't allow to cast them under normal timing anyway.
This change covers the following cards: Akoum, Alchemist's Refuge, Hypersonic Dragon, Leyline of Anticipation, Prophet of Kruphix, Rootwater Shaman, Shimmer Myr, Vedalken Orrery, Vernal Equinox, and Yeva, Nature's Herald.

2. Some cards that deal variable damage to target are reworded. This covers Corrupt, Goblin War Strike, Last Stand, and Torrent of Fire.

3. Phrase "in a turn" is replaced by "each turn". This covers Enigma Sphinx Avatar, Jetting Glasskite, Kira, Great Glass-Spinner, Shimmering Glasskite and Stensia.

4. Other changes:
Hamlet Captain - now affects "Humans" instead of "Human creatures". Not sure if that's functional, if noncreature permanents can get a +1/+1 bonus that will apply if they become creatures later in turn.

Iona's Blessing - adds "each combat" to extra block text.

Kaboom! - period replaced by comma.

Konda, Lord of Eiganjo - reordering abilities, losing reminder text for vigilance.

Mimic Vat - reworded for case where Mimic Vat has multiple exiled cards, though I'm not sure why.

Nature's Cloak - accidental extra "forestwalk" is removed.

Nightscape Battlemage - space removed; seems to be a bug.

North Star - changes "color" to "type", this seems to be a functional change, as you can now use colored mana to pay for colorless symbols in spells cast through North Star.

Personal Incarnation - reworded the activation condition.

Prey Upon - fight reminder text removed.

Sakashima's Student - removed "still".

Simic Guildmage - replaces "enchanting" with "attached to".

Spectral Shift - changes "effects" to "effect", twice.

Stormscape Battlemage - reminder text for kicker added.

Sword of Kaldra - gets reminder text that it can't exile creatures that are no longer on the battlefield.

Winter Orb - once again, Winter Orb doesn't limit untapping when it's tapped.

Marek14 wrote:Winter Orb - once again, Winter Orb doesn't limit untapping when it's tapped.

Of all the things Wizards messes with, this one has bothered me more than most.

friarsol wrote:

Bog Wraith wrote:With a Xantid Swarm attacking, AI cast Second Thoughts when they should not be able to cast any spells on my turn.

Was it in response to the trigger?

Meaning, did the AI cast after my creatures tapped to attack & before blockers or damage assigned? Yes it was before those steps.

So it means that the AI cast before the blocking phase is declared?

If so, I thought about that but wasn't sure about the timing , so I filled this as a bug report.

If all above is correct, then Xantid Swarm's usefulness has lessened greatly for me, & I'm playing with 2 of them in my latest Sealed EMA tournament that I'm in

Let me know Sol.

Bog Wraith wrote:

friarsol wrote:

Bog Wraith wrote:With a Xantid Swarm attacking, AI cast Second Thoughts when they should not be able to cast any spells on my turn.

Was it in response to the trigger?

Meaning, did the AI cast after my creatures tapped to attack & before blockers or damage assigned? Yes it was before those steps.

So it means that the AI cast before the blocking phase is declared?

If so, I thought about that but wasn't sure about the timing , so I filled this as a bug report.

If all above is correct, then Xantid Swarm's usefulness has lessened greatly for me, & I'm playing with 2 of them in my latest Sealed EMA tournament that I'm in

Let me know Sol.

Well in respose to the trigger as in:

1) You declare Xantid Swarm as an attacker
2) It sees itself as attacking, so it triggers its ability, being added to the stack.
3) In response to the trigger (while it's on the stack, before it resolves), the AI casts a spell.
4) AI spell resolves.
5) Xantid trigger resolves.
6) For the rest of the turn the AI can't cast spells.

That's all totally legit. The Swarm is really helpful in combo decks that want to shut off answers, in Main Phase 2.

The Origins Planeswalker seems to be broken again,
(might be broken when i try to fix the SOI DFC ones)
the problem is currently with Creature/Planeswalker cards
and missing svars, and the ReplacementTrigger was bound against the wrong card.
(the one in the ReplacementEffect was still pointing the the original state)

i added calls for game.getCardState into ReplacementHandler & AIController

r31290 should fix that problem. Please check that out if someone find another problem.

friarsol wrote:
Well in respose to the trigger as in:

1) You declare Xantid Swarm as an attacker
2) It sees itself as attacking, so it triggers its ability, being added to the stack.
3) In response to the trigger (while it's on the stack, before it resolves), the AI casts a spell.
4) AI spell resolves.
5) Xantid trigger resolves.
6) For the rest of the turn the AI can't cast spells.

That's all totally legit. The Swarm is really helpful in combo decks that want to shut off answers, in Main Phase 2.

Yep, that's the way I figured it after reading your "Was it in response to the trigger?" query to me.

Thanks as always Sol, I knew you'd straighten me out!

Not sure what happened here. I attempt to kill a Strangleroot Geist with Lightning Bolt, and opponent responds with Vines of Vastwood. Vines fizzles for no apparent reason, letting the Bolt through.

Only two creatures on the battlefield were two Strangleroot Geists, one with a +1/1 counter on it from previous Undying trigger. No emblems or enchantments were in play. Usually Vines works correctly so this might be hard to reproduce.

gamerfreak12345 wrote:Not sure what happened here. I attempt to kill a Strangleroot Geist with Lightning Bolt, and opponent responds with Vines of Vastwood. Vines fizzles for no apparent reason, letting the Bolt through.

Only two creatures on the battlefield were two Strangleroot Geists, one with a +1/1 counter on it from previous Undying trigger. No emblems or enchantments were in play. Usually Vines works correctly so this might be hard to reproduce.

Which Geist was targeted the one that had already returned from Undying?

:r31291
Kytheon, Hero of Akros has some bugs.

1, The name is wrong in his rule text.
It has become "Gideon, Battle-Forged".

2, I confirmed bug of transform once.
AI played Kytheon and end of turn.
Then in my end step, for some reason, Kytheon transfomed.
Needless to say, Kytheon had not attacked.
I don't know full occurrence condition.

Damage prevent Effects like from circle of Protection
Does need to check the card in the prevent Effect too.

609.7b Some effects from resolved spells and abilities prevent or replace damage from sources with certain properties, such as a creature or a source of a particular color. When the source would deal damage, the “shield” rechecks the source’s properties. If the properties no longer match, the damage isn’t prevented or replaced. If for any reason the shield prevents no damage or replaces no damage, the shield isn’t used up.

That also need to be done right because of card text changing effects.
I think I will do that while I try to implement Ghostly Flame

Hanmac wrote:Damage prevent Effects like from circle of Protection
Does need to check the card in the prevent Effect too.

609.7b Some effects from resolved spells and abilities prevent or replace damage from sources with certain properties, such as a creature or a source of a particular color. When the source would deal damage, the “shield” rechecks the source’s properties. If the properties no longer match, the damage isn’t prevented or replaced. If for any reason the shield prevents no damage or replaces no damage, the shield isn’t used up.

That also need to be done right because of card text changing effects.
I think I will do that while I try to implement Ghostly Flame

Well, for text-changing effects, once the shield is created, it's separated from the main card, so changing the text on the main card should not affect it.

For Ghostly Flame, my idea would be to introduce a function DamageColor which would:
1. Check if there's a Ghostly Flame effect set to one of the colors of the object
2. If not, return colors of the object
3. If yes, return colorless
Then, all effects that depend on color of damage source (there are not that many of those, but this notably includes protection from color) would be modified to check DamageColor instead of real color.

EDIT: Apart from protection, the cards affected by Ghostly Flame should be these:

Akki Lavarunner
Circle of Protection: Black
Circle of Protection: Blue
Circle of Protection: Green
Circle of Protection: Red
Circle of Protection: White
Embermaw Hellion
Fire Servant
Greater Realm of Preservation
Hunter's Ambush (not completely sure of this)
Penance
Pilgrim of Justice
Pilgrim of Virtue
Prismatic Circle
Pyromancer's Gauntlet
Rune of Protection: Black
Rune of Protection: Blue
Rune of Protection: Green
Rune of Protection: Red
Rune of Protection: White
Sphere of Duty
Sphere of Grace
Sphere of Law
Sphere of Reason
Sphere of Truth
Story Circle
Sulfuric Vapors
Undergrowth (not 100% sure)

@Marek14: "for text-changing effects, once the shield is created, it's separated from the main card, so changing the text on the main card should not affect it."
That is my problem with my latest Change for the Token Effect ... i did add the Change to fix it with your Tombspawn Zombie into Elf Token, but the fix was to good, and even if the Effect is already on the stack it does affect it when i change the text or the original card.
We need to find a way to fix that.
Currently you can change the text of the black token created by Riftmarked Knight. That should not be possible. But i currently have no idea how to fix that :/

===
that was my problem 609.7b says that such checks for Circle of Protection: Black does need to be done for the Effect too.
and for that the Effect does need to copy the text change that was already done for the main card.

Current Problem with changing color:
Circle of Protection: Black on the field.
Target a Black Creature => first Shield checks for black.
now i use color change to change that black creature into something else.
The Shield effect shouldn't work any more but it does now.

Problem with changing Text:
Circle of Protection: Black on the field.
Target a Black Creature => first Shield checks for black.
now i uses text change to change black to green. the first shield is not affected. Now:
Target a Green Creature => second Shield checks for green.

If i play Ghostly Flame now, the First Shield should lose its effect because while the creature it's still black, the damage is not.


@Marek14: my idea how i wanted to it:
first have Ghostly Flame add a Keyword to all Black/Red targets like "Is Colorless (Damage) Source"

then add new cases in Card#hasProperty so you can do: "Card+RedSource" or "Card+ColorlessSource" ... with that we might not change much on existing cards.

===
Replacement Effects or Prevent Effects from cards like Sphere of Grace or Embermaw Hellion are more easier. with my plan it should be only from "Card.Black" to "Card.BlackSource"

Cards that does create an Effect like Circle of Protection: Black are more complicated.
(i think the best idea would be to copy TextChange and Chosen* from the hostCard onto the Effect too)
===

PS:
Pyromancer's Gauntlet, Fire Servant, Hunter's Ambush, Sulfuric Vapors and Undergrowth are not affected, because they has "red instant" and others, not "red source" this is important, because the color of the card does not change.

also do not forget Lithomancer's Focus it does check for ColorlessSource so Red/Black sources with Ghostly Flame does work too.

Hanmac wrote:@Marek14: "for text-changing effects, once the shield is created, it's separated from the main card, so changing the text on the main card should not affect it."
That is my problem with my latest Change for the Token Effect ... i did add the Change to fix it with your Tombspawn Zombie into Elf Token, but the fix was to good, and even if the Effect is already on the stack it does affect it when i change the text or the original card.
We need to find a way to fix that.
Currently you can change the text of the black token created by Riftmarked Knight. That should not be possible. But i currently have no idea how to fix that :/

I haven't looked at the LKI stuff in a while, but ideally it would be something like this -

Record Card ID + Timestamp for a locked LKI version of that card which then would use that association for certain elements. The main difficulty is determining when you use the "on activation" LKI, vs. current state vs. "last seen" LKI.

Skeleton Shard lets you choose a card on resolution instead of targeting.