Collectible Card Game Headquarters

@onderzeeboot: currently there is no extra logic for Vehicle/Crew and AI does treat it like every other Animate Ability.

hm to add more logic into it, can you explain more about the situations, and how the AI should react to it?

If i understand you correctly it seems that AI does not use the Crew Ability? (or use it wrong?)

Hanmac wrote:If i understand you correctly it seems that AI does not use the Crew Ability? (or use it wrong?)

The main problem is when the defending player has a vehicle the AI will not attack into it even if it can't be crewed.

Also in r32193
Padeem, Consul of Innovation - Ability only seems to trigger on expensive artifacts, if i have a Prophetic Prism and my opponent has no artifacts it wont trigger.

I tried to improve the AI for Crew a bit when it comes to considering an attack while the opponent has a vehicle out (see r32210).

- Agetian

NullPointerException | Open

Code: Select all

Forge Version:    SVN
Operating System: Windows 8.1 6.3 amd64
Java Version:     1.8.0_25 Oracle Corporation

java.lang.NullPointerException
   at forge.game.spellability.SpellAbility.canTarget(SpellAbility.java:784)
   at forge.game.ability.effects.ChangeTargetsEffect.resolve(ChangeTargetsEffect.java:103)
   at forge.game.spellability.AbilitySub.resolve(AbilitySub.java:119)
   at forge.game.ability.AbilityUtils.resolveApiAbility(AbilityUtils.java:1296)
   at forge.game.ability.AbilityUtils.resolve(AbilityUtils.java:1277)
   at forge.ai.ComputerUtil.playNoStack(ComputerUtil.java:288)
   at forge.ai.PlayerControllerAi.playSpellAbilityNoStack(PlayerControllerAi.java:314)
   at forge.game.trigger.WrappedAbility.resolve(WrappedAbility.java:444)
   at forge.game.ability.AbilityUtils.resolveApiAbility(AbilityUtils.java:1296)
   at forge.game.ability.AbilityUtils.resolve(AbilityUtils.java:1277)
   at forge.game.zone.MagicStack.resolveStack(MagicStack.java:521)
   at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:978)
   at forge.game.GameAction.startGame(GameAction.java:1463)
   at forge.game.Match.startGame(Match.java:95)
   at forge.match.HostedMatch$2.run(HostedMatch.java:220)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)


r32213
AI's Captured by the Consulate effect is triggered in response to my Disappearing Act. I guess the crash is due to an illegal target change?

r: 32213

Hi. When i'm playing against AI in phase: "declare blockers" there's no option for crew a vehicle to block clicking on vehicle card. Is it correct? can I only crew a vehicle in my main phase?

Sorry my bad english

akuolum wrote:r: 32213

Hi. When i'm playing against AI in phase: "declare blockers" there's no option for crew a vehicle to block clicking on vehicle card. Is it correct? can I only crew a vehicle in my main phase?

Sorry my bad english

Once you are in your Declare Blockers step it is too late. The last time you are able to Crew (and block) is in the Declare Attackers step.

Twainer wrote:

Hanmac wrote:If i understand you correctly it seems that AI does not use the Crew Ability? (or use it wrong?)

The main problem is when the defending player has a vehicle the AI will not attack into it even if it can't be crewed.

That is indeed the main problem. I'll go test if Agetian's fix makes it better tonight

Another problem with vehicles I encountered was that my opponent played Fleetwheel Cruiser post-combat, but I see that has been fixed in the meantime with an "SVar:PlayMain1:TRUE"

r32223
Not really a bug, but maybe a possible AI improvement. CPU attacked a 3/1 flyer and a 2/2 flyer into my board. I didn't have a flyer, but I had a Dukhara Peafowl who could gain flying for U and I had one blue mana open.

If this is difficult to implement it mightn't be worth it, but not sure how easy it is.

r32223

Something weird is going on with the token (that was a copy of a creature) that is created by Saheeli's Artistry, several times in combat it should have died but did not.

Screenshot attached shows the token copied by Saheeli's Artistry took 1 damage but isn't dead.

@tjtillman that looks suspicious!
Can you test it if it happens at r32216 too? (Before some "fixes"?)

r32221:
AI problem: AI is attacking me with thriving turtle without energy counters (so he can't put +1/+1, the damage is 0 and he can't block later)

tjtillman wrote:r32223

Something weird is going on with the token (that was a copy of a creature) that is created by Saheeli's Artistry, several times in combat it should have died but did not.

Screenshot attached shows the token copied by Saheeli's Artistry took 1 damage but isn't dead.

Hanmac wrote:@tjtillman that looks suspicious!
Can you test it if it happens at r32216 too? (Before some "fixes"?)

Looks like it has more to do with AIs Fabricate code than anything else, an important part of the screenshot is missing and that's how much combat damage was dealt:

I quickly ran a scenario, and my Servo took 4 damage from the Maulfist Squad (meaning the UI thinks it's a 3/1 but the engine AND the AI think it's a 4/2), even though it also spawned a Servo of it's own...


I'm guessing the issue is related to the following code block --

Code: Select all

final Card copy = CardUtil.getLKICopy(host);
copy.setCounters(CounterType.P1P1, copy.getCounters(CounterType.P1P1) + n);
copy.setZone(host.getZone());


hmmm i did use that copy Card to get a copy which does have counters so i an compare it with a card without (and tokens)
the copy should not be added to the real battlefield, and the SetZone stuff should only be apply to the CheckAbilities below.

hm i will test it out if it works if the SetZone line is removed.

friarsol wrote:Looks like it has more to do with AIs Fabricate code than anything else, an important part of the screenshot is missing and that's how much combat damage was dealt:

I quickly ran a scenario, and my Servo took 4 damage from the Maulfist Squad (meaning the UI thinks it's a 3/1 but the engine AND the AI think it's a 4/2), even though it also spawned a Servo of it's own...

In this case I attacked with a 4/2 Maulfist Squad, and the CPU blocked with the copied Maulfist Squad and another creature (I don't recall what, but it wasn't a copy of something). I ordered the blockers to deal damage first to the CPU's copied Maulfist Squad. It dealt 1 damage to it, and the rest to the other creature. After damage step my creature and the 2nd creature died, the copied Maulfist squad did not.

When I have a chance I can try this with r32216 as well.

tjtillman wrote:In this case I attacked with a 4/2 Maulfist Squad, and the CPU blocked with the copied Maulfist Squad and another creature (I don't recall what, but it wasn't a copy of something). I ordered the blockers to deal damage first to the CPU's copied Maulfist Squad. It dealt 1 damage to it, and the rest to the other creature. After damage step my creature and the 2nd creature died, the copied Maulfist squad did not.

When I have a chance I can try this with r32216 as well.

The copy aspect is a red herring. It happens with a normal (AI controlled on ETB) Maulfist Squad too. But that description isn't any different than what I was describing. The UI thinks it's toughness is one, so when the UI spawns the window to distribute blocking damage it only says you need 1 damage.

I quickly commented out the Fabricate AI code, and it only deal 3 damage as expected. So there's definitely something in that part that's causing the issue.