Re: Bug Reports (snapshot builds)
Posted: 14 Dec 2016, 14:47Sapphire Charm crashes the game when cast in its first mode.
- NullPointerException | Open
Hmm, I remember there was a recent issue with another card that crashed in exactly the same way (AdditionalAbility in "Execute" not being filled), Hanmac fixed it recently, but apparently there are other similar cases (e.g. Sapphire Charm) that are not fixed yet :/ Tried looking at it but couldn't figure out how to solve it, maybe Hanmac will be able to resolve this one when possible.Marek14 wrote:Sapphire Charm crashes the game when cast in its first mode.
- NullPointerException | Open
EDIT: Ok, as a mockup for a solution, I committed r32695 - it fixes the crash but it does so by filling AdditionalAbility parameters for SAs parented to Charm API. Most likely something bigger is up here: should the relevant if statement be extended somehow differently to properly account for all cases where this Execute parameter may not be filled?
P.S. Jhoira of the Ghitu Avatar crash is also fixed (r32694).
- Agetian
However, the spell description on the stack is wrong (no matter if you pay 
or 
or both types of mana, the game says "<such-and-such-player> prevents all combat damage this turn". Couldn't figure out why, there is a correct SpellDescription on the ability. :/ The card functions correctly though.