Collectible Card Game Headquarters

NullPointerException | Open

Code: Select all

Forge Version:    1.5.58-SNAPSHOT-r32845
Operating System: Windows 7 6.1 amd64
Java Version:     1.8.0_25 Oracle Corporation

java.lang.NullPointerException
   at forge.game.replacement.ReplaceGainLife.canReplace(ReplaceGainLife.java:46)
   at forge.game.replacement.ReplacementHandler.run(ReplacementHandler.java:123)
   at forge.game.replacement.ReplacementHandler.run(ReplacementHandler.java:83)
   at forge.game.player.Player.doDraw(Player.java:1332)
   at forge.game.player.Player.drawCards(Player.java:1311)
   at forge.game.GameAction.startGame(GameAction.java:1430)
   at forge.game.Match.startGame(Match.java:95)
   at forge.match.HostedMatch$2.run(HostedMatch.java:220)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)


Marek14 wrote:Covenant of Minds is implemented incorrectly. If the opponent lets you put the three revealed cards into your hand, it should not count as drawing.

fmartel wrote:Description: [Before starting a game of commander, I was shuffling the random commander decks]

NullPointerException | Open

Code: Select all

Forge Version:    1.5.58-SNAPSHOT-r32845
Operating System: Windows 7 6.1 amd64
Java Version:     1.8.0_25 Oracle Corporation

java.lang.NullPointerException
   at forge.game.replacement.ReplaceGainLife.canReplace(ReplaceGainLife.java:46)
   at forge.game.replacement.ReplacementHandler.run(ReplacementHandler.java:123)
   at forge.game.replacement.ReplacementHandler.run(ReplacementHandler.java:83)
   at forge.game.player.Player.doDraw(Player.java:1332)
   at forge.game.player.Player.drawCards(Player.java:1311)
   at forge.game.GameAction.startGame(GameAction.java:1430)
   at forge.game.Match.startGame(Match.java:95)
   at forge.match.HostedMatch$2.run(HostedMatch.java:220)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)


fmartel wrote:with -r32845, in commander, I notice something NOT happening. I have Primal Vigor, Awakening Zone, Angelic Accord OTB, I play Grove of the Guardian and don't receive 2x 8/8 Elemental Token, same goes for the angel and Eldrazi spawn. everything else plays properly, (Angelic Accord [giving me an angel for gaining 4 life], Elemental Bond [Draw], Trostani [life gain])
Edit : The same issue happens with Parallel Lives. It doesnt double the token under my control.

Agetian wrote:

fmartel wrote:with -r32845, in commander, I notice something NOT happening. I have Primal Vigor, Awakening Zone, Angelic Accord OTB, I play Grove of the Guardian and don't receive 2x 8/8 Elemental Token, same goes for the angel and Eldrazi spawn. everything else plays properly, (Angelic Accord [giving me an angel for gaining 4 life], Elemental Bond [Draw], Trostani [life gain])
Edit : The same issue happens with Parallel Lives. It doesnt double the token under my control.

This is odd, I just tried these cases and they worked correctly for me, the tokens are definitely produced in twos (from all the cards mentioned). :/ Were there any other cards on the battlefield that could possibly have affected this?

- Agetian

Agetian wrote:Well, sadly I can't figure out what to do with Lifelink when the combat damage is replaced via ReplaceDamage.
The thing is, it's currently quite broken and even acts differently (and inconsistently) when the damage is dealt to a permanent or to a player. To wit:

* If a lifelink creature deals damage to a player while Gisela, Blade of Goldnight is in play, then double damage is dealt to the player, but no life gain happens at all (the damage is treated at 0 in Combat::dealAssignedDamage).

* If a lifelink creature deals damage to a permanent (creature) while Gisela, Blade of Goldnight is in play, then double damage is dealt to the creature, the life gain happens as well, but only as if the damage dealt was not double (for example, Baneslayer Angel would deal 10 damage to the creature, and the player would gain 5 life from lifelink).

Not sure how to best approach fixing this without breaking other stuff. :/

- Agetian

Code: Select all

-------------------------------------------------------------
forge/game/card/Card.java:[86,8] forge.game.card.Card is not abstract and does not override abstract method addDamageAfterPrevention(int,forge.game.card.Card,boolean) in forge.game.GameEntity
forge/game/card/Card.java:[6177,22] addDamageAfterPrevention(int,forge.game.card.Card,boolean) in forge.game.card.Card cannot override addDamageAfterPrevention(int,forge.game.card.Card,boolean) in forge.game.GameEntity
  return type int is not compatible with boolean
forge/game/card/Card.java:[6176,5] method does not override or implement a method from a supertype
forge/game/player/Player.java:[79,8] forge.game.player.Player is not abstract and does not override abstract method addDamageAfterPrevention(int,forge.game.card.Card,boolean) in forge.game.GameEntity
forge/game/player/Player.java:[537,22] addDamageAfterPrevention(int,forge.game.card.Card,boolean) in forge.game.player.Player cannot override addDamageAfterPrevention(int,forge.game.card.Card,boolean) in forge.game.GameEntity
  return type int is not compatible with boolean
forge/game/player/Player.java:[536,5] method does not override or implement a method from a supertype
forge/game/cost/CostDamage.java:[63,34] incompatible types: boolean cannot be converted to int
forge/game/ability/effects/DetachedCardEffect.java:[7,8] addDamageAfterPrevention(int,forge.game.card.Card,boolean) in forge.game.card.Card cannot override addDamageAfterPrevention(int,forge.game.card.Card,boolean) in forge.game.GameEntity
  return type int is not compatible with boolean
forge/game/ability/effects/DamageAllEffect.java:[82,41] incompatible types: boolean cannot be converted to int
forge/game/ability/effects/DamageAllEffect.java:[92,47] incompatible types: boolean cannot be converted to int
forge/game/ability/effects/DamageDealEffect.java:[144,27] bad operand types for binary operator '+'
  first type:  int
  second type: boolean
forge/game/ability/effects/DamageDealEffect.java:[165,70] incompatible types: boolean cannot be converted to int
forge/game/ability/effects/DamageDealEffect.java:[178,54] incompatible types: boolean cannot be converted to int
forge/game/ability/effects/DamageDealEffect.java:[190,70] incompatible types: boolean cannot be converted to int
forge/game/ability/effects/DamageDealEffect.java:[201,54] incompatible types: boolean cannot be converted to int
forge/game/ability/effects/DamageEachEffect.java:[83,35] bad operand types for binary operator '+'
  first type:  int
  second type: boolean
forge/game/ability/effects/DamageEachEffect.java:[89,35] bad operand types for binary operator '+'
  first type:  int
  second type: boolean
forge/game/ability/effects/DamageEachEffect.java:[105,50] incompatible types: boolean cannot be converted to int
forge/game/ability/effects/DamageEachEffect.java:[122,39] bad operand types for binary operator '+'
  first type:  int
  second type: boolean
forge/game/ability/effects/FightEffect.java:[112,43] incompatible types: boolean cannot be converted to int
20 errors


Agetian wrote:Thanks a lot! Sure thing, I'll be happy to test it out, I'll keep this post updated for further test results.

For the time being, however, I'm unable to launch it since I'm getting a lot of compilation errors:

Code: Select all

-------------------------------------------------------------
forge/game/card/Card.java:[86,8] forge.game.card.Card is not abstract and does not override abstract method addDamageAfterPrevention(int,forge.game.card.Card,boolean) in forge.game.GameEntity
forge/game/card/Card.java:[6177,22] addDamageAfterPrevention(int,forge.game.card.Card,boolean) in forge.game.card.Card cannot override addDamageAfterPrevention(int,forge.game.card.Card,boolean) in forge.game.GameEntity
  return type int is not compatible with boolean
forge/game/card/Card.java:[6176,5] method does not override or implement a method from a supertype
forge/game/player/Player.java:[79,8] forge.game.player.Player is not abstract and does not override abstract method addDamageAfterPrevention(int,forge.game.card.Card,boolean) in forge.game.GameEntity
forge/game/player/Player.java:[537,22] addDamageAfterPrevention(int,forge.game.card.Card,boolean) in forge.game.player.Player cannot override addDamageAfterPrevention(int,forge.game.card.Card,boolean) in forge.game.GameEntity
  return type int is not compatible with boolean
forge/game/player/Player.java:[536,5] method does not override or implement a method from a supertype
forge/game/cost/CostDamage.java:[63,34] incompatible types: boolean cannot be converted to int
forge/game/ability/effects/DetachedCardEffect.java:[7,8] addDamageAfterPrevention(int,forge.game.card.Card,boolean) in forge.game.card.Card cannot override addDamageAfterPrevention(int,forge.game.card.Card,boolean) in forge.game.GameEntity
  return type int is not compatible with boolean
forge/game/ability/effects/DamageAllEffect.java:[82,41] incompatible types: boolean cannot be converted to int
forge/game/ability/effects/DamageAllEffect.java:[92,47] incompatible types: boolean cannot be converted to int
forge/game/ability/effects/DamageDealEffect.java:[144,27] bad operand types for binary operator '+'
  first type:  int
  second type: boolean
forge/game/ability/effects/DamageDealEffect.java:[165,70] incompatible types: boolean cannot be converted to int
forge/game/ability/effects/DamageDealEffect.java:[178,54] incompatible types: boolean cannot be converted to int
forge/game/ability/effects/DamageDealEffect.java:[190,70] incompatible types: boolean cannot be converted to int
forge/game/ability/effects/DamageDealEffect.java:[201,54] incompatible types: boolean cannot be converted to int
forge/game/ability/effects/DamageEachEffect.java:[83,35] bad operand types for binary operator '+'
  first type:  int
  second type: boolean
forge/game/ability/effects/DamageEachEffect.java:[89,35] bad operand types for binary operator '+'
  first type:  int
  second type: boolean
forge/game/ability/effects/DamageEachEffect.java:[105,50] incompatible types: boolean cannot be converted to int
forge/game/ability/effects/DamageEachEffect.java:[122,39] bad operand types for binary operator '+'
  first type:  int
  second type: boolean
forge/game/ability/effects/FightEffect.java:[112,43] incompatible types: boolean cannot be converted to int
20 errors


- Agetian