Collectible Card Game Headquarters

Hey everyone,

I made a patch for changing some hardcoded values regarding how the shop works in quest mode into preferences. I already posted it over in this thread, but as it wasn't noticed yet and it fits better in the development subforum anyway, I'll post it here now.
If any dev approves of this, please go ahead and commit it

The preferences, their min and max values, and their defaults are:

Maximum Packs: 1-25, default 6
Starting Packs: 0-15, default 4
Wins for Pack: 1-25, default 10
Common Singles: 0-15, default 7
Uncommon Singles: 0-15, default 3
Rare Singles: 0-15, default 1

With the default settings, behavior is unchanged.

I applied your patch Roujin. Thank you.

You can have commit status if you want to contribute more.

Thanks for including

I'd rather not at the current time - I actually have a load of work to do right now, I was just granting myself a little time off. If I had direct commit rights to this wonderful project I fear my self discipline would not be enough to prevent me from neglecting my work in favor of coding stuff for Forge

Maybe at some later point though

Edit: Doublestrike, if you're reading this, your commit r13822 that touched QuestPreferencesHandler.java missed to remove the line

Code: Select all

lblErrShop.setFontStyle(Font.BOLD);

(I guess, since you removed that line for the other lblErrs)

Roujin wrote:I fear my self discipline would not be enough to prevent me from neglecting my work in favor of coding stuff for Forge

I have this problem myself - apologies to my boss

Edit: Doublestrike, if you're reading this, your commit r13822 that touched QuestPreferencesHandler.java missed to remove the line

Code: Select all

lblErrShop.setFontStyle(Font.BOLD);

(I guess, since you removed that line for the other lblErrs)

Okey doke, will fix when home (hopefully I remember).