WIP: Quest deck cosmetic revamp of basic lands

[Agetian]

Hello guys,
It's been a while since I did anything Forge-related, time to fix that a little bit. I've been working on a little something for a while and I'm curious if it would be of any interest to the team - in particular, I found it a bit weird that every quest opponent that you're facing in Forge has a complete set of fancy-looking awesome new Zendikar lands, no matter what cards he has in his deck - everyone uses Zendikar lands. My little project aims to fix that, and I'm applying a simple algorithm that in my opinion makes sense: first, I check to see which set is the most modern set from which the cards exist in the deck, and then I change the set of basic lands to the set which is the closest in time to the identified set in which the basic lands actually exist (so basically, if the deck utilizes cards that are as modern as Magic 2010 but not any newer, the basic lands in the deck will use the M10 set (instead of Zendikar). If the cards are only as new as 7th Edition, then the basic lands will be from the 7ED set, etc. It's a purely cosmetic change but it makes sense to me. If it's of interest to the general public, I'll publish the revamped deck files once I'm done (and possibly the software I'm using to change the decks - it's currently a bit rough on the edges and still not 100% crash-proof).
Best regards and good luck with Forge!

[moomarc]

+1 - I'm always a fan of cosmetic changes!

[Max mtg]

This change will make useless the lands you obtain during quest, moreover - player won't be able to fit custom lands into his deck then.

If one has earned some how the pretty zendikar lands and has them in his inventory and decks, so once he adds a spell from Innistrad, will all of his lands be auto-converted to ISD set ones?

[Sloth]

This change will make useless the lands you obtain during quest, moreover - player won't be able to fit custom lands into his deck then.

If one has earned some how the pretty zendikar lands and has them in his inventory and decks, so once he adds a spell from Innistrad, will all of his lands be auto-converted to ISD set ones?

Agetian is talking about lands in the opponents deck.

I just want to throw in that some of the decks have basic lands with a set info (like "Forest|SOM") those should be untouched by this algorithm.

[Max mtg]

Oh, i got the idea.

It's impossible to distinguish, whether the set was explicitly set, after the deck is loaded. When it is, each card is assigned a set. By which rules? That is to be investigated.

[Agetian]

@ Max mtg: Yep, like Sloth said, it only concerns the opponents' basic lands (and specifically the ones that have not yet been assigned a set by the deck creator). Players' lands will be left untouched. As far as the algorithm in Forge goes that auto-assigns the set if no set info is specified, I haven't looked at the code but it looks like it just assigns the set code that is the latest alphabetically and contains the given card (so, Plains etc. are from Zendikar cause Zendikar [ZEN] starts with a Z). That's my idea of it, at least. [btw, while we're talking about player's lands - is there really a way to obtain non-M10 basic lands in quest mode? The card shop always sells M10 ones, and I don't think you get basic lands for winning battles, at least I haven't seen that happen ever in my questing... did I miss something? )

@ Sloth: Yep, the decks that already have set definitions are not touched in any way.

[timmermac]

@ Max mtg: Yep, like Sloth said, it only concerns the opponents' basic lands (and specifically the ones that have not yet been assigned a set by the deck creator). Players' lands will be left untouched. As far as the algorithm in Forge goes that auto-assigns the set if no set info is specified, I haven't looked at the code but it looks like it just assigns the set code that is the latest alphabetically and contains the given card (so, Plains etc. are from Zendikar cause Zendikar [ZEN] starts with a Z). That's my idea of it, at least. [btw, while we're talking about player's lands - is there really a way to obtain non-M10 basic lands in quest mode? The card shop always sells M10 ones, and I don't think you get basic lands for winning battles, at least I haven't seen that happen ever in my questing... did I miss something? )

@ Sloth: Yep, the decks that already have set definitions are not touched in any way.

If you buy boosters in the card shop, especially from the more recent sets, there's a basic land in each pack. I'm hoping for the addition of starter/tournament packs for those sets that had them, so that we can get other basic lands in as well for added variety.

[Max mtg]

As far as the algorithm in Forge goes that auto-assigns the set if no set info is specified, I haven't looked at the code but it looks like it just assigns the set code that is the latest alphabetically and contains the given card (so, Plains etc. are from Zendikar cause Zendikar [ZEN] starts with a Z). That's my idea of it, at least.

That's correct.

When CardDb returns a CardPrinted from getCard(name) function, it looks in "uniqueCards" map, which is filled with that edition of each card which came last from "setsData" map iteration (setsData in defined in class CardRuleCharacteristics). The TreeMap provides "natural ordering of its keys", so that iteration returns them ordered. That is why undefined set of lands turns into Zendikar.

[Agetian]

OK, here's the zip file with the modded decks - the ones which already had set definitions are untouched, and the ones which did not now have sets assigned according to the algorithm above (mostly it turned out to be various modern sets, between 9th Edition and the latest, due to the reprints - but still, it adds variety to the AI decks and it's not all fancy ZEN ). Now, a little problem: even though the algorithm is intrinsically non-destructive, you never know where it could have in theory gone wrong. I playtested over 30 decks yesterday and did not have any issues, but I can hardly playtest all ~400... is there any checking mechanism or a test unit or something that can be used to assert that all the deck files are still valid? (they should be, I'm 99% sure that they are, but if there's a possibility to auto-test them for validity, it's probably a good idea to do it now). At any rate, playtesting reports are welcome. Have fun!

P.S. This folder ("decks") goes into "quest", not the regular "decks" (I'm sure the dev team knows this perfectly, but this is in case someone else wants to playtest).

[Sloth]

OK, here's the zip file with the modded decks - the ones which already had set definitions are untouched, and the ones which did not now have sets assigned according to the algorithm above (mostly it turned out to be various modern sets, between 9th Edition and the latest, due to the reprints - but still, it adds variety to the AI decks and it's not all fancy ZEN ). Now, a little problem: even though the algorithm is intrinsically non-destructive, you never know where it could have in theory gone wrong. I playtested over 30 decks yesterday and did not have any issues, but I can hardly playtest all ~400... is there any checking mechanism or a test unit or something that can be used to assert that all the deck files are still valid? (they should be, I'm 99% sure that they are, but if there's a possibility to auto-test them for validity, it's probably a good idea to do it now). At any rate, playtesting reports are welcome. Have fun!

P.S. This folder ("decks") goes into "quest", not the regular "decks" (I'm sure the dev team knows this perfectly, but this is in case someone else wants to playtest).

Some of your deck lists are out of date. Please grab the latest SVN version before you modify them.

[Agetian]

@ Sloth: Oh, sorry - I didn't think about actually grabbing the SVN so I did the 1.2.3 decks. Anyway, here's the same mod for the latest (at the moment of writing) SVN revision 13980. Hope it's OK this time!

[Chris H.]

For awhile things got a little hectic with the change from SVN to GIT and then back to a different SVN.

Following the instructions found on our current wiki will allow you to pull the most recent versions of the quest decks.

http://www.slightlymagic.net/wiki/Forge:How_to_Get_Started_Developing_Forge

Once you are set up you can request commit status and it is fairly easy to grant this status.

You can place the modded decks files into the /res/decks/ folder and then start up forge. You will get a dialog at start up if forge can not handle one or more of these modded deck files. The testing is fairly minimal.

[Agetian]

@ Chris H: Hmm that's what I did when I pulled SVN 13980... did I pull the wrong thing then? (that was the revision that got checked out when I followed the steps at "How to get started developing Forge" just now -- from svn.slightlymagic.net, that is (not from GIT or old SVN). :\ If it's still wrong, then I'm confused.

[Chris H.]

@ Chris H: Hmm that's what I did when I pulled SVN 13980... did I pull the wrong thing then? (that was the revision that got checked out when I followed the steps at "How to get started developing Forge" just now -- from svn.slightlymagic.net, that is (not from GIT or old SVN). :\ If it's still wrong, then I'm confused.

`
I think that everything is OK.

You were able to pull the most recent versions of the quest decks, mod them and then post an updated archive ...

while I was slowly writing my response to your earlier message. So you were in essence following my advice before I could even post it.

Let me know if you want commit status, I can add you to the list of devs.

[Sloth]

@ Sloth: Oh, sorry - I didn't think about actually grabbing the SVN so I did the 1.2.3 decks. Anyway, here's the same mod for the latest (at the moment of writing) SVN revision 13980. Hope it's OK this time!

I went ahead and submitted your deck lists. Thanks Agetian.